Re: [PATCH v0] Dynamic ACPI framework for fsl layerscape platforms

["Leif Lindholm" <leif@nuviainc.com>]

We usually start from v1 :)

However, there is something weird with this set (like the missing 0/1,
1/1 in the subject lines)- please make sure you follow the
instructions from
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers
when generating patches.

/
    Leif

On Tue, Dec 29, 2020 at 12:55:57 +0530, Vikas Singh wrote:
> This patch series sets the foundation of Dynamic ACPI framework
> for fsl layerscape platforms.
> In order to achieve :
>  - Configurable firmware builds.
>  - Unify firmware build for similar platforms.
>  - Minimize/eliminate human induced errors.
>  - Ability to validate, and generate firmware that complies with
>    relevant specifications
> this change set introduced following changes in below defined order
> under edk2-platforms/NXP for LX2160ARDB.
> 
> (1) Introduced edk2-platforms/NXP/ConfigurationManager
>     It creates the platform repositories dynamically during build time and
>     initializes with platform specific information and serves all requestes
>     from OEM/standard firmware table generators.
>     This Configuration Manager will be common for all fsl platforms.
> 
> (2) Introduced edk2-platforms/NXP/LX2160ARDB/Include/Platform.h
>     It has all the declarations & definitions specified for the platforms.
>     These macros will be consumed by Configuration Manager.
>     Additionally the placement of this header under "Include" dir will make
>     these macro's availale to other translation units of the platform built.
> 
> (3) Introduced edk2-platforms/NXP/LX2160ARDB/AcpiTablesInclude
>     This is a placeholder for - OEM specific firmware acpi table generators.
>     This also holds IP specific - DSDT/SSDT generators for the OEM's platform.
>     Currently Dsdt.asl is a place holder having only platform's clock related
>     dsdt properties for LX2160ARDB but it is intended to extend this Dsdt.asl
>     to hold other table as well in next patch series.
> 
> (4) Introduced a new "DYNAMIC_ACPI_ENABLE" flag to control DACPI framework for
>     LX2160ARDB platform.
>     By default it is enabled and can extend to other fsl platforms in future.
>     Changes can be referred under :
>       - LX2160ARDb.dsc
>       - LX2160ARDB.fdf
> 
> (5) Introduced a "build.sh" script under edk2-platforms/NXP/ to automate the
>     fsl platforms build system. And also mandatorily need to support Dynamic
>     ACPI framework for fsl platforms. It exports build environment variables
>     and also invokes "Env.cshrc".
> 
> Vikas Singh (1):
>   Platform/NXP: Add Dynamic Acpi for layerscape platforms
> 
>  .../ConfigurationManager/ConfigurationManager.dec  |  24 +
>  .../ConfigurationManager.dsc.inc                   |  21 +
>  .../ConfigurationManagerDxe/ConfigurationManager.c | 709 +++++++++++++++++++++
>  .../ConfigurationManagerDxe/ConfigurationManager.h | 229 +++++++
>  .../ConfigurationManagerDxe.inf                    |  52 ++
>  .../Include/PlatformAcpiTableGenerator.h           |  20 +
>  Platform/NXP/Env.cshrc                             |  73 +++
>  .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl   |  40 ++
>  .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl  |  15 +
>  .../AcpiTablesInclude/PlatformAcpiDsdtLib.inf      |  39 ++
>  .../PlatformAcpiDsdtLib/RawDsdtGenerator.c         | 146 +++++
>  .../AcpiTablesInclude/PlatformAcpiLib.h            |  24 +
>  Platform/NXP/LX2160aRdbPkg/Include/Platform.h      | 244 +++++++
>  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec       |   6 +-
>  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc       |  30 +
>  Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf       |  12 +
>  Platform/NXP/build.sh                              | 121 ++++
>  17 files changed, 1804 insertions(+), 1 deletion(-)
>  create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManager.dec
>  create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManager.dsc.inc
>  create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
>  create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
>  create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
>  create mode 100644 Platform/NXP/ConfigurationManager/Include/PlatformAcpiTableGenerator.h
>  create mode 100755 Platform/NXP/Env.cshrc
>  create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl
>  create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl
>  create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf
>  create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c
>  create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h
>  create mode 100644 Platform/NXP/LX2160aRdbPkg/Include/Platform.h
>  create mode 100755 Platform/NXP/build.sh
> 
> -- 
> 2.7.4
>