From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.groups.io with SMTP id smtpd.web12.13585.1610245847177241949 for ; Sat, 09 Jan 2021 18:30:47 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=aq/IPWB4; spf=pass (domain: nuviainc.com, ip: 209.85.221.49, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f49.google.com with SMTP id r7so12723784wrc.5 for ; Sat, 09 Jan 2021 18:30:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fq8ul9aFS2HJiKDbM2HnQVszdNJbSPXwC5FNcIkI7G8=; b=aq/IPWB4LbFCn3k3slJ8OZb9nhuJ7xBOncCbratn9ZMvt4fswMNCIsT0fsz12GpRv4 PLzp9+MsYccfyn65dvhsJK4ssuR5O2HrSnfCYERq4MJ+WUbkRyIvv+wlEIBqkV9filvY thujupZRzqjAjWd1vcrCk+nfdKqL9BolyRP9fnXfUIxdeUjUk8cRWsycWSDH1PzG2VZ8 8ZC9+zeYaDzne2phqGImQzkYBLn1irmm7nX9lyEMWMdk2D+VLKin134Dd8BCSAmKE3Xx lIRG7UdWKCIlKnv3wlGWNUre5zJKxEbHrJFzXuQW7RJp+yEuIjlMKreDVFPCyJKn1iaS L+4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fq8ul9aFS2HJiKDbM2HnQVszdNJbSPXwC5FNcIkI7G8=; b=GvmseS9AOM4oySO8OZhsKkOGqITUPidokcPf4ZHQeZeDJpRraspz80Oi0kQc7iqzmv Bw55hoeYnC97Ge+wNC6romDENTXF8jth18+roqvbBcv4W+5uGAaEz0Q7wikPnxn0ZCci wm3bpSmSNftbZNLyVjlgoZmkXIFEIDJE48CllU8uE01WK5EeGhpCA2dvdPSRwku2s1FB 0JonS9LR9a4Yilvl6qC+jfrMggTLVpwWTOKRtVM6IsS9MJgcqWxWqW6DgQjxmxWK43N0 4LBBqjmhIvpMrwePOf2tgcl1dmhItPHn+n6bYnl5dW1VMnoi+mgoPk1YPlE6QhmaVL9S e2gA== X-Gm-Message-State: AOAM531cPcg00CEkxp4lRPesZJE1Ko7eV+cjphlujrfdlXNpczmbHxkZ Yw0VpP3uLBghbf68KuichwafXA== X-Google-Smtp-Source: ABdhPJyme7YxAWfquckwU4rV7Tarq8n/fFbb4grYPFfJf8T+B2FiXjv7H6bOgEBmBN9l6l45lTSHVQ== X-Received: by 2002:a05:6000:1152:: with SMTP id d18mr10366951wrx.6.1610245845750; Sat, 09 Jan 2021 18:30:45 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id k1sm19188613wrn.46.2021.01.09.18.30.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jan 2021 18:30:45 -0800 (PST) Date: Sun, 10 Jan 2021 02:30:43 +0000 From: "Leif Lindholm" To: Vikas Singh Cc: devel@edk2.groups.io, sami.mujawar@arm.com, meenakshi.aggarwal@nxp.com, paul.yang@arm.com, augustine.philips@arm.com, samer.el-haj-mahmoud@arm.com, v.sethi@nxp.com, arokia.samy@puresoftware.com, kuldip.dwivedi@puresoftware.com, ard.biesheuvel@arm.com, vikas.singh@nxp.com Subject: Re: [PATCH v0] Dynamic ACPI framework for fsl layerscape platforms Message-ID: <20210110023043.GJ1664@vanye> References: <1609226758-19867-1-git-send-email-vikas.singh@puresoftware.com> MIME-Version: 1.0 In-Reply-To: <1609226758-19867-1-git-send-email-vikas.singh@puresoftware.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline We usually start from v1 :) However, there is something weird with this set (like the missing 0/1, 1/1 in the subject lines)- please make sure you follow the instructions from https://github.com/tianocore/tianocore.github.io/wiki/Laszlo%27s-unkempt-git-guide-for-edk2-contributors-and-maintainers when generating patches. / Leif On Tue, Dec 29, 2020 at 12:55:57 +0530, Vikas Singh wrote: > This patch series sets the foundation of Dynamic ACPI framework > for fsl layerscape platforms. > In order to achieve : > - Configurable firmware builds. > - Unify firmware build for similar platforms. > - Minimize/eliminate human induced errors. > - Ability to validate, and generate firmware that complies with > relevant specifications > this change set introduced following changes in below defined order > under edk2-platforms/NXP for LX2160ARDB. > > (1) Introduced edk2-platforms/NXP/ConfigurationManager > It creates the platform repositories dynamically during build time and > initializes with platform specific information and serves all requestes > from OEM/standard firmware table generators. > This Configuration Manager will be common for all fsl platforms. > > (2) Introduced edk2-platforms/NXP/LX2160ARDB/Include/Platform.h > It has all the declarations & definitions specified for the platforms. > These macros will be consumed by Configuration Manager. > Additionally the placement of this header under "Include" dir will make > these macro's availale to other translation units of the platform built. > > (3) Introduced edk2-platforms/NXP/LX2160ARDB/AcpiTablesInclude > This is a placeholder for - OEM specific firmware acpi table generators. > This also holds IP specific - DSDT/SSDT generators for the OEM's platform. > Currently Dsdt.asl is a place holder having only platform's clock related > dsdt properties for LX2160ARDB but it is intended to extend this Dsdt.asl > to hold other table as well in next patch series. > > (4) Introduced a new "DYNAMIC_ACPI_ENABLE" flag to control DACPI framework for > LX2160ARDB platform. > By default it is enabled and can extend to other fsl platforms in future. > Changes can be referred under : > - LX2160ARDb.dsc > - LX2160ARDB.fdf > > (5) Introduced a "build.sh" script under edk2-platforms/NXP/ to automate the > fsl platforms build system. And also mandatorily need to support Dynamic > ACPI framework for fsl platforms. It exports build environment variables > and also invokes "Env.cshrc". > > Vikas Singh (1): > Platform/NXP: Add Dynamic Acpi for layerscape platforms > > .../ConfigurationManager/ConfigurationManager.dec | 24 + > .../ConfigurationManager.dsc.inc | 21 + > .../ConfigurationManagerDxe/ConfigurationManager.c | 709 +++++++++++++++++++++ > .../ConfigurationManagerDxe/ConfigurationManager.h | 229 +++++++ > .../ConfigurationManagerDxe.inf | 52 ++ > .../Include/PlatformAcpiTableGenerator.h | 20 + > Platform/NXP/Env.cshrc | 73 +++ > .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl | 40 ++ > .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl | 15 + > .../AcpiTablesInclude/PlatformAcpiDsdtLib.inf | 39 ++ > .../PlatformAcpiDsdtLib/RawDsdtGenerator.c | 146 +++++ > .../AcpiTablesInclude/PlatformAcpiLib.h | 24 + > Platform/NXP/LX2160aRdbPkg/Include/Platform.h | 244 +++++++ > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec | 6 +- > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 30 + > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 12 + > Platform/NXP/build.sh | 121 ++++ > 17 files changed, 1804 insertions(+), 1 deletion(-) > create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManager.dec > create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManager.dsc.inc > create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c > create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h > create mode 100644 Platform/NXP/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > create mode 100644 Platform/NXP/ConfigurationManager/Include/PlatformAcpiTableGenerator.h > create mode 100755 Platform/NXP/Env.cshrc > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h > create mode 100644 Platform/NXP/LX2160aRdbPkg/Include/Platform.h > create mode 100755 Platform/NXP/build.sh > > -- > 2.7.4 >