From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.groups.io with SMTP id smtpd.web09.27770.1610328581411237262 for ; Sun, 10 Jan 2021 17:29:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=CggqFjWV; spf=pass (domain: nuviainc.com, ip: 209.85.221.53, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f53.google.com with SMTP id r7so14736138wrc.5 for ; Sun, 10 Jan 2021 17:29:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1DP4lNItfpcQPeXCWH/hf+Y2OJNQAeVMskudKDt0eWY=; b=CggqFjWVD5L71rmtUG4uulbmEjrpgfzKSt/QH2fY1SlfsvWs/K3rgp9rrrgTYEO5K/ 3CbbzIe1cEAlHkuJPJIPrv6xYEprq/u8tM+lJaAQmv24uXOm3lYkppPhnHu9aKccf/pq bT4exf7xu7bWodFQtOpO4OrnvL84muJOYsvCOwt6HflRq1GFnq33zNFvr5gm1HK1uGp8 H7nXHZ4GaOojFwDdiQ25EpnpgCGjz9LwTpPxmX18MnINqG3UqLDRvNwLYwKb8gXTpi/o kOH78A5VmYlFljWqToaveDkZh53mxklwLU5b9s2RAwiob/Fo5TIxV+Sv7yoiti1ZITsG ytfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1DP4lNItfpcQPeXCWH/hf+Y2OJNQAeVMskudKDt0eWY=; b=DbqfKQ/mDq5IS1Ds6PL0YqxaeByJMCulzAy+ywONg8e0+vpvzzb5+Q/aOZ1tqiZWYq AErC5DQ2Zb8tJIXeG+QYlqfPDV9u8PY0vuvup4egLxXnLXivX+oBXpnPfDrsEsHS/QTK CDRMmC/E6QkUyNUeosv4Py1V+f9GfOmJ0FF9EHRHgZRuttDKtSfqeNmif5+6DxHi+JS9 FAdPCvd+5LZ//owYwJAF6id45qvnAgJRQRSBg6oekYdXvbx1N1/VPDQI7t8yya6cqxS5 JQefQ+l7n9rQFaOkmjiVFfymgLwJo4msTL6MOUUM+neZFFToxgc7tTKMEOZSUhE7f6AF gHLQ== X-Gm-Message-State: AOAM5332PfpWql+q/fsrrBjZDdvwZ0Mn74MAQnu5CjQ/AC5360HPsHVn Up+GrLeqOVbCPMC1uKugLhi2Kg== X-Google-Smtp-Source: ABdhPJwYJ39+B1gqTUckCfoLHq5JvhYRwenLMWfZ6E+JdjNZWgF/8jfrF8/NnJf4Dc0vHFb8226frA== X-Received: by 2002:adf:9d82:: with SMTP id p2mr13825023wre.330.1610328580031; Sun, 10 Jan 2021 17:29:40 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id l8sm20733328wmf.35.2021.01.10.17.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Jan 2021 17:29:39 -0800 (PST) Date: Mon, 11 Jan 2021 01:29:37 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel , "nd @ arm . com . Sami Mujawar" , Liming Gao , Michael D Kinney , Zhiguang Liu Subject: Re: [PATCH v5 18/23] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe Message-ID: <20210111012937.GL1664@vanye> References: <20210104225830.12606-1-rebecca@nuviainc.com> <20210104225830.12606-19-rebecca@nuviainc.com> <20210110020349.GD1664@vanye> <83f2cdf3-d988-e943-3347-12a7dab20ea9@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <83f2cdf3-d988-e943-3347-12a7dab20ea9@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 10, 2021 at 17:21:16 -0700, Rebecca Cran wrote: > On 1/9/21 7:03 PM, Leif Lindholm wrote: > > On Mon, Jan 04, 2021 at 15:58:25 -0700, Rebecca Cran wrote: > > > > +#include > > > +#include > > > > We appear to still have a discrepancy w.r.t. Smbios/SmBios capitalisation. > > I was planning to commit the SMBIOS series and then fix the capitalization > of the header to be Smbios.h - should I do it the other way around? That would make this set cleaner. Also, we're approaching the halfway point of this development cycle, and since renaming IndustryStandard/SmBios.h and Guid/SmBios.h *will* break many out-of-tree platforms, it's better to get it in sooner rather than later. (Presumably builds on Windows and Os X will succeed anyway, but ...) It would be nice if you could also submit a set fixing up the include statements in all of the edk2-platforms ports. / Leif