From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.groups.io with SMTP id smtpd.web09.32944.1610365677729546822 for ; Mon, 11 Jan 2021 03:47:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=SH1VAXm3; spf=pass (domain: nuviainc.com, ip: 209.85.128.48, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f48.google.com with SMTP id n16so10717466wmc.0 for ; Mon, 11 Jan 2021 03:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=w4+VVMZYBZ4GE+XG/nJ74REn1sXbdC1dkmH09IK/6U8=; b=SH1VAXm3J3LpYiazDFb0opCWYPaBa3u/6l4Kc7ud3D/AqbTd6rgawWE+ci9DygZN6d jxOS0YUIU9r1654sbHtbbCjKvgW5AjxpyXFQm4FTee9mdDusbr22vWen5NmnuJAD1XZx Z/YbpcDwX2cKSWeBp+N8mdiJKQhweR+wKLE9a+AILIcG7WoG50keVxv8Y52bKaD+4w3L jwAo3jrkI84dJ2qA3IOYhD7i4GsSVZZZOgqX05/utDbiV7Tga7o2HmGDmMWYYWoFaN6n 6a6LZvbh9tYBwANcpNQywbyBe4kDd32qIZIdG3I4xiUDFvxQ46oJazIyMgCOugfP5urQ C0HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=w4+VVMZYBZ4GE+XG/nJ74REn1sXbdC1dkmH09IK/6U8=; b=YW/yTGxQGT/cB07TYWQS7eszpX6HPc6hiFGksZTZQWu2ahyoxMCfz3+xWhuIv4rR8m WVlZ6hqtAYethGiatMItFnpApBpItjaPT6Jcx4HILKQzL2ySnvpZps9yhsYo1Rl4+uNH dZpqTg97BB/2Inr5CnUKNZ7zSNTTmv2Snf89IzrpmFtJb92//DteE+D+GqVa5WDt1wWN l+ve0KZ/7FwAddrPxdFPCgafkluAiZysNPphlp3GEcHhXqHF/CUpk08cVq96jTWyGneV NVCvCG69Xaeeg45J7Nmm2BnU+RFVioDqsADaBtOoptdVTQZsXS/rMSQmrWWhcxeNtGvt OQHQ== X-Gm-Message-State: AOAM533kC9gTIj/fivr39DChW/myCwU6nuRYgn85AQ1FwFG/rGhJylu/ wSLnNK15Dmu+TTevou57+tUvYg== X-Google-Smtp-Source: ABdhPJyphEa9IibPq0Jlb4ZMXaVMJFf+M3LVNn+W5nQDLNNUOLMqcs7K0/NSP1QXeIPyxuQRE9H/2Q== X-Received: by 2002:a1c:4c07:: with SMTP id z7mr14253553wmf.142.1610365676204; Mon, 11 Jan 2021 03:47:56 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id z6sm20934954wmi.15.2021.01.11.03.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 03:47:55 -0800 (PST) Date: Mon, 11 Jan 2021 11:47:53 +0000 From: "Leif Lindholm" To: "Kinney, Michael D" Cc: Rebecca Cran , "devel@edk2.groups.io" , "Chaganty, Rangasai V" , Liming Gao , "Steele, Kelly" , "Agyeman, Prince" , "Sun, Zailiang" , "Qian, Yi" , Ard Biesheuvel , Wenyi Xie , "Chiu, Chasel" , "Ni, Ray" , Abner Chang , Daniel Schaefer , Gilbert Chen , Thomas Abraham , Pete Batard , Marcin Wojtas Subject: Re: [edk2-platforms PATCH 0/1] Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h' Message-ID: <20210111114753.GN1664@vanye> References: <20210111033102.21357-1-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 11, 2021 at 04:42:49 +0000, Kinney, Michael D wrote: > Hi Rebecca, > > Where is the review of the change to rename SmBios.h to Smbios.h in MdePkg? > > I do not think that change is a good idea because it would impact > every downstream platform that produces SMBIOS records. If those platforms are tracking master, this sort of thing should be expected. If they are jumping between stable tags, they are likely to have more things than this to worry about on each rebase. If they are "randomly" cherry-picking patches, they will already be used to fixing up much worse things like this. Not to mention that platforms that build only on Windows and Os X are unlikely to even notice due to case insensitive filesystems. And in my experience, if they ever move to build on a case-sensitive filesystem, they will as a result find many other case typos to fix. As Sean said: "If a platform dev model can't handle this type of breaking change then this project is paralyzed and bigger things should be addressed." / Leif > > Mike > > > -----Original Message----- > > From: Rebecca Cran > > Sent: Sunday, January 10, 2021 7:31 PM > > To: devel@edk2.groups.io > > Cc: Rebecca Cran ; Chaganty, Rangasai V ; Liming Gao > > ; Kinney, Michael D ; Steele, Kelly ; > > Agyeman, Prince ; Sun, Zailiang ; Qian, Yi ; Leif > > Lindholm ; Ard Biesheuvel ; Wenyi Xie ; Chiu, Chasel > > ; Ni, Ray ; Abner Chang ; Daniel Schaefer > > ; Gilbert Chen ; Thomas Abraham ; Pete Batard > > ; Marcin Wojtas > > Subject: [edk2-platforms PATCH 0/1] Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h' > > > > Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h' > > > > This patch depends on the corresponding edk2 change with subject > > "Various packages: rename SmBios.h to Smbios.h in MdePkg and update references through edk2 tree". > > > > Rebecca Cran (1): > > Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h' > > > > Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec | 10 +++++----- > > Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasic.h | 2 +- > > Platform/Intel/QuarkPlatformPkg/Platform/Dxe/MemorySubClass/MemorySubClass.h | 2 +- > > Platform/Intel/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/CommonHeader.h | 2 +- > > Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h | 4 ++-- > > Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 4 ++-- > > Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.h | 2 +- > > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/CommonHeader.h | 2 +- > > Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.h | 2 +- > > Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h | 2 +- > > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.h | 2 +- > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h | 2 +- > > Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLibrary.h | 2 +- > > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h | 2 +- > > Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLibrary.h | 2 +- > > Silicon/RISC-V/ProcessorPkg/Include/ProcessorSpecificHobData.h | 2 +- > > Silicon/RISC-V/ProcessorPkg/Include/SmbiosProcessorSpecificData.h | 2 +- > > Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > > Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c | 2 +- > > Platform/Hisilicon/D05/Library/OemMiscLibD05/BoardFeatureD05.c | 2 +- > > Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c | 2 +- > > Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c | 2 +- > > Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 4 ++-- > > Platform/Socionext/DeveloperBox/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > > Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 4 ++-- > > Silicon/Intel/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.c | 2 +- > > Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > > 27 files changed, 35 insertions(+), 35 deletions(-) > > > > -- > > 2.26.2 >