From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32])
 by mx.groups.io with SMTP id smtpd.web10.7005.1610444781308077751
 for <devel@edk2.groups.io>;
 Tue, 12 Jan 2021 01:46:21 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: huawei.com, ip: 45.249.212.32, mailfrom: cenjiahui@huawei.com)
Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60])
	by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DFQfw0ycBzj4tQ;
	Tue, 12 Jan 2021 17:45:28 +0800 (CST)
Received: from localhost (10.174.184.155) by DGGEMS409-HUB.china.huawei.com
 (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Tue, 12 Jan 2021
 17:46:07 +0800
From: "Jiahui Cen" <cenjiahui@huawei.com>
To: <devel@edk2.groups.io>
CC: Jordan Justen <jordan.l.justen@intel.com>, Laszlo Ersek
	<lersek@redhat.com>, Ard Biesheuvel <ard.biesheuvel@arm.com>, Rebecca Cran
	<rebecca@bsdio.com>, Peter Grehan <grehan@freebsd.org>, Anthony Perard
	<anthony.perard@citrix.com>, Julien Grall <julien@xen.org>, Leif Lindholm
	<leif@nuviainc.com>, Sami Mujawar <sami.mujawar@arm.com>,
	<xieyingtai@huawei.com>, <wu.wubin@huawei.com>, Jiahui Cen
	<cenjiahui@huawei.com>, Yubo Miao <miaoyubo@huawei.com>
Subject: [PATCH v4 8/9] ArmVirtPkg/FdtPciHostBridgeLib: Refactor GetRootBridges() / FreeRootBridges()
Date: Tue, 12 Jan 2021 17:45:48 +0800
Message-ID: <20210112094549.10238-9-cenjiahui@huawei.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20210112094549.10238-1-cenjiahui@huawei.com>
References: <20210112094549.10238-1-cenjiahui@huawei.com>
MIME-Version: 1.0
X-Originating-IP: [10.174.184.155]
X-CFilter-Loop: Reflected
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Rebase ArmVirtPkg/FdtPciHostBridgeLib with the new
PciHostBridgeUtilityGetRootBridges() / PciHostBridgeUtilityFreeRootBridge=
s()
functions.

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3059

Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
---
 ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 24 +++++-=
--------------
 1 file changed, 6 insertions(+), 18 deletions(-)

diff --git a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c=
 b/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
index 95166d18c82d..89582ef76eb3 100644
--- a/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
+++ b/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c
@@ -272,8 +272,6 @@ ProcessPciHost (
   return Status;
 }
=20
-STATIC PCI_ROOT_BRIDGE mRootBridge;
-
 /**
   Return all the root bridge instances in an array.
=20
@@ -361,8 +359,10 @@ PciHostBridgeGetRootBridges (
   PMemAbove4G.Base     =3D MAX_UINT64;
   PMemAbove4G.Limit    =3D 0;
=20
-  Status =3D PciHostBridgeUtilityInitRootBridge (
-    Attributes,
+  *Count =3D 0;
+
+  return PciHostBridgeUtilityGetRootBridges (
+    Count,
     Attributes,
     AllocationAttributes,
     TRUE,
@@ -373,19 +373,8 @@ PciHostBridgeGetRootBridges (
     &Mem,
     &MemAbove4G,
     &PMem,
-    &PMemAbove4G,
-    &mRootBridge
+    &PMemAbove4G
     );
-  if (EFI_ERROR (Status)) {
-    DEBUG ((EFI_D_ERROR, "%a: failed to initialize PCI host bridge: %r\n=
",
-      __FUNCTION__, Status));
-    *Count =3D 0;
-    return NULL;
-  }
-
-  *Count =3D 1;
-
-  return &mRootBridge;
 }
=20
 /**
@@ -402,8 +391,7 @@ PciHostBridgeFreeRootBridges (
   UINTN           Count
   )
 {
-  ASSERT (Count =3D=3D 1);
-  PciHostBridgeUtilityUninitRootBridge (Bridges);
+  PciHostBridgeUtilityFreeRootBridges (Bridges, Count);
 }
=20
 /**
--=20
2.29.2