From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mx.groups.io with SMTP id smtpd.web12.13774.1610476559145839602 for ; Tue, 12 Jan 2021 10:35:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=epv/DmqT; spf=pass (domain: nuviainc.com, ip: 209.85.128.54, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f54.google.com with SMTP id 190so2814090wmz.0 for ; Tue, 12 Jan 2021 10:35:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=39pAW5/oAi1Lc0Q3p6uVQi4q9TK1sdjuzTZRQom63CQ=; b=epv/DmqTXhGy9+QYf2cMbzltmjeKRjZnOiFClA2L2iLwimia5OdNm4BCPqkWGW782B 6DEWG7ZqBwdQ+YgpBODVA7t0vbucqWJQvNSoe118xyphJmsJupU3sGVnGDvY+wbC1/yV CRDUuoyOzmoNEFHnpsMXP60bgsfPzar2Yy66EgpJJMRm7I8ezt/tAHaCwL2d0oXDXnw+ a9ei31LH4f7WEw/V0NfqA/fGCACGPF9wZ96lORLx8w1mWDT+hAJz99Tf+3xJvsgQA7uj lSrG+xKUQhf/7j7vquvvOiVH/2jtSi0VJsMM5M4/djea/7buN0vIVLp0cIyGm9sVq+FR 03Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=39pAW5/oAi1Lc0Q3p6uVQi4q9TK1sdjuzTZRQom63CQ=; b=QFRRHqEYp/WZgaIghMqix36TDbac9iQtGr3kbT4VleSg7D/bj2iQdI+nW5Hm5Ww0MY hxN8tYr+22abJLpo1uGmrcNp/f/6eBKHp4LSPzQWGjZQMnyve2hq8KCsRz0PiYIM9LWi z6nIJY5qp50jos7p3Miu74z14VOZ0DVYnYLMKYdAciqbDUOP1ImOLoj35Gxc+owv4WBJ 0vR88JBhRS9zeflx2+pb5bwH2ydQS2GSgpwBGvnegnUNKm0z36MFIbBYjqPjZgVAtNc4 a60BWGgGWZDfdEASzJwWLsZYwa8jFgmXX6UIcnRnOAwjBrA6muP6NVzRcAYiI9t9DhxK 18dw== X-Gm-Message-State: AOAM530Y94l4wFSlnhc5b05DwHZ0usbdHyp/RdzKsVlP5s0rnjq365zr ciY37fm9wIGv54EcdbquE+Tg4A== X-Google-Smtp-Source: ABdhPJzDCe0g1C74wliYwPlO0TWblt014jWe9TsL18+P90ZCa9gqX78s/MC9ChvNBey7oXCHax3iOA== X-Received: by 2002:a1c:7c03:: with SMTP id x3mr564402wmc.17.1610476557537; Tue, 12 Jan 2021 10:35:57 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id a62sm5605664wmh.40.2021.01.12.10.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 10:35:56 -0800 (PST) Date: Tue, 12 Jan 2021 18:35:54 +0000 From: "Leif Lindholm" To: "Kinney, Michael D" Cc: Rebecca Cran , "devel@edk2.groups.io" , "Chaganty, Rangasai V" , Liming Gao , "Steele, Kelly" , "Agyeman, Prince" , "Sun, Zailiang" , "Qian, Yi" , Ard Biesheuvel , Wenyi Xie , "Chiu, Chasel" , "Ni, Ray" , Abner Chang , Daniel Schaefer , Gilbert Chen , Thomas Abraham , Pete Batard , Marcin Wojtas Subject: Re: [edk2-platforms PATCH 0/1] Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h' Message-ID: <20210112183554.GR1664@vanye> References: <20210111033102.21357-1-rebecca@nuviainc.com> <20210111114753.GN1664@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Mike, OK, that's fair. I was kicking back at the idea that renaming a header file was too onerous and should never be done. https://bugzilla.tianocore.org/show_bug.cgi?id=3164 raised. Rebecca, please keep the current name SmBios.h for the upstreaming of this library. Best Regards, Leif On Mon, Jan 11, 2021 at 22:28:19 +0000, Kinney, Michael D wrote: > Leif, > > I would like to see this proposed filename case change split out. > > I am ok with functional changes to follow the SMBIOS Spec. > > I am also ok if the SMBIOS Spec decided to make a non-backwards > compatible change and we have to follow the change. > > I am also ok if a mistake is made in the translation of > SMBIOS spec content to EDK II .h files. We need to fix > those. > > The filename case change does not fit into any of the > above that are required to follow specs required for > FW functionality. Changing the case or name of any > file path in the tree is not related to FW functionality > and needs to be discussed and reviewed on its own. > > Since this is about consistence with other usage of the > name "Smbios" or "SmBios" or "SMBios" or "SMBIOS" in > the source code, we need to discuss all the options to > make them consist and then understand what the impact is > to make them consistent. For example, we could discuss > changing the Protocol/Guid file name instead of the > IndustryStandard filename. Or just leaving it alone. > > I do not want to see progress slowed on functional > changes for this one. Please enter a BZ for the filename > inconsistency issue so the issue is not lost and progress > on FW functionality changes can continue. > > Thanks, > > Mike > > > > -----Original Message----- > > From: Leif Lindholm > > Sent: Monday, January 11, 2021 3:48 AM > > To: Kinney, Michael D > > Cc: Rebecca Cran ; devel@edk2.groups.io; Chaganty, Rangasai V ; > > Liming Gao ; Steele, Kelly ; Agyeman, Prince ; > > Sun, Zailiang ; Qian, Yi ; Ard Biesheuvel ; Wenyi > > Xie ; Chiu, Chasel ; Ni, Ray ; Abner Chang > > ; Daniel Schaefer ; Gilbert Chen ; Thomas Abraham > > ; Pete Batard ; Marcin Wojtas > > Subject: Re: [edk2-platforms PATCH 0/1] Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h' > > > > On Mon, Jan 11, 2021 at 04:42:49 +0000, Kinney, Michael D wrote: > > > Hi Rebecca, > > > > > > Where is the review of the change to rename SmBios.h to Smbios.h in MdePkg? > > > > > > I do not think that change is a good idea because it would impact > > > every downstream platform that produces SMBIOS records. > > > > If those platforms are tracking master, this sort of thing should be > > expected. > > > > If they are jumping between stable tags, they are likely to have more > > things than this to worry about on each rebase. > > > > If they are "randomly" cherry-picking patches, they will already be > > used to fixing up much worse things like this. > > > > Not to mention that platforms that build only on Windows and Os X are > > unlikely to even notice due to case insensitive filesystems. And in my > > experience, if they ever move to build on a case-sensitive filesystem, > > they will as a result find many other case typos to fix. > > > > As Sean said: > > "If a platform dev model can't handle this type of breaking change > > then this project is paralyzed and bigger things should be addressed." > > > > / > > Leif > > > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: Rebecca Cran > > > > Sent: Sunday, January 10, 2021 7:31 PM > > > > To: devel@edk2.groups.io > > > > Cc: Rebecca Cran ; Chaganty, Rangasai V ; Liming Gao > > > > ; Kinney, Michael D ; Steele, Kelly ; > > > > Agyeman, Prince ; Sun, Zailiang ; Qian, Yi ; Leif > > > > Lindholm ; Ard Biesheuvel ; Wenyi Xie ; Chiu, > > Chasel > > > > ; Ni, Ray ; Abner Chang ; Daniel Schaefer > > > > ; Gilbert Chen ; Thomas Abraham ; Pete Batard > > > > ; Marcin Wojtas > > > > Subject: [edk2-platforms PATCH 0/1] Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h' > > > > > > > > Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h' > > > > > > > > This patch depends on the corresponding edk2 change with subject > > > > "Various packages: rename SmBios.h to Smbios.h in MdePkg and update references through edk2 tree". > > > > > > > > Rebecca Cran (1): > > > > Update SMBIOS includes to use capitalization 'Smbios.h' vs 'SmBios.h' > > > > > > > > Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec | 10 +++++----- > > > > Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBasic.h | 2 +- > > > > Platform/Intel/QuarkPlatformPkg/Platform/Dxe/MemorySubClass/MemorySubClass.h | 2 +- > > > > Platform/Intel/QuarkPlatformPkg/Platform/Dxe/SmbiosMiscDxe/CommonHeader.h | 2 +- > > > > Platform/Intel/SimicsOpenBoardPkg/Library/BoardBdsHookLib/BoardBdsHook.h | 4 ++-- > > > > Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.h | 4 ++-- > > > > Platform/Intel/SimicsOpenBoardPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.h | 2 +- > > > > Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/CommonHeader.h | 2 +- > > > > Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.h | 2 +- > > > > Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClass.h | 2 +- > > > > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.h | 2 +- > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h | 2 +- > > > > Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLibrary.h | 2 +- > > > > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersionInfo.h | 2 +- > > > > Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyLibrary.h | 2 +- > > > > Silicon/RISC-V/ProcessorPkg/Include/ProcessorSpecificHobData.h | 2 +- > > > > Silicon/RISC-V/ProcessorPkg/Include/SmbiosProcessorSpecificData.h | 2 +- > > > > Platform/ARM/JunoPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > > > > Platform/Hisilicon/D03/Library/OemMiscLib2P/BoardFeature2PHi1610.c | 2 +- > > > > Platform/Hisilicon/D05/Library/OemMiscLibD05/BoardFeatureD05.c | 2 +- > > > > Platform/Hisilicon/D06/Library/OemMiscLibD06/BoardFeatureD06.c | 2 +- > > > > Platform/Intel/Vlv2TbltDevicePkg/PlatformSetupDxe/SetupInfoRecords.c | 2 +- > > > > Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 4 ++-- > > > > Platform/Socionext/DeveloperBox/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > > > > Silicon/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 4 ++-- > > > > Silicon/Intel/IntelSiliconPkg/Library/DxeSmbiosDataHobLib/DxeSmbiosDataHobLib.c | 2 +- > > > > Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 2 +- > > > > 27 files changed, 35 insertions(+), 35 deletions(-) > > > > > > > > -- > > > > 2.26.2 > > >