public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: devel@edk2.groups.io
Cc: leif@nuviainc.com, Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: [PATCH edk2-platforms 1/2] Platform/Overdrive: drop commented out reference to bogus PCD
Date: Thu, 14 Jan 2021 13:46:14 +0100	[thread overview]
Message-ID: <20210114124615.8132-1-ard.biesheuvel@arm.com> (raw)

Drop the commented out reference to the PCD PcdAtaPassThruPciEmulation,
which does not exist.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 3 ---
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 19102b2ef818..adc92af080f1 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -404,9 +404,6 @@ [PcdsFixedAtBuild.common]
   gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
   gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
 
-  ## Use PCI emulation for ATA PassThru
-  # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
-
   ## ACPI (no tables < 4GB)
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
 
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index d5f75cbba5e5..15c5adf8e824 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -393,9 +393,6 @@ [PcdsFixedAtBuild.common]
   gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
   gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
 
-  ## Use PCI emulation for ATA PassThru
-  # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
-
   ## ACPI (no tables < 4GB)
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
 
-- 
2.17.1


             reply	other threads:[~2021-01-14 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 12:46 Ard Biesheuvel [this message]
2021-01-14 12:46 ` [PATCH edk2-platforms 2/2] Platform/Overdrive: enable BAR resizing Ard Biesheuvel
2021-01-14 19:07   ` [edk2-devel] " Laszlo Ersek
2021-01-15  9:10 ` [edk2-devel] [PATCH edk2-platforms 1/2] Platform/Overdrive: drop commented out reference to bogus PCD Philippe Mathieu-Daudé
2021-01-15 22:09 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210114124615.8132-1-ard.biesheuvel@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox