[PATCH edk2-platforms 1/2] Platform/Overdrive: drop commented out reference to bogus PCD

[PATCH edk2-platforms 1/2] Platform/Overdrive: drop commented out reference to bogus PCD

[Ard Biesheuvel]

Drop the commented out reference to the PCD PcdAtaPassThruPciEmulation,
which does not exist.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 3 ---
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 ---
 2 files changed, 6 deletions(-)

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 19102b2ef818..adc92af080f1 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -404,9 +404,6 @@ [PcdsFixedAtBuild.common]
   gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
   gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
 
-  ## Use PCI emulation for ATA PassThru
-  # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
-
   ## ACPI (no tables < 4GB)
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
 
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index d5f75cbba5e5..15c5adf8e824 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -393,9 +393,6 @@ [PcdsFixedAtBuild.common]
   gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
   gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
 
-  ## Use PCI emulation for ATA PassThru
-  # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
-
   ## ACPI (no tables < 4GB)
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
 
-- 
2.17.1

[PATCH edk2-platforms 2/2] Platform/Overdrive: enable BAR resizing

[Ard Biesheuvel]

Add support for BAR resizing at PCI resource allocation time: this removes
the need for the OS to grow BARs of PCIe devices such as GPU controllers,
which typically use small BARs by default for compatibility with 32-bit
systems with small PCI resource windows, but perform better when the BAR
can cover all of its onboard memory.

Usually, the OS should be capable of performing the BAR resize as well,
but it is more constrained, and so doing this earlier is better on
systems such as Overdrive where the MMIO root window is huge.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
---
 Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index adc92af080f1..17600a58112d 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -404,6 +404,8 @@ [PcdsFixedAtBuild.common]
   gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
   gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
 
+  gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|TRUE
+
   ## ACPI (no tables < 4GB)
   gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
 
-- 
2.17.1

Re: [edk2-devel] [PATCH edk2-platforms 2/2] Platform/Overdrive: enable BAR resizing

[Laszlo Ersek]

On 01/14/21 13:46, Ard Biesheuvel wrote:
> Add support for BAR resizing at PCI resource allocation time: this removes
> the need for the OS to grow BARs of PCIe devices such as GPU controllers,
> which typically use small BARs by default for compatibility with 32-bit
> systems with small PCI resource windows, but perform better when the BAR
> can cover all of its onboard memory.
> 
> Usually, the OS should be capable of performing the BAR resize as well,
> but it is more constrained, and so doing this earlier is better on
> systems such as Overdrive where the MMIO root window is huge.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index adc92af080f1..17600a58112d 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -404,6 +404,8 @@ [PcdsFixedAtBuild.common]
>    gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
>    gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
>  
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdPcieResizableBarSupport|TRUE
> +
>    ## ACPI (no tables < 4GB)
>    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>  
> 

... this is exactly the kind of documentation that I wished for (in
retrospect) in the original edk2 feature addition.

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform/Overdrive: drop commented out reference to bogus PCD

[Philippe Mathieu-Daudé]

On 1/14/21 1:46 PM, Ard Biesheuvel wrote:
> Drop the commented out reference to the PCD PcdAtaPassThruPciEmulation,
> which does not exist.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
> ---
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 3 ---
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 ---
>  2 files changed, 6 deletions(-)

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Re: [PATCH edk2-platforms 1/2] Platform/Overdrive: drop commented out reference to bogus PCD

[Leif Lindholm]

On Thu, Jan 14, 2021 at 13:46:14 +0100, Ard Biesheuvel wrote:
> Drop the commented out reference to the PCD PcdAtaPassThruPciEmulation,
> which does not exist.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 3 ---
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index 19102b2ef818..adc92af080f1 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -404,9 +404,6 @@ [PcdsFixedAtBuild.common]
>    gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
>    gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
>  
> -  ## Use PCI emulation for ATA PassThru
> -  # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
> -
>    ## ACPI (no tables < 4GB)
>    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>  
> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> index d5f75cbba5e5..15c5adf8e824 100644
> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> @@ -393,9 +393,6 @@ [PcdsFixedAtBuild.common]
>    gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
>    gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
>  
> -  ## Use PCI emulation for ATA PassThru
> -  # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
> -
>    ## ACPI (no tables < 4GB)
>    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>  
> -- 
> 2.17.1
>