From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by mx.groups.io with SMTP id smtpd.web08.4272.1610642194405316106 for ; Thu, 14 Jan 2021 08:36:34 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=UVf9e9UR; spf=pass (domain: nuviainc.com, ip: 209.85.166.51, mailfrom: rebecca@nuviainc.com) Received: by mail-io1-f51.google.com with SMTP id b19so9847536ioa.9 for ; Thu, 14 Jan 2021 08:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=utxq4XGcnz8V9tFAqdOf3ML0k0vPWSnGLvLeQWAqYEA=; b=UVf9e9URFQzs9ihCfn2xaAXjoOgHvowzHcZPr/AznCEgwmmchAFs2oc+Ca7VFoSf3k 9cMmWAQJdzYvCrV9woQGaY0/O8frPdUMEYRa8qzttJ2XTVq3kRSpbypswUOFBx671IR5 faf5JToI9nnbaq88dlwbJXeLZ8Qhz6Bd2XrJJP4cYzf4GDcrxT4BECUOe2MFDZ4gYRaT mzlTzNAK0HXt1O6RY532yPSsvxdwqQDqFv4TrY5o4ziW+Gvpomyt/KI9YniPSMsrK+ra sYWV0KRDihQI2AP9VUUAOWaDoVIdPDRFM2K659wUUzijpPZVleQVXmHhL4EFZQMHsvLB vWIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=utxq4XGcnz8V9tFAqdOf3ML0k0vPWSnGLvLeQWAqYEA=; b=MJLvfelwePOCKsKmlEmCGVE/bRkRWMUVtUOa8/k2KXNdHsTP73CUVuUYKf1hSJHfNi Oi1ItIm+1WLp9rcG+XYH6oV21av4uReQqch3/tMMm8veYG8NpH2DLoSleOrPzoitnmsX UP11kZQuKV7oIu9Sg4RzIXjQhOzkc4FsbbXPrxZgCiDb6zNcjoacNKV/rER7t8hiEQzQ q7NHTQxbBnXRxTKtDNXdl7oDVyQSboREuJEOmXzkpAouOAs/Ht5Qb88b8BKeMGotm0S+ cjMngf9rPW5k8DJ9aHHxq7M+rmwvLp7tJ1/RGXP4Vs9UCn3IzyIIFOBMJFzn/1cKPNgx olsg== X-Gm-Message-State: AOAM533rzzLjBVf4YJ9O5COHwmp2YJUN8EXDg3gRijp0TVx/Nu9P7sgE /NLwk2l37BUD1MBNI0hgo1SDPZbwPhoy+wBzVVyEnJ8kZeUtnhtU4FHLO/8NeG6dbSmfxloRHIW yyJju/YojNr6N5yJkeF6SuO2qND5StIGm1HUkjdO2h8hpiBUlEb+1JMDnWKxyTB3MkUnET73n X-Google-Smtp-Source: ABdhPJzlRfBtj+mPYYs8lC6wwHKOwHEH4gIlLyZdC27WQuwCvtc1mswCbHb1hYHGlYu857BxtAgGcg== X-Received: by 2002:a05:6e02:c65:: with SMTP id f5mr2955311ilj.241.1610642193433; Thu, 14 Jan 2021 08:36:33 -0800 (PST) Return-Path: Received: from cube.nuviainc.com (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id y5sm3711920ilj.35.2021.01.14.08.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jan 2021 08:36:32 -0800 (PST) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Leif Lindholm , Ard Biesheuvel , nd@arm.com, Sami Mujawar , Liming Gao , Michael D Kinney , Zhiguang Liu Subject: [PATCH v6 00/22] ArmPkg,MdePkg: Add Universal/Smbios, and related changes Date: Thu, 14 Jan 2021 09:36:06 -0700 Message-Id: <20210114163628.31952-1-rebecca@nuviainc.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Much of the data for the SMBIOS tables is generic, and need not be duplicated for each platform. This patch series introduces ArmPkg/Universal/Smbios, which is largely copied from edk2-platforms/Silicon/HiSilicon/Drivers/Smbios and generates SMBIOS tables 0,1,2,3,4,7,13,32 and uses a combination of PCDs and calls into a new OemMiscLib to get information which varies between platforms. I plan to submit a patch against SbsaQemu to update it to use this new functionality. Changes from v5 to v6: o Renamed SmbiosLogData to SmbiosMiscAddRecord. o Renamed EFI_ structs etc. SMBIOS_MISC_ o Fixed encoding of CCSIDR2 register. o Fixed line wrapping and indentation. o Added more calls into OemUpdateSmbiosInfo to update strings. o Fixed various Type00 fields (e.g. UsbLegacyIsSupported, BiosBootSpecIsSupported). o Added dynamic PCDs for SystemBiosRelease EmbeddedControllerFirmwareRelease. o Various other changes/fixes. More changes are needed to support reporting boot status etc., but with the series getting rather large I think it might be good to get this committed and make a follow-up series with the additional changes. Testing: o Ran Ecc tool and fixed various issues. Several remain, but I think they're bogus. o Ran FWTS. I fixed a bug which was still reporting bit 9 of the Processor Characteristics field as reserved. Once fixed, zero issues were reported. o Ran smbiosview in the UEFI Shell, and dmidecode in Linux. Bob Feng (1): BaseTools: Fix the build report crash issue Rebecca Cran (21): ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h MdePkg: Update IndustryStandard/SmBios.h with processor status data ArmPkg: Add register encoding definition for MMFR2 ArmPkg: Add helper to read the Memory Model Features Register 2 ArmPkg: Add helper function to read the Memory Model Feature Register 4 ArmPkg: Fix the return type of the ReadCCSIDR function ArmPkg: Update ArmLibPrivate.h with cache register definitions ArmPkg: Add definition of the maximum cache level in ARMv8-A ArmPkg: Add helper to read CCIDX status ArmPkg: Add helper to read the CCSIDR2 register ArmPkg: Add Library/OemMiscLib.h ArmPkg: Add Universal/Smbios/OemMiscLibNull ArmPkg: Add Universal/Smbios/ProcessorSubClassDxe ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type00 ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type01 ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type02 ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type03 ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type13 ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type32 ArmPkg: Add SMBIOS PCDs to ArmPkg.dec ArmPkg: Add Universal/Smbios/SmbiosMiscDxe ArmPkg/ArmPkg.dec | 17 + ArmPkg/ArmPkg.dsc | 5 + ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 31 + ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf | 58 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 89 ++ ArmPkg/Include/Chipset/AArch64.h | 4 + ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 16 + ArmPkg/Include/Library/ArmLib.h | 15 + ArmPkg/Include/Library/OemMiscLib.h | 166 ++++ ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 11 + ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 8 +- ArmPkg/Library/ArmLib/ArmLibPrivate.h | 117 ++- ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h | 134 +++ MdePkg/Include/IndustryStandard/SmBios.h | 13 + ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 19 +- ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c | 19 +- ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 143 ++++ ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 863 ++++++++++++++++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c | 62 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c | 227 +++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c | 93 +++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c | 297 +++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c | 36 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c | 196 +++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c | 46 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 230 ++++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 52 ++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c | 224 +++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c | 33 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c | 166 ++++ ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c | 32 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c | 73 ++ ArmPkg/Library/ArmLib/AArch64/AArch64Support.S | 3 + ArmPkg/Library/ArmLib/AArch64/ArmLibSupportV8.S | 2 +- ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 16 +- ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.asm | 16 +- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni | 24 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxeStrings.uni | 22 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni | 18 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni | 20 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni | 20 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni | 18 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni | 43 + BaseTools/Source/Python/build/BuildReport.py | 16 +- 44 files changed, 3698 insertions(+), 15 deletions(-) create mode 100644 ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassDxe.inf create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf create mode 100644 ArmPkg/Include/Library/OemMiscLib.h create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMisc.h create mode 100644 ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDataTable.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscEntryPoint.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesFunction.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationFunction.c create mode 100644 ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClassStrings.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxeStrings.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendor.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturer.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturer.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturer.uni create mode 100644 ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguages.uni -- 2.26.2