From: "Sughosh Ganu" <sughosh.ganu@linaro.org>
To: devel@edk2.groups.io
Cc: Sami Mujawar <sami.mujawar@arm.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Leif Lindholm <leif@nuviainc.com>,
Sahil Malhotra <sahil.malhotra@linaro.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Sughosh Ganu <sughosh.ganu@linaro.org>
Subject: [PATCH v3 05/13] StandaloneMmPkg: Add macros for SPM version
Date: Fri, 15 Jan 2021 11:43:56 +0530 [thread overview]
Message-ID: <20210115061404.13552-6-sughosh.ganu@linaro.org> (raw)
In-Reply-To: <20210115061404.13552-1-sughosh.ganu@linaro.org>
Declare module wide variables for SPM major and minor versions to be
used in checking the SPM version compatibility. Declare the the values
of SPM major and minor versions as macros.
Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
---
Changes since V2:
* Added a STATIC storage class specifier for mSpmMajorVer and
mSpmMinorVer variables
ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 3 +++
StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c | 10 +++++-----
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
index ee29c2fecc..71a5398558 100644
--- a/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
+++ b/ArmPkg/Include/IndustryStandard/ArmMmSvc.h
@@ -41,4 +41,7 @@
#define ARM_SVC_SPM_RET_DENIED -3
#define ARM_SVC_SPM_RET_NO_MEMORY -5
+#define SPM_MAJOR_VERSION 0
+#define SPM_MINOR_VERSION 1
+
#endif
diff --git a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c
index 3d78e8e9ae..2643473e88 100644
--- a/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c
+++ b/StandaloneMmPkg/Library/StandaloneMmCoreEntryPoint/AArch64/StandaloneMmCoreEntryPoint.c
@@ -32,8 +32,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#define SPM_MINOR_VER_MASK 0x0000FFFF
#define SPM_MAJOR_VER_SHIFT 16
-#define SPM_MAJOR_VER 0
-#define SPM_MINOR_VER 1
+STATIC CONST UINT32 mSpmMajorVer = SPM_MAJOR_VERSION;
+STATIC CONST UINT32 mSpmMinorVer = SPM_MINOR_VERSION;
#define BOOT_PAYLOAD_VERSION 1
@@ -196,8 +196,8 @@ GetSpmVersion (VOID)
// revision A must work in a compatible way with revision B.
// However, it is possible for revision B to have a higher
// function count than revision A.
- if ((SpmMajorVersion == SPM_MAJOR_VER) &&
- (SpmMinorVersion >= SPM_MINOR_VER))
+ if ((SpmMajorVersion == mSpmMajorVer) &&
+ (SpmMinorVersion >= mSpmMinorVer))
{
DEBUG ((DEBUG_INFO, "SPM Version: Major=0x%x, Minor=0x%x\n",
SpmMajorVersion, SpmMinorVersion));
@@ -206,7 +206,7 @@ GetSpmVersion (VOID)
else
{
DEBUG ((DEBUG_INFO, "Incompatible SPM Versions.\n Current Version: Major=0x%x, Minor=0x%x.\n Expected: Major=0x%x, Minor>=0x%x.\n",
- SpmMajorVersion, SpmMinorVersion, SPM_MAJOR_VER, SPM_MINOR_VER));
+ SpmMajorVersion, SpmMinorVersion, mSpmMajorVer, mSpmMinorVer));
Status = EFI_UNSUPPORTED;
}
--
2.17.1
next prev parent reply other threads:[~2021-01-15 6:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 6:13 [PATCH v3 00/13] Add support for using FF-A calls Sughosh Ganu
2021-01-15 6:13 ` [PATCH v3 01/13] ArmPkg/IndustryStandard: Add barebones FF-A header Sughosh Ganu
2021-02-13 10:28 ` [edk2-devel] " Ard Biesheuvel
2021-01-15 6:13 ` [PATCH v3 02/13] ArmPkg/ArmSvcLib: Return x4-x7 in output parameters Sughosh Ganu
2021-02-13 10:28 ` [edk2-devel] " Ard Biesheuvel
2021-01-15 6:13 ` [PATCH v3 03/13] StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point Sughosh Ganu
2021-01-15 6:13 ` [PATCH v3 04/13] ArmPkg: Introduce support for PcdFfaEnable Sughosh Ganu
2021-02-13 10:29 ` [edk2-devel] " Ard Biesheuvel
2021-01-15 6:13 ` Sughosh Ganu [this message]
2021-01-20 18:34 ` [edk2-devel] [PATCH v3 05/13] StandaloneMmPkg: Add macros for SPM version Sami Mujawar
2021-01-15 6:13 ` [PATCH v3 06/13] StandaloneMmPkg: Add the SPM version for FF-A Sughosh Ganu
2021-01-20 18:38 ` [edk2-devel] " Sami Mujawar
2021-01-15 6:13 ` [PATCH v3 07/13] StandaloneMmPkg: Add option to use FF-A calls for getting SPM version Sughosh Ganu
2021-01-15 6:13 ` [PATCH v3 08/13] StandaloneMmPkg: Add option to use FF-A calls for communication with SPM Sughosh Ganu
2021-01-20 18:44 ` [edk2-devel] " Sami Mujawar
2021-01-15 6:14 ` [PATCH v3 09/13] StandaloneMmPkg: Use FF-A header file in Standalone MM Arm MMU library Sughosh Ganu
2021-01-15 6:14 ` [PATCH v3 10/13] StandaloneMmMmuLib: Allow FF-A calls to get memory region's attributes Sughosh Ganu
2021-01-20 18:49 ` [edk2-devel] " Sami Mujawar
2021-01-15 6:14 ` [PATCH v3 11/13] StandaloneMmMmuLib: Allow FF-A calls to set " Sughosh Ganu
2021-01-20 18:52 ` [edk2-devel] " Sami Mujawar
2021-01-15 6:14 ` [PATCH v3 12/13] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd Sughosh Ganu
2021-01-15 6:14 ` [PATCH v3 13/13] StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm Sughosh Ganu
2021-02-18 3:34 ` 回复: [edk2-devel] [PATCH v3 00/13] Add support for using FF-A calls gaoliming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115061404.13552-6-sughosh.ganu@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox