From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.57]) by mx.groups.io with SMTP id smtpd.web12.2336.1610721833955653504 for ; Fri, 15 Jan 2021 06:43:55 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=kBLNNbT4; spf=pass (domain: arm.com, ip: 40.107.6.57, mailfrom: joey.gouly@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mGO/IDNv46gLcCeZcyElmdPYfdnGm2W77jHaGVj3Wsg=; b=kBLNNbT45BxTkCYgGGCRq2bHWQ331aUjU+woXIWg/B7qdn3w0s0BuaMAar9hZM5E3j/s2jVevwTTedms8TC8z5C8hVrQSzPIHK08vPGDp5LdDNChO4sisJ7eZZp8wpV9vsMxADMsnDnubGnCHg0mnmh9E6VIVBSobWKaqj4VnRg= Received: from DB6PR0201CA0042.eurprd02.prod.outlook.com (2603:10a6:4:3f::52) by DB6PR0802MB2598.eurprd08.prod.outlook.com (2603:10a6:4:97::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Fri, 15 Jan 2021 14:43:51 +0000 Received: from DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::b5) by DB6PR0201CA0042.outlook.office365.com (2603:10a6:4:3f::52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10 via Frontend Transport; Fri, 15 Jan 2021 14:43:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT015.mail.protection.outlook.com (10.152.20.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.12 via Frontend Transport; Fri, 15 Jan 2021 14:43:51 +0000 Received: ("Tessian outbound af289585f0f4:v71"); Fri, 15 Jan 2021 14:43:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a8357fa543a0053f X-CR-MTA-TID: 64aa7808 Received: from 28b124797b0c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 00B5954A-B26C-46F4-9D6F-DC1FDEBFE882.1; Fri, 15 Jan 2021 14:43:45 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 28b124797b0c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 Jan 2021 14:43:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B4DQNGkuyGXWQS6VySX/f7Wv2MQAkl2i4Mz0+bJoeJX9wA4fQwFOYSWxNvAv2DMH2Xv8AihH6yzZuD1D8BZsWuovEYYJLJniEEWNXx8Sf0AmUQbArHGcYiO7CKhXHmoeaQUD7yLq/FZbJT5fj8BeJrlCT54WeRgh7ReY9qqFZ8qP4+99O90mt/VbSk7hZgFNSmsCZGWrmxRNHnTK7HoLCrP7Io/fwr6UMi7Fcnz/Gqy6cpQEn50e+4P/PGKMoRv2YeZ0c0ET/wwsWoQ0DJSMBjm7JDEwsPoxghNa9caAZrn3rK94BjVvlWRyXfS71E8pN24LM3mBRCT736/UBdP49A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mGO/IDNv46gLcCeZcyElmdPYfdnGm2W77jHaGVj3Wsg=; b=ghIS5W07XVSjpl8kjCq1sDNWe1upBQCigMRbzwg5qLaEC7ym851p9uWlBeoHHuXm7+O+dq2p0erxRxgsPNzMGWizLU/HC7siMO02g4x6xfz5RJ01HYXAmSoI8esbGZ298vf4oNJXVJRZFwwyKVFl7rnyI6vqFWzdTwrgPJ7BkFt8mWc+iiwOKZIDsu1K7MnKYjE/jVBeSwBo1kRgaa7DwORt2VUVFFLnXDWrAAG5WmCGfLg+r1/ryYMWnx2P365SfFsNNrwlSC5e5iPc1reEplZqRAUXAqTKX+DNs/iQb3rESMWwehzwPGnBmK08k4kPAsP8+nMBlrqT3wKdGf8y6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mGO/IDNv46gLcCeZcyElmdPYfdnGm2W77jHaGVj3Wsg=; b=kBLNNbT45BxTkCYgGGCRq2bHWQ331aUjU+woXIWg/B7qdn3w0s0BuaMAar9hZM5E3j/s2jVevwTTedms8TC8z5C8hVrQSzPIHK08vPGDp5LdDNChO4sisJ7eZZp8wpV9vsMxADMsnDnubGnCHg0mnmh9E6VIVBSobWKaqj4VnRg= Received: from AM6P193CA0069.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::46) by PA4PR08MB6176.eurprd08.prod.outlook.com (2603:10a6:102:ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10; Fri, 15 Jan 2021 14:43:44 +0000 Received: from AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8e:cafe::e7) by AM6P193CA0069.outlook.office365.com (2603:10a6:209:8e::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.10 via Frontend Transport; Fri, 15 Jan 2021 14:43:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT049.mail.protection.outlook.com (10.152.17.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3763.12 via Frontend Transport; Fri, 15 Jan 2021 14:43:43 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2044.4; Fri, 15 Jan 2021 14:43:40 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Fri, 15 Jan 2021 14:43:40 +0000 Received: from e124191.cambridge.arm.com (10.11.7.12) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Fri, 15 Jan 2021 14:43:39 +0000 From: "Joey Gouly" To: CC: , , , , Subject: [PATCH v2 1/1] ShellPkg: Validate that the Boot CPU is present in MADT Date: Fri, 15 Jan 2021 14:43:40 +0000 Message-ID: <20210115144340.6511-1-joey.gouly@arm.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ab7a92d4-c081-4feb-14f9-08d8b963f9a3 X-MS-TrafficTypeDiagnostic: PA4PR08MB6176:|DB6PR0802MB2598: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: q9jrQi/7Qvyjs6HH/KKrjkzjGbX0ri2y7mbJ/wBOj1gk+OSQrQKry4big9N9yb6SW/l8KTA5XDsUmjXDXjhkeNDfAh8TuunoUtMf0pSmwrRJOkpoZnMRCDwx7asPkzwF4MFWbeg4VY/yTp0HdwUJTOQck+EdeAcHroS8G4tWlr23bECah34bvZtYliGHyQaLd6+zpTLju6Kg9dCWuZ/WoQjF8mSua7n78PENcvbRkTa7fiAiuZ9cAKgC+smaX3Zn2pycdS8hf+27WorIGhPj1qintRHSFYN3z7thrpwu4Qrt2GDfCJJa4HkmHStSyCtfumRNImqF6zjyTCwYetT9NGP7hbf3pPt4P3pt8QCBaXpLGWETn+mtfzte2YgW4wwpSOXGzMJhBP5VXRisYl2VRquE4QRkWiaNm4LIGenVqgg6ob/XceqQ7RatPM74lDWVXXqlfNDgWPtKxmqHIGQrn8Wkl2v/cFX0NAcU10Vfbr5sM6yb0MpqgNFO11kcbdJkzi2SHb3nv8kfbMSzyJzy6HJyFnzaZsq+BSi3w1ojPr34Sg2oLJcRuFahEGPPHfkI X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(346002)(39830400003)(396003)(136003)(376002)(46966006)(45080400002)(86362001)(966005)(478600001)(4326008)(8936002)(15650500001)(2906002)(34020700004)(82310400003)(6916009)(7696005)(5660300002)(316002)(1076003)(426003)(70586007)(336012)(2616005)(81166007)(83380400001)(186003)(36756003)(8676002)(44832011)(70206006)(26005)(47076005)(6666004)(54906003)(356005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6176 Return-Path: Joey.Gouly@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 0af66d2d-4504-4f9a-178f-08d8b963f52b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QknIl75aWBitMSpCKNQ9a1boEzfN0n74/sQlb9kH2b40P8Hkbzr2XOxTVCZgzj08KuvuDB3Zizh+knbE758X2Ql0PyMd5VLhn4K38m/ehqK9VMo3Mg2SE8z2s6g4N6hL46hqQOuG3D3ELNBSJr7q7AAUz8TbfKLd5hgEJmRm7ForWIfzcovig7e1LIZ8EMbQXHJ2N4jSE3hvwESZcS75OlnXL7Mixj2HvmqRUNDNbvcipWWlUlSFsc428GKqpD99sfwjzGklKxQpN55k3orrmYSa4dCk5gMzRXlpNh+APmaR2za3E4b24YfdAzn4T2pIREokeBE/DpgH9nucj3BdqWENAIHGtG5wds5znJPKVLk6NZgJL4Rq5i3q/3sulSbgEdBhcPeFwXoryqVy7T0qUuuICDWeuLkfJ7oVIrb7jIU7dYtg3tH10yGQy8zqxc77bo/ZFrFU9SG/Hr8johLG741F8siTPfjkHY/bZHQ46kB5fKwC8XTVqvZnerSO7lztzZFs0lhPQMditYFkjquQgh8B8yppMofiHBoGFQwPV7oReqg68Itl5ZUCjN0QB+CP X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(136003)(396003)(39850400004)(376002)(346002)(46966006)(70206006)(70586007)(8676002)(8936002)(5660300002)(54906003)(336012)(316002)(45080400002)(1076003)(7696005)(6916009)(86362001)(15650500001)(26005)(2616005)(6666004)(47076005)(34020700004)(186003)(82310400003)(4326008)(82740400003)(44832011)(81166007)(426003)(966005)(2906002)(83380400001)(36756003)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2021 14:43:51.3970 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab7a92d4-c081-4feb-14f9-08d8b963f9a3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2598 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable The ACPI 6.3 Specification, January 2019, section 5.2.12.14 states that the firmware must convey each processor=E2=80=99s GIC information to the OS= using the GICC structure. If a GICC structure for the boot CPU is missing some standards-based operating system may crash with an error code. It may be difficult to diagnose the reason for the crash as the error code may be too generic and mean firmware error. Therefore add validation to the MADT table parser to check that a GICC is present for the boot CPU. Signed-off-by: Joey Gouly --- Changes since v1: - Added 'm' prefix for global variables - Reordered ci yaml file The changes can be seen at https://github.com/jgouly/edk2/tree/1474_validat= e_boot_cpu_mpidr_v2 ShellPkg/ShellPkg.dsc = | 3 ++ ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.i= nf | 5 ++ ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c = | 54 +++++++++++++++++++- ShellPkg/ShellPkg.ci.yaml = | 2 + 4 files changed, 62 insertions(+), 2 deletions(-) diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index c42bc9464a0f7be111ee3086a664506c8288928c..661cc8b02b0971280c3649e0f29= e109305bcc776 100644 --- a/ShellPkg/ShellPkg.dsc +++ b/ShellPkg/ShellPkg.dsc @@ -71,6 +71,9 @@ [LibraryClasses.ARM,LibraryClasses.AARCH64] # Add support for GCC stack protector NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf =20 + # Add support for reading MPIDR + ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf + [PcdsFixedAtBuild] gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|16000 diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiView= CommandLib.inf b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpi= ViewCommandLib.inf index 947fb1f375667e12f8603e4264fef5e69cb98919..00e770d677ec1f2a23c1650fe2f= 4a94f2f86649f 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommand= Lib.inf +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommand= Lib.inf @@ -60,6 +60,9 @@ [Packages] MdePkg/MdePkg.dec ShellPkg/ShellPkg.dec =20 +[Packages.ARM, Packages.AARCH64] + ArmPkg/ArmPkg.dec + [LibraryClasses] BaseLib BaseMemoryLib @@ -75,6 +78,8 @@ [LibraryClasses] UefiLib UefiRuntimeServicesTableLib =20 +[LibraryClasses.ARM, LibraryClasses.AARCH64] + ArmLib =20 [FixedPcd] gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask ## CONSUMES diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/Madt= Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtPa= rser.c index 15aa2392b60cee9e3843c7c560b0ab84e0be4174..9935537aaee28381fecec08d005= 7db83aaca1e1d 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.= c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.= c @@ -1,7 +1,7 @@ /** @file MADT table parser =20 - Copyright (c) 2016 - 2020, ARM Limited. All rights reserved. + Copyright (c) 2016 - 2020, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Reference(s): @@ -13,6 +13,9 @@ =20 #include #include +#if defined(MDE_CPU_ARM) || defined(MDE_CPU_AARCH64) +#include +#endif #include "AcpiParser.h" #include "AcpiTableParser.h" #include "AcpiViewConfig.h" @@ -23,6 +26,11 @@ STATIC CONST UINT8* MadtInterruptControllerType; STATIC CONST UINT8* MadtInterruptControllerLength; STATIC ACPI_DESCRIPTION_HEADER_INFO AcpiHdrInfo; =20 +#if defined(MDE_CPU_ARM) || defined(MDE_CPU_AARCH64) +STATIC UINT64 mBootMpidr; +STATIC BOOLEAN mHasBootMpidrGicc =3D FALSE; +#endif + /** This function validates the System Vector Base in the GICD. =20 @@ -95,6 +103,33 @@ ValidateSpeOverflowInterrupt ( } } =20 +/** + This function validates that the GICC structure contains an entry for + the Boot CPU. + + @param [in] Ptr Pointer to the start of the field data. + @param [in] Context Pointer to context specific information e.g. this + could be a pointer to the ACPI table header. +**/ +STATIC +VOID +EFIAPI +ValidateBootMpidr ( + IN UINT8* Ptr, + IN VOID* Context + ) +{ +#if defined(MDE_CPU_ARM) || defined(MDE_CPU_AARCH64) + UINT64 CurrentMpidr; + + CurrentMpidr =3D *(UINT64*)Ptr; + + if (CurrentMpidr =3D=3D mBootMpidr) { + mHasBootMpidrGicc =3D TRUE; + } +#endif +} + /** An ACPI_PARSER array describing the GICC Interrupt Controller Structure. **/ @@ -115,7 +150,7 @@ STATIC CONST ACPI_PARSER GicCParser[] =3D { {L"GICH", 8, 48, L"0x%lx", NULL, NULL, NULL, NULL}, {L"VGIC Maintenance interrupt", 4, 56, L"0x%x", NULL, NULL, NULL, NULL}, {L"GICR Base Address", 8, 60, L"0x%lx", NULL, NULL, NULL, NULL}, - {L"MPIDR", 8, 68, L"0x%lx", NULL, NULL, NULL, NULL}, + {L"MPIDR", 8, 68, L"0x%lx", NULL, NULL, ValidateBootMpidr, NULL}, {L"Processor Power Efficiency Class", 1, 76, L"0x%x", NULL, NULL, NULL, NULL}, {L"Reserved", 1, 77, L"0x%x", NULL, NULL, NULL, NULL}, @@ -234,6 +269,11 @@ ParseAcpiMadt ( UINT8* InterruptContollerPtr; UINT32 GICDCount; =20 +#if defined(MDE_CPU_ARM) || defined(MDE_CPU_AARCH64) + mBootMpidr =3D ArmReadMpidr () & + (ARM_CORE_AFF0 | ARM_CORE_AFF1 | ARM_CORE_AFF2 | ARM_CORE_AF= F3); +#endif + GICDCount =3D 0; =20 if (!Trace) { @@ -371,4 +411,14 @@ ParseAcpiMadt ( InterruptContollerPtr +=3D *MadtInterruptControllerLength; Offset +=3D *MadtInterruptControllerLength; } // while + +#if defined(MDE_CPU_ARM) || defined(MDE_CPU_AARCH64) + if (!mHasBootMpidrGicc) { + IncrementErrorCount (); + Print ( + L"ERROR: No GICC present for Boot CPU (MPIDR: 0x%lx)", + mBootMpidr + ); + } +#endif } diff --git a/ShellPkg/ShellPkg.ci.yaml b/ShellPkg/ShellPkg.ci.yaml index 30894d44bc3ae9a2a9796146c5bcdc62d4ce9801..637c33adbcb2a84fb5bbfe09eaf= ffda61e78cc8d 100644 --- a/ShellPkg/ShellPkg.ci.yaml +++ b/ShellPkg/ShellPkg.ci.yaml @@ -3,6 +3,7 @@ # # Copyright (c) Microsoft Corporation # Copyright (c) 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2020, Arm Limited. All rights reserved. # SPDX-License-Identifier: BSD-2-Clause-Patent ## { @@ -28,6 +29,7 @@ }, "DependencyCheck": { "AcceptableDependencies": [ + "ArmPkg/ArmPkg.dec", "MdePkg/MdePkg.dec", "MdeModulePkg/MdeModulePkg.dec", "ShellPkg/ShellPkg.dec", --=20 Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")