public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: devel@edk2.groups.io, lersek@redhat.com
Cc: "Agyeman Prince" <prince.agyeman@intel.com>,
	"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
	"Chasel Chiu" <chasel.chiu@intel.com>,
	"Deepika Kethi Reddy" <deepika.kethi.reddy@intel.com>,
	"Jeremy Soller" <jeremy@system76.com>,
	"Kathappan Esakkithevar" <kathappan.esakkithevar@intel.com>,
	"Kelly Steele" <kelly.steele@intel.com>,
	"Marcin Wojtas" <mw@semihalf.com>,
	"Meenakshi Aggarwal" <meenakshi.aggarwal@nxp.com>,
	"Michael D Kinney" <michael.d.kinney@intel.com>,
	"Nate DeSimone" <nathaniel.l.desimone@intel.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Rangasai V Chaganty" <rangasai.v.chaganty@intel.com>,
	"Thomas Abraham" <thomas.abraham@arm.com>,
	"Wenyi Xie" <xiewenyi2@huawei.com>, "Yi Qian" <yi.qian@intel.com>,
	"Zailiang Sun" <zailiang.sun@intel.com>,
	"Ard Biesheuvel (ARM address)" <ard.biesheuvel@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution
Date: Fri, 15 Jan 2021 22:04:48 +0000	[thread overview]
Message-ID: <20210115220448.GV1664@vanye> (raw)
In-Reply-To: <d8a01a74-bd54-1e5e-a601-eacb035396c1@redhat.com>

Hi Laszlo,

On Fri, Jan 15, 2021 at 09:50:57 +0100, Laszlo Ersek wrote:
> Hi All,
> 
> sorry about the message; it's been only two days indeed.
> 
> This patch series is trivial, it adds one lib class resolution to each
> of 22 platforms in edk2-platforms.
> 
> I build-tested the platforms modified by this change, so I'm planning to
> push the series to edk2-platforms one week after posting it -- even if I
> get no feedback. Thus, the reason I'm sending this email isn't really to
> ping or urge reviewers, it's more like announcing my plan.
> 
> Thanks,
> Laszlo

Apologies, I woke up Wednesday to the news we had been acquired by
Qualcomm, and the week got a bit hazy at that point :)

Many thanks for fixing up BeagleBoard as well.

For the relevant patches:
Acked-by: Leif Lindholm <leif@nuviainc.com>

> On 01/13/21 09:28, Laszlo Ersek wrote:
> > The edk2 patch
> > 
> >   ShellPkg/ShellCommandLib: add ShellSortFileList
> > 
> > for <https://bugzilla.tianocore.org/show_bug.cgi?id=3151> will make the
> > 
> >   ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf
> > 
> > instance dependent on the OrderedCollectionLib class. Because the shell
> > binaries in several silicon and platform DSCs in edk2-platforms consume
> > the above UefiShellCommandLib instance, resolve the OrderedCollectionLib
> > class in those DSCs.
> > 
> > Cc: Agyeman Prince <prince.agyeman@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Deepika Kethi Reddy <deepika.kethi.reddy@intel.com>
> > Cc: Jeremy Soller <jeremy@system76.com>
> > Cc: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
> > Cc: Kelly Steele <kelly.steele@intel.com>
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Marcin Wojtas <mw@semihalf.com>
> > Cc: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> > Cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > Cc: Thomas Abraham <thomas.abraham@arm.com>
> > Cc: Wenyi Xie <xiewenyi2@huawei.com>
> > Cc: Yi Qian <yi.qian@intel.com>
> > Cc: Zailiang Sun <zailiang.sun@intel.com>
> > 
> > Thanks
> > Laszlo
> > 
> > Laszlo Ersek (3):
> >   Platform/BeagleBoard: add missing TimeBaseLib resolution
> >   ARM Silicon and Platforms: add OrderedCollectionLib class resolution
> >   Intel Platforms: add OrderedCollectionLib class resolution
> > 
> >  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc                          | 1 +
> >  Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc                            | 1 +
> >  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc                  | 2 ++
> >  Platform/Hisilicon/D03/D03.dsc                                          | 1 +
> >  Platform/Hisilicon/HiKey/HiKey.dsc                                      | 1 +
> >  Platform/Hisilicon/HiKey960/HiKey960.dsc                                | 1 +
> >  Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc     | 1 +
> >  Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc         | 1 +
> >  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc       | 1 +
> >  Platform/Intel/QuarkPlatformPkg/Quark.dsc                               | 1 +
> >  Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc                            | 1 +
> >  Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc        | 1 +
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc                    | 1 +
> >  Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc                     | 1 +
> >  Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc        | 1 +
> >  Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc | 1 +
> >  Platform/LeMaker/CelloBoard/CelloBoard.dsc                              | 1 +
> >  Platform/Socionext/DeveloperBox/DeveloperBox.dsc                        | 1 +
> >  Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc            | 1 +
> >  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc             | 1 +
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                           | 1 +
> >  Silicon/NXP/NxpQoriqLs.dsc.inc                                          | 1 +
> >  22 files changed, 23 insertions(+)
> > 
> > 
> > base-commit: 47b4a1db02873ffe864486dfcc8a87c409bd3d4d
> > 
> 

  parent reply	other threads:[~2021-01-15 22:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13  8:28 [edk2-platforms PATCH 0/3] add OrderedCollectionLib class resolution Laszlo Ersek
2021-01-13  8:28 ` [edk2-platforms PATCH 1/3] Platform/BeagleBoard: add missing TimeBaseLib resolution Laszlo Ersek
2021-01-18  8:16   ` [edk2-devel] " Laszlo Ersek
2021-01-13  8:28 ` [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution Laszlo Ersek
2021-01-15  9:27   ` Marcin Wojtas
2021-01-18  8:19   ` [edk2-devel] " Laszlo Ersek
2021-01-13  8:28 ` [edk2-platforms PATCH 3/3] Intel " Laszlo Ersek
2021-01-15 23:34   ` [edk2-devel] " Nate DeSimone
2021-01-18  1:38   ` 回复: " gaoliming
2021-01-18  7:56     ` Laszlo Ersek
2021-01-18  8:16   ` Laszlo Ersek
2021-01-18  8:18     ` Laszlo Ersek
2021-01-15  8:50 ` [edk2-devel] [edk2-platforms PATCH 0/3] " Laszlo Ersek
2021-01-15  9:22   ` Ard Biesheuvel
2021-01-15  9:35     ` Laszlo Ersek
2021-01-15 22:04   ` Leif Lindholm [this message]
2021-01-18  7:41     ` Laszlo Ersek
2021-01-15  9:27 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210115220448.GV1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox