From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54])
 by mx.groups.io with SMTP id smtpd.web09.700.1610748558150349677
 for <devel@edk2.groups.io>;
 Fri, 15 Jan 2021 14:09:18 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=BHl4a+MZ;
 spf=pass (domain: nuviainc.com, ip: 209.85.128.54, mailfrom: leif@nuviainc.com)
Received: by mail-wm1-f54.google.com with SMTP id c124so8670345wma.5
        for <devel@edk2.groups.io>; Fri, 15 Jan 2021 14:09:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=k7KlclPfxBaZ4PuhxYNdNLWaT1zspuEShyvgb03DTO8=;
        b=BHl4a+MZO3Ihaf845YoSIbRComG+1pAkBbt7e6h3lvBEGCIaeDHkBoCp0TbKe426Ov
         ac/gVekYsry0XmxZ1nJlwspzL/KEFzzwCvU/G/hGo/hR3S7NybzkFlC9SIPSziyh9KGp
         OIrNalI6Sv9Z7tLCArA0T7SAbBdOZzZT+9uok25sXfbfY6/n1mqzEXDqQOY1YOB193AJ
         10ch2NvcxxRlQpvA50y4we9vJKon+gejdZYIb3FYFhYNJfB8NxdPiGdtqD+Kdiit4Zau
         Pghph4c/G/bIFuBB/rLL+BIPB05uyFWijYgfrquJBz9VciGzhelZozjZu+45RE5F89m0
         qrgA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=k7KlclPfxBaZ4PuhxYNdNLWaT1zspuEShyvgb03DTO8=;
        b=beCv8nh4Bb9hicOrdS2mOjfsyUYj34PPrxwUNfTYlr/vxYBk8IOanuPXcv9rBfMdZd
         EYIAsV5uLjxwTOOhE2svcWPaa7re6L/CD7lCW420PPqnzu+1vvt2x1aJeRrli2TKriJU
         dVSEh3Bk1hFMnLCpXbWeFfZmAbRcEzwhNha0oPX8sqtUwGzZiwbPu81SlBndoyrrY0US
         nxgQZXmJAAEal4UAzR905Xh+N9V4YfXs/D/ysNlT6PrtdtaWb7z5KZR7c2Z2DB6N1Agn
         9o313o2Sp/42qHxOuxZuJdiybLSGTj0FE6ecSjQxPX4Ti0L8uqBiXQWZPTgP4jP+8uR2
         ZvnQ==
X-Gm-Message-State: AOAM532kXtwjix/lJGkAgoIpVL7pzIrUX1zko8axiyv81s5ZqME41ltX
	oPGsoVlyi1Kn5Q2haKHNqvc6wugJgZ9j5r/C
X-Google-Smtp-Source: ABdhPJwZfUh9G/Wed7Weawd1NauZH9rXTw9B4qgsNLeucRE2W1yDF7KEDRc11Oc5t0oEAsikB9IFaw==
X-Received: by 2002:a1c:b78b:: with SMTP id h133mr2478678wmf.151.1610748556806;
        Fri, 15 Jan 2021 14:09:16 -0800 (PST)
Return-Path: <leif@nuviainc.com>
Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148])
        by smtp.gmail.com with ESMTPSA id y13sm17087162wrl.63.2021.01.15.14.09.16
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 15 Jan 2021 14:09:16 -0800 (PST)
Date: Fri, 15 Jan 2021 22:09:14 +0000
From: "Leif Lindholm" <leif@nuviainc.com>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: devel@edk2.groups.io
Subject: Re: [PATCH edk2-platforms 1/2] Platform/Overdrive: drop commented out reference to bogus PCD
Message-ID: <20210115220914.GW1664@vanye>
References: <20210114124615.8132-1-ard.biesheuvel@arm.com>
MIME-Version: 1.0
In-Reply-To: <20210114124615.8132-1-ard.biesheuvel@arm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 14, 2021 at 13:46:14 +0100, Ard Biesheuvel wrote:
> Drop the commented out reference to the PCD PcdAtaPassThruPciEmulation,
> which does not exist.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

> ---
>  Platform/AMD/OverdriveBoard/OverdriveBoard.dsc              | 3 ---
>  Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index 19102b2ef818..adc92af080f1 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -404,9 +404,6 @@ [PcdsFixedAtBuild.common]
>    gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
>    gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
>  
> -  ## Use PCI emulation for ATA PassThru
> -  # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
> -
>    ## ACPI (no tables < 4GB)
>    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>  
> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> index d5f75cbba5e5..15c5adf8e824 100644
> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> @@ -393,9 +393,6 @@ [PcdsFixedAtBuild.common]
>    gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
>    gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
>  
> -  ## Use PCI emulation for ATA PassThru
> -  # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
> -
>    ## ACPI (no tables < 4GB)
>    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
>  
> -- 
> 2.17.1
>