public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com
Cc: sami.mujawar@arm.com
Subject: [PATCH v1 14/27] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe
Date: Thu, 21 Jan 2021 09:51:06 +0000	[thread overview]
Message-ID: <20210121095119.22143-15-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com>

From: Pierre Gondois <Pierre.Gondois@arm.com>

This patch fixes the following Ecc reported error:
All include file contents should be guarded by
a #ifndef statement.

This patch replaces a "#if !defined [...]" statement
by a "#ifndef [...]" statement, preventing Ecc to
throw an error.

Edk2 coding standard stating that:
"Names starting with one or two underscores, such as
_MACRO_GUARD_FILE_NAME_H_, must not be used."
the include guard is also updated.

Ref:
https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/
5_source_files/53_include_files#
5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v1

 ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h
index fcc346ba7e3e..32753947e1cb 100644
--- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h
+++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h
@@ -1,13 +1,13 @@
 /** @file

-  Copyright (c) 2016-2018, ARM Limited. All rights reserved.
+  Copyright (c) 2016-2021, Arm Limited. All rights reserved.<BR>

   SPDX-License-Identifier: BSD-2-Clause-Patent

 **/

-#if !defined _MM_COMMUNICATE_H_
-#define _MM_COMMUNICATE_H_
+#ifndef MM_COMMUNICATE_H_
+#define MM_COMMUNICATE_H_

 #define MM_MAJOR_VER_MASK        0xEFFF0000
 #define MM_MINOR_VER_MASK        0x0000FFFF
@@ -19,4 +19,4 @@
 #define MM_CALLER_MAJOR_VER      0x1UL
 #define MM_CALLER_MINOR_VER      0x0

-#endif /* _MM_COMMUNICATE_H_ */
+#endif /* MM_COMMUNICATE_H_ */
--
2.17.1


  parent reply	other threads:[~2021-01-21  9:51 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  9:50 [PATCH v1 00/27] Fix Ecc reported errors in ArmPkg PierreGondois
2021-01-21  9:50 ` [PATCH v1 01/27] ArmPkg: Fix Ecc error 8001 in Chipset PierreGondois
2021-02-05 14:38   ` [edk2-devel] " Sami Mujawar
2021-01-21  9:50 ` [PATCH v1 02/27] ArmPkg: Fix Ecc error 8001 in SemihostLib PierreGondois
2021-02-05 14:43   ` [edk2-devel] " Sami Mujawar
2021-01-21  9:50 ` [PATCH v1 03/27] ArmPkg: Fix Ecc error 8001 in Chipset PierreGondois
2021-02-05 14:48   ` [edk2-devel] " Sami Mujawar
2021-01-21  9:50 ` [PATCH v1 04/27] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib PierreGondois
2021-02-05 14:51   ` [edk2-devel] " Sami Mujawar
2021-01-21  9:50 ` [PATCH v1 05/27] ArmPkg: Fix Ecc error 9005 in CpuDxe PierreGondois
2021-02-05 14:52   ` [edk2-devel] " Sami Mujawar
2021-01-21  9:50 ` [PATCH v1 06/27] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc PierreGondois
2021-01-21  9:50 ` [PATCH v1 07/27] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib PierreGondois
2021-01-21  9:51 ` [PATCH v1 08/27] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe PierreGondois
2021-01-21  9:51 ` [PATCH v1 09/27] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe PierreGondois
2021-01-21  9:51 ` [PATCH v1 10/27] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe PierreGondois
2021-01-21  9:51 ` [PATCH v1 11/27] ArmPkg: Fix Ecc error 10014 in SemihostLib PierreGondois
2021-01-21  9:51 ` [PATCH v1 12/27] ArmPkg: Remove ArmGic/ArmGicSecLib.c PierreGondois
2021-01-21  9:51 ` [PATCH v1 13/27] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib PierreGondois
2021-01-21  9:51 ` PierreGondois [this message]
2021-01-21  9:51 ` [PATCH v1 15/27] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib PierreGondois
2021-01-21  9:51 ` [PATCH v1 16/27] ArmPkg: Rename include guard in ArmGicLib.h PierreGondois
2021-01-21  9:51 ` [PATCH v1 17/27] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE PierreGondois
2021-01-21  9:51 ` [PATCH v1 18/27] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM PierreGondois
2021-01-21  9:51 ` [PATCH v1 19/27] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib PierreGondois
2021-01-21  9:51 ` [PATCH v1 20/27] ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID PierreGondois
2021-01-21  9:51 ` [PATCH v1 21/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE PierreGondois
2021-01-21  9:51 ` [PATCH v1 22/27] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS PierreGondois
2021-01-21  9:51 ` [PATCH v1 23/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID PierreGondois
2021-01-21  9:51 ` [PATCH v1 24/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE PierreGondois
2021-01-21  9:51 ` [PATCH v1 25/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK PierreGondois
2021-01-21  9:51 ` [PATCH v1 26/27] ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT PierreGondois
2021-01-21  9:51 ` [PATCH v1 27/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE PierreGondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121095119.22143-15-Pierre.Gondois@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox