From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web08.4957.1611222717355793228 for ; Thu, 21 Jan 2021 01:51:57 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B42914FF; Thu, 21 Jan 2021 01:51:57 -0800 (PST) Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E14E33F719; Thu, 21 Jan 2021 01:51:55 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [PATCH v1 14/27] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe Date: Thu, 21 Jan 2021 09:51:06 +0000 Message-Id: <20210121095119.22143-15-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> From: Pierre Gondois This patch fixes the following Ecc reported error: All include file contents should be guarded by a #ifndef statement. This patch replaces a "#if !defined [...]" statement by a "#ifndef [...]" statement, preventing Ecc to throw an error. Edk2 coding standard stating that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." the include guard is also updated. Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files# 5-3-5-all-include-file-contents-must-be-protected-by-a-include-guard Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v1 ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h index fcc346ba7e3e..32753947e1cb 100644 --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h @@ -1,13 +1,13 @@ /** @file - Copyright (c) 2016-2018, ARM Limited. All rights reserved. + Copyright (c) 2016-2021, Arm Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ -#if !defined _MM_COMMUNICATE_H_ -#define _MM_COMMUNICATE_H_ +#ifndef MM_COMMUNICATE_H_ +#define MM_COMMUNICATE_H_ #define MM_MAJOR_VER_MASK 0xEFFF0000 #define MM_MINOR_VER_MASK 0x0000FFFF @@ -19,4 +19,4 @@ #define MM_CALLER_MAJOR_VER 0x1UL #define MM_CALLER_MINOR_VER 0x0 -#endif /* _MM_COMMUNICATE_H_ */ +#endif /* MM_COMMUNICATE_H_ */ -- 2.17.1