public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com
Cc: sami.mujawar@arm.com
Subject: [PATCH v1 21/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE
Date: Thu, 21 Jan 2021 09:51:13 +0000	[thread overview]
Message-ID: <20210121095119.22143-22-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com>

From: Pierre Gondois <Pierre.Gondois@arm.com>

This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v1

 ArmPkg/Drivers/ArmScmiDxe/Scmi.c        | 2 +-
 ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
index 847868a7749e..25f6cc3371af 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
+++ b/ArmPkg/Drivers/ArmScmiDxe/Scmi.c
@@ -95,7 +95,7 @@ ScmiCommandExecute (
   // Fill in message header.
   MessageHeader = SCMI_MESSAGE_HEADER (
                     Command->MessageId,
-                    SCMI_MESSAGE_TYPE_COMMAND,
+                    ScmiMessageTypeCommand,
                     Command->ProtocolId
                     );

diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h
index 5f1225f54cd9..6de57a5c9514 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h
+++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h
@@ -23,9 +23,9 @@ typedef enum {

 // SCMI message types.
 typedef enum {
-  SCMI_MESSAGE_TYPE_COMMAND          = 0,
-  SCMI_MESSAGE_TYPE_DELAYED_RESPONSE = 2, // Skipping 1 is deliberate.
-  SCMI_MESSAGE_TYPE_NOTIFICATION     = 3
+  ScmiMessageTypeCommand         = 0,
+  ScmiMessageTypeDelayedResponse = 2, // Skipping 1 is deliberate.
+  ScmiMessageTypeNotification    = 3
 } SCMI_MESSAGE_TYPE;

 // SCMI response error codes.
--
2.17.1


  parent reply	other threads:[~2021-01-21  9:52 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21  9:50 [PATCH v1 00/27] Fix Ecc reported errors in ArmPkg PierreGondois
2021-01-21  9:50 ` [PATCH v1 01/27] ArmPkg: Fix Ecc error 8001 in Chipset PierreGondois
2021-02-05 14:38   ` [edk2-devel] " Sami Mujawar
2021-01-21  9:50 ` [PATCH v1 02/27] ArmPkg: Fix Ecc error 8001 in SemihostLib PierreGondois
2021-02-05 14:43   ` [edk2-devel] " Sami Mujawar
2021-01-21  9:50 ` [PATCH v1 03/27] ArmPkg: Fix Ecc error 8001 in Chipset PierreGondois
2021-02-05 14:48   ` [edk2-devel] " Sami Mujawar
2021-01-21  9:50 ` [PATCH v1 04/27] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib PierreGondois
2021-02-05 14:51   ` [edk2-devel] " Sami Mujawar
2021-01-21  9:50 ` [PATCH v1 05/27] ArmPkg: Fix Ecc error 9005 in CpuDxe PierreGondois
2021-02-05 14:52   ` [edk2-devel] " Sami Mujawar
2021-01-21  9:50 ` [PATCH v1 06/27] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc PierreGondois
2021-01-21  9:50 ` [PATCH v1 07/27] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib PierreGondois
2021-01-21  9:51 ` [PATCH v1 08/27] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe PierreGondois
2021-01-21  9:51 ` [PATCH v1 09/27] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe PierreGondois
2021-01-21  9:51 ` [PATCH v1 10/27] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe PierreGondois
2021-01-21  9:51 ` [PATCH v1 11/27] ArmPkg: Fix Ecc error 10014 in SemihostLib PierreGondois
2021-01-21  9:51 ` [PATCH v1 12/27] ArmPkg: Remove ArmGic/ArmGicSecLib.c PierreGondois
2021-01-21  9:51 ` [PATCH v1 13/27] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib PierreGondois
2021-01-21  9:51 ` [PATCH v1 14/27] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe PierreGondois
2021-01-21  9:51 ` [PATCH v1 15/27] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib PierreGondois
2021-01-21  9:51 ` [PATCH v1 16/27] ArmPkg: Rename include guard in ArmGicLib.h PierreGondois
2021-01-21  9:51 ` [PATCH v1 17/27] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE PierreGondois
2021-01-21  9:51 ` [PATCH v1 18/27] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM PierreGondois
2021-01-21  9:51 ` [PATCH v1 19/27] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib PierreGondois
2021-01-21  9:51 ` [PATCH v1 20/27] ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID PierreGondois
2021-01-21  9:51 ` PierreGondois [this message]
2021-01-21  9:51 ` [PATCH v1 22/27] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS PierreGondois
2021-01-21  9:51 ` [PATCH v1 23/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID PierreGondois
2021-01-21  9:51 ` [PATCH v1 24/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE PierreGondois
2021-01-21  9:51 ` [PATCH v1 25/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK PierreGondois
2021-01-21  9:51 ` [PATCH v1 26/27] ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT PierreGondois
2021-01-21  9:51 ` [PATCH v1 27/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE PierreGondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121095119.22143-22-Pierre.Gondois@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox