From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com
Cc: sami.mujawar@arm.com
Subject: [PATCH v1 25/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK
Date: Thu, 21 Jan 2021 09:51:17 +0000 [thread overview]
Message-ID: <20210121095119.22143-26-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com>
From: Pierre Gondois <Pierre.Gondois@arm.com>
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v1
ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c | 12 ++++++------
ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 10 +++++-----
ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 10 +++++-----
3 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c
index c84ce97f15ac..2c6206be9368 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c
+++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c
@@ -69,9 +69,9 @@ BaseGetTotalProtocols (
/** Common function which returns vendor details.
- @param[in] MessageId SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR
+ @param[in] MessageId ScmiMessageIdBaseDiscoverVendor
OR
- SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR
+ ScmiMessageIdBaseDiscoverSubVendor
@param[out] VendorIdentifier ASCII name of the vendor/subvendor.
@@ -133,7 +133,7 @@ BaseDiscoverVendor (
)
{
return BaseDiscoverVendorDetails (
- SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR,
+ ScmiMessageIdBaseDiscoverVendor,
VendorIdentifier
);
}
@@ -156,7 +156,7 @@ BaseDiscoverSubVendor (
)
{
return BaseDiscoverVendorDetails (
- SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR,
+ ScmiMessageIdBaseDiscoverSubVendor,
VendorIdentifier
);
}
@@ -184,7 +184,7 @@ BaseDiscoverImplVersion (
UINT32 PayloadLength;
Cmd.ProtocolId = ScmiProtocolIdBase;
- Cmd.MessageId = SCMI_MESSAGE_ID_BASE_DISCOVER_IMPLEMENTATION_VERSION;
+ Cmd.MessageId = ScmiMessageIdBaseDiscoverImplementationVersion;
PayloadLength = 0;
@@ -251,7 +251,7 @@ BaseDiscoverListProtocols (
}
Cmd.ProtocolId = ScmiProtocolIdBase;
- Cmd.MessageId = SCMI_MESSAGE_ID_BASE_DISCOVER_LIST_PROTOCOLS;
+ Cmd.MessageId = ScmiMessageIdBaseDiscoverListProtocols;
Skip = 0;
diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c
index b7892bfd7771..9cd3a7ed232d 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c
+++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c
@@ -123,7 +123,7 @@ ClockGetClockAttributes (
*MessageParams = ClockId;
Cmd.ProtocolId = ScmiProtocolIdClock;
- Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_ATTRIBUTES;
+ Cmd.MessageId = ScmiMessageIdClockAttributes;
PayloadLength = sizeof (ClockId);
@@ -204,7 +204,7 @@ ClockDescribeRates (
}
Cmd.ProtocolId = ScmiProtocolIdClock;
- Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_DESCRIBE_RATES;
+ Cmd.MessageId = ScmiMessageIdClockDescribeRates;
*MessageParams++ = ClockId;
@@ -321,7 +321,7 @@ ClockRateGet (
*MessageParams = ClockId;
Cmd.ProtocolId = ScmiProtocolIdClock;
- Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_RATE_GET;
+ Cmd.MessageId = ScmiMessageIdClockRateGet;
PayloadLength = sizeof (ClockId);
@@ -375,7 +375,7 @@ ClockRateSet (
ClockRateSetAttributes->Rate.High = (UINT32)(Rate >> 32);
Cmd.ProtocolId = ScmiProtocolIdClock;
- Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_RATE_SET;
+ Cmd.MessageId = ScmiMessageIdClockRateSet;
PayloadLength = sizeof (CLOCK_RATE_SET_ATTRIBUTES);
@@ -422,7 +422,7 @@ ClockEnable (
ClockConfigSetAttributes->Attributes = Enable ? BIT0 : 0;
Cmd.ProtocolId = ScmiProtocolIdClock;
- Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_CONFIG_SET;
+ Cmd.MessageId = ScmiMessageIdClockConfigSet;
PayloadLength = sizeof (CLOCK_CONFIG_SET_ATTRIBUTES);
diff --git a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h
index 85b5b8d1e764..cd62f05a58fd 100644
--- a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h
+++ b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h
@@ -22,11 +22,11 @@ extern EFI_GUID gArmScmiClockProtocolGuid;
// Message Type for clock management protocol.
typedef enum {
- SCMI_MESSAGE_ID_CLOCK_ATTRIBUTES = 0x3,
- SCMI_MESSAGE_ID_CLOCK_DESCRIBE_RATES = 0x4,
- SCMI_MESSAGE_ID_CLOCK_RATE_SET = 0x5,
- SCMI_MESSAGE_ID_CLOCK_RATE_GET = 0x6,
- SCMI_MESSAGE_ID_CLOCK_CONFIG_SET = 0x7
+ ScmiMessageIdClockAttributes = 0x3,
+ ScmiMessageIdClockDescribeRates = 0x4,
+ ScmiMessageIdClockRateSet = 0x5,
+ ScmiMessageIdClockRateGet = 0x6,
+ ScmiMessageIdClockConfigSet = 0x7
} SCMI_MESSAGE_ID_CLOCK;
typedef enum {
--
2.17.1
next prev parent reply other threads:[~2021-01-21 9:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 9:50 [PATCH v1 00/27] Fix Ecc reported errors in ArmPkg PierreGondois
2021-01-21 9:50 ` [PATCH v1 01/27] ArmPkg: Fix Ecc error 8001 in Chipset PierreGondois
2021-02-05 14:38 ` [edk2-devel] " Sami Mujawar
2021-01-21 9:50 ` [PATCH v1 02/27] ArmPkg: Fix Ecc error 8001 in SemihostLib PierreGondois
2021-02-05 14:43 ` [edk2-devel] " Sami Mujawar
2021-01-21 9:50 ` [PATCH v1 03/27] ArmPkg: Fix Ecc error 8001 in Chipset PierreGondois
2021-02-05 14:48 ` [edk2-devel] " Sami Mujawar
2021-01-21 9:50 ` [PATCH v1 04/27] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib PierreGondois
2021-02-05 14:51 ` [edk2-devel] " Sami Mujawar
2021-01-21 9:50 ` [PATCH v1 05/27] ArmPkg: Fix Ecc error 9005 in CpuDxe PierreGondois
2021-02-05 14:52 ` [edk2-devel] " Sami Mujawar
2021-01-21 9:50 ` [PATCH v1 06/27] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc PierreGondois
2021-01-21 9:50 ` [PATCH v1 07/27] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib PierreGondois
2021-01-21 9:51 ` [PATCH v1 08/27] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe PierreGondois
2021-01-21 9:51 ` [PATCH v1 09/27] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe PierreGondois
2021-01-21 9:51 ` [PATCH v1 10/27] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe PierreGondois
2021-01-21 9:51 ` [PATCH v1 11/27] ArmPkg: Fix Ecc error 10014 in SemihostLib PierreGondois
2021-01-21 9:51 ` [PATCH v1 12/27] ArmPkg: Remove ArmGic/ArmGicSecLib.c PierreGondois
2021-01-21 9:51 ` [PATCH v1 13/27] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib PierreGondois
2021-01-21 9:51 ` [PATCH v1 14/27] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe PierreGondois
2021-01-21 9:51 ` [PATCH v1 15/27] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib PierreGondois
2021-01-21 9:51 ` [PATCH v1 16/27] ArmPkg: Rename include guard in ArmGicLib.h PierreGondois
2021-01-21 9:51 ` [PATCH v1 17/27] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE PierreGondois
2021-01-21 9:51 ` [PATCH v1 18/27] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM PierreGondois
2021-01-21 9:51 ` [PATCH v1 19/27] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib PierreGondois
2021-01-21 9:51 ` [PATCH v1 20/27] ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID PierreGondois
2021-01-21 9:51 ` [PATCH v1 21/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE PierreGondois
2021-01-21 9:51 ` [PATCH v1 22/27] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS PierreGondois
2021-01-21 9:51 ` [PATCH v1 23/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID PierreGondois
2021-01-21 9:51 ` [PATCH v1 24/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE PierreGondois
2021-01-21 9:51 ` PierreGondois [this message]
2021-01-21 9:51 ` [PATCH v1 26/27] ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT PierreGondois
2021-01-21 9:51 ` [PATCH v1 27/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121095119.22143-26-Pierre.Gondois@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox