From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.5077.1611222734330632019 for ; Thu, 21 Jan 2021 01:52:14 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C0C8D6E; Thu, 21 Jan 2021 01:52:14 -0800 (PST) Received: from e120189.arm.com (unknown [10.57.40.199]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E30893F719; Thu, 21 Jan 2021 01:52:12 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [PATCH v1 25/27] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK Date: Thu, 21 Jan 2021 09:51:17 +0000 Message-Id: <20210121095119.22143-26-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210121095119.22143-1-Pierre.Gondois@arm.com> References: <20210121095119.22143-1-Pierre.Gondois@arm.com> From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v1 ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c | 12 ++++++------ ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 10 +++++----- ArmPkg/Include/Protocol/ArmScmiClockProtocol.h | 10 +++++----- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c index c84ce97f15ac..2c6206be9368 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c @@ -69,9 +69,9 @@ BaseGetTotalProtocols ( /** Common function which returns vendor details. - @param[in] MessageId SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR + @param[in] MessageId ScmiMessageIdBaseDiscoverVendor OR - SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR + ScmiMessageIdBaseDiscoverSubVendor @param[out] VendorIdentifier ASCII name of the vendor/subvendor. @@ -133,7 +133,7 @@ BaseDiscoverVendor ( ) { return BaseDiscoverVendorDetails ( - SCMI_MESSAGE_ID_BASE_DISCOVER_VENDOR, + ScmiMessageIdBaseDiscoverVendor, VendorIdentifier ); } @@ -156,7 +156,7 @@ BaseDiscoverSubVendor ( ) { return BaseDiscoverVendorDetails ( - SCMI_MESSAGE_ID_BASE_DISCOVER_SUB_VENDOR, + ScmiMessageIdBaseDiscoverSubVendor, VendorIdentifier ); } @@ -184,7 +184,7 @@ BaseDiscoverImplVersion ( UINT32 PayloadLength; Cmd.ProtocolId = ScmiProtocolIdBase; - Cmd.MessageId = SCMI_MESSAGE_ID_BASE_DISCOVER_IMPLEMENTATION_VERSION; + Cmd.MessageId = ScmiMessageIdBaseDiscoverImplementationVersion; PayloadLength = 0; @@ -251,7 +251,7 @@ BaseDiscoverListProtocols ( } Cmd.ProtocolId = ScmiProtocolIdBase; - Cmd.MessageId = SCMI_MESSAGE_ID_BASE_DISCOVER_LIST_PROTOCOLS; + Cmd.MessageId = ScmiMessageIdBaseDiscoverListProtocols; Skip = 0; diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c index b7892bfd7771..9cd3a7ed232d 100644 --- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c +++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c @@ -123,7 +123,7 @@ ClockGetClockAttributes ( *MessageParams = ClockId; Cmd.ProtocolId = ScmiProtocolIdClock; - Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_ATTRIBUTES; + Cmd.MessageId = ScmiMessageIdClockAttributes; PayloadLength = sizeof (ClockId); @@ -204,7 +204,7 @@ ClockDescribeRates ( } Cmd.ProtocolId = ScmiProtocolIdClock; - Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_DESCRIBE_RATES; + Cmd.MessageId = ScmiMessageIdClockDescribeRates; *MessageParams++ = ClockId; @@ -321,7 +321,7 @@ ClockRateGet ( *MessageParams = ClockId; Cmd.ProtocolId = ScmiProtocolIdClock; - Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_RATE_GET; + Cmd.MessageId = ScmiMessageIdClockRateGet; PayloadLength = sizeof (ClockId); @@ -375,7 +375,7 @@ ClockRateSet ( ClockRateSetAttributes->Rate.High = (UINT32)(Rate >> 32); Cmd.ProtocolId = ScmiProtocolIdClock; - Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_RATE_SET; + Cmd.MessageId = ScmiMessageIdClockRateSet; PayloadLength = sizeof (CLOCK_RATE_SET_ATTRIBUTES); @@ -422,7 +422,7 @@ ClockEnable ( ClockConfigSetAttributes->Attributes = Enable ? BIT0 : 0; Cmd.ProtocolId = ScmiProtocolIdClock; - Cmd.MessageId = SCMI_MESSAGE_ID_CLOCK_CONFIG_SET; + Cmd.MessageId = ScmiMessageIdClockConfigSet; PayloadLength = sizeof (CLOCK_CONFIG_SET_ATTRIBUTES); diff --git a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h index 85b5b8d1e764..cd62f05a58fd 100644 --- a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h +++ b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h @@ -22,11 +22,11 @@ extern EFI_GUID gArmScmiClockProtocolGuid; // Message Type for clock management protocol. typedef enum { - SCMI_MESSAGE_ID_CLOCK_ATTRIBUTES = 0x3, - SCMI_MESSAGE_ID_CLOCK_DESCRIBE_RATES = 0x4, - SCMI_MESSAGE_ID_CLOCK_RATE_SET = 0x5, - SCMI_MESSAGE_ID_CLOCK_RATE_GET = 0x6, - SCMI_MESSAGE_ID_CLOCK_CONFIG_SET = 0x7 + ScmiMessageIdClockAttributes = 0x3, + ScmiMessageIdClockDescribeRates = 0x4, + ScmiMessageIdClockRateSet = 0x5, + ScmiMessageIdClockRateGet = 0x6, + ScmiMessageIdClockConfigSet = 0x7 } SCMI_MESSAGE_ID_CLOCK; typedef enum { -- 2.17.1