From: "Leif Lindholm" <leif@nuviainc.com>
To: Ling Jia <jialing@phytium.com.cn>
Cc: devel@edk2.groups.io
Subject: Re: added support for DurianPkg.
Date: Fri, 22 Jan 2021 12:04:13 +0000 [thread overview]
Message-ID: <20210122120413.GZ1664@vanye> (raw)
In-Reply-To: <20210115084802.62196-1-jialing@phytium.com.cn>
Hi Ling,
Apologies for not responding sooner. As you can imagine, the news last
week that NUVIA was being acquired by Qualcomm has caused some
distractions.
I will get on with reviewing the individual patches, but I will start
by proposing some name changes and structure changes to better fit
with tianocore design principles.
First of all - the concept of "packages" is fairly central to edk2.
Any directory that contains a .dec file is a package, and this can be
more strongly indicated by giving the directory a name ending in Pkg.
Personally, I also tend to see directories containing .dsc/.fdf as
packages, even if they don't currently hold a .dec.
Platform
Phytium
DurianPkg
DurianPkg.dsc
DurianPkg.fdf
Silicon
Phytium
Phytium2000-4Pkg
Drivers
Include
Library
Protocol
Library
PhytiumCommonPkg
PhytiumCommon.dec
PhytiumCommon.dsc.inc
Drivers
Include
Library
Protocol
Library
Logo
You could then have a new Phytium2000-4Pkg.dec, to provide the
[Include] statement for that package.
Does this make sense?
On Fri, Jan 15, 2021 at 08:47:52 +0000, Ling Jia wrote:
> From: Ling <jialing@phytium.com.cn>
>
> The modules could be runed at the silicon of Phytium2000-4.
> They supported Acpi parameter configuration, Pci bus scaning,
> flash read-write and erase abd operating system boot function.
> Maintainers.txt: Added maintainers and reviewers for the DurianPkg.
>
> The public git repository is :
> https://github.com/jialing2020/edk2-platforms/tree/phytium_opensource_for_2004_v1
>
> *** BLURB HERE ***
You can delete this line - it's just there to remind you to write a
message :)
Best Regards,
Leif
>
> Ling (10):
> Silicon/Phytium/: added PhytiumPlatformLib to Phytium2000-4
> Silicon/Phytium: Added Acpi support to Phytium2000-4
> Silicon/Phytium: Added SMBIOS support to Phytium2000-4
> Silicon/Phytium/Phytium2000-4/Library: Added PciSegmentLib to
> Phytium2000-4
> Silicon/Phytium: Added PciHostBridgeLib to Phytium2000-4
> Silicon/Phytium: Added Logo support to Phytium Silicon
> Silicon/Phytium: Added Spi driver support to Phytium2000-4
> Silicon/Phytium: Added flash driver support to Phytium Silicon
> Silicon/Phytium: Added fvb driver for norflash
> Silicon/Phytium: Added Rtc driver to Phytium2000-4
>
> Silicon/Phytium/Phytium.dec | 60 +
> Silicon/Phytium/Phytium.dsc.inc | 388 ++++++
> Platform/Phytium/Durian/DurianPkg.dsc | 340 +++++
> Platform/Phytium/Durian/DurianPkg.fdf | 241 ++++
> Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.inf | 72 +
> Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.inf | 54 +
> Silicon/Phytium/Library/LogoLib/LogoLib.inf | 58 +
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 58 +
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/AcpiTables.inf | 61 +
> Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.inf | 52 +
> Silicon/Phytium/Phytium2000-4/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 55 +
> Silicon/Phytium/Phytium2000-4/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 55 +
> Silicon/Phytium/Phytium2000-4/Library/PciSegmentLib/PciSegmentLib.inf | 28 +
> Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLib.inf | 66 +
> Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.inf | 44 +
> Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.h | 106 ++
> Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.h | 106 ++
> Silicon/Phytium/Include/PhytiumPlatform.h | 93 ++
> Silicon/Phytium/Include/PhytiumSystemServiceInterface.h | 112 ++
> Silicon/Phytium/Include/Protocol/PhytiumSpi.h | 51 +
> Silicon/Phytium/Include/Protocol/PhytiumSpiNorFlash.h | 74 +
> Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.h | 73 +
> Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.h | 24 +
> Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.c | 1235 +++++++++++++++++
> Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.c | 435 ++++++
> Silicon/Phytium/Library/LogoLib/Logo.c | 133 ++
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 254 ++++
> Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.c | 189 +++
> Silicon/Phytium/Phytium2000-4/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 959 +++++++++++++
> Silicon/Phytium/Phytium2000-4/Library/PciHostBridgeLib/PciHostBridgeLib.c | 182 +++
> Silicon/Phytium/Phytium2000-4/Library/PciSegmentLib/PciSegmentLib.c | 1440 ++++++++++++++++++++
> Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLib.c | 135 ++
> Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLibMem.c | 148 ++
> Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.c | 468 +++++++
> Maintainers.txt | 7 +
> Silicon/Phytium/Logo/PhytiumLogo.bmp | Bin 0 -> 32454 bytes
> Silicon/Phytium/Phytium.fdf.inc | 119 ++
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/AcpiSsdtRootPci.asl | 234 ++++
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dbg2.aslc | 85 ++
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Cpu.asl | 85 ++
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Dsdt.asl | 15 +
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Uart.asl | 65 +
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Fadt.aslc | 81 ++
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Gtdt.aslc | 87 ++
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Iort.aslc | 89 ++
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Madt.aslc | 66 +
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Mcfg.aslc | 69 +
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Pptt.aslc | 219 +++
> Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Spcr.aslc | 83 ++
> Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/AArch64/PhytiumPlatformHelper.S | 76 ++
> 50 files changed, 9229 insertions(+)
> create mode 100644 Silicon/Phytium/Phytium.dec
> create mode 100644 Silicon/Phytium/Phytium.dsc.inc
> create mode 100644 Platform/Phytium/Durian/DurianPkg.dsc
> create mode 100644 Platform/Phytium/Durian/DurianPkg.fdf
> create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.inf
> create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.inf
> create mode 100644 Silicon/Phytium/Library/LogoLib/LogoLib.inf
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/AcpiTables.inf
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.inf
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PciSegmentLib/PciSegmentLib.inf
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLib.inf
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.inf
> create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.h
> create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.h
> create mode 100644 Silicon/Phytium/Include/PhytiumPlatform.h
> create mode 100644 Silicon/Phytium/Include/PhytiumSystemServiceInterface.h
> create mode 100644 Silicon/Phytium/Include/Protocol/PhytiumSpi.h
> create mode 100644 Silicon/Phytium/Include/Protocol/PhytiumSpiNorFlash.h
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.h
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.h
> create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.c
> create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.c
> create mode 100644 Silicon/Phytium/Library/LogoLib/Logo.c
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiPlatformDxe/AcpiPlatform.c
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.c
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PciHostBridgeLib/PciHostBridgeLib.c
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PciSegmentLib/PciSegmentLib.c
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLib.c
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLibMem.c
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.c
> create mode 100644 Silicon/Phytium/Logo/PhytiumLogo.bmp
> create mode 100644 Silicon/Phytium/Phytium.fdf.inc
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/AcpiSsdtRootPci.asl
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dbg2.aslc
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Cpu.asl
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Dsdt.asl
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Uart.asl
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Fadt.aslc
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Gtdt.aslc
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Iort.aslc
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Madt.aslc
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Mcfg.aslc
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Pptt.aslc
> create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Spcr.aslc
> create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/AArch64/PhytiumPlatformHelper.S
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-01-22 12:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 8:47 added support for DurianPkg Ling Jia
2021-01-15 8:47 ` [PATCH v1 01/10] Silicon/Phytium/: added PhytiumPlatformLib to Phytium2000-4 Ling Jia
2021-01-22 13:13 ` Leif Lindholm
2021-01-25 8:56 ` 贾玲
2021-01-15 8:47 ` [PATCH v1 02/10] Silicon/Phytium: Added Acpi support " Ling Jia
2021-01-15 8:47 ` [PATCH v1 03/10] Silicon/Phytium: Added SMBIOS " Ling Jia
2021-01-15 8:47 ` [PATCH v1 04/10] Silicon/Phytium/Phytium2000-4/Library: Added PciSegmentLib " Ling Jia
2021-01-15 8:47 ` [PATCH v1 05/10] Silicon/Phytium: Added PciHostBridgeLib " Ling Jia
2021-01-15 8:47 ` [PATCH v1 06/10] Silicon/Phytium: Added Logo support to Phytium Silicon Ling Jia
2021-01-15 8:47 ` [PATCH v1 07/10] Silicon/Phytium: Added Spi driver support to Phytium2000-4 Ling Jia
2021-01-15 8:48 ` [PATCH v1 08/10] Silicon/Phytium: Added flash driver support to Phytium Silicon Ling Jia
2021-01-15 8:48 ` [PATCH v1 09/10] Silicon/Phytium: Added fvb driver for norflash Ling Jia
2021-01-15 8:48 ` [PATCH v1 10/10] Silicon/Phytium: Added Rtc driver to Phytium2000-4 Ling Jia
2021-01-22 12:04 ` Leif Lindholm [this message]
2021-03-12 20:50 ` [edk2-devel] added support for DurianPkg Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210122120413.GZ1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox