From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.groups.io with SMTP id smtpd.web10.7868.1611317057579733592 for ; Fri, 22 Jan 2021 04:04:18 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=zhm8MBQN; spf=pass (domain: nuviainc.com, ip: 209.85.128.42, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f42.google.com with SMTP id c124so4075390wma.5 for ; Fri, 22 Jan 2021 04:04:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=mmBQvIAqUwNAYMfxSdz+ZMR1uxqEVDp2BNwd9fq79bg=; b=zhm8MBQNllog4z0uTKVw5ONq9EZ0a6AFDtYrzom21WSTcQk+cGcVXk/JIV7Wg08qLk cZdXKLpUDqUl8I/J/VfJYIFfuMdxc3z0O/vx152rlcXj7GlsNKX2hmTqt83HBm6xhzif hlyEAbHydwZ/5khYdnrp9sX5f4HfklwyByU4uZqe9rfNX66/fb+b1YrYvx7wR/7lbwI2 UdQtPzTOy6LDSbQPdDXTz21AAou0FekRCWNTpGEIAx7lp/D3e0bV1s7aGzGNgg3/CuMV RArTXnYfZYUCQemUoCcfMkP2NkYgTLC+cYsZbv/024T2uCsTceJmvc7hvC36a2rgr2Up stCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mmBQvIAqUwNAYMfxSdz+ZMR1uxqEVDp2BNwd9fq79bg=; b=Ay9HyfINmWacS4OTAdd0rdiCJrdR59R02gZUNpITDR7bwMWZ1o0mpLsLcp3M/yXju4 AlLB7r/EmqvUKltVEFYQnM4fVKP1B5KnEdyYzt5DOatpU2wRoZy8Ckag3PBjx6bilnDo RExbqLKhO+PZLOvT7ibWRanyTMKdlxQnIevRyqxy0tnd1mrVYeXTiCHhTyiSjBU21D9X oiUX4AIDDcCEHSnq3Dv3/P4C4bkQcidgEFTNJkwWpJClkbO+x2NVN7t3+qFmAuNfwrqw mZOzpYH9+dIkYuRMViZQv6GsfXJf6Aor1sZxGxvMtax/yp9xYUwHRv+KD8MEjcCmrFbn lQ6A== X-Gm-Message-State: AOAM533njjQ8oUzod0PoNhpD5Nu/huGDTFQxBwScQdNIPda7vN+9OJRy 9XevVEMOXCzo6Y5S+vaOX8d3O9i5QbaQ3T1e X-Google-Smtp-Source: ABdhPJzmcYhPkELPT8H2q9YAjMcJvY1SRn1sZM95AAveII3s/7mubyrQPJBi/5byE4AfOo0OsnDL9g== X-Received: by 2002:a1c:6802:: with SMTP id d2mr3615958wmc.32.1611317056101; Fri, 22 Jan 2021 04:04:16 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id d9sm4027508wrq.74.2021.01.22.04.04.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jan 2021 04:04:15 -0800 (PST) Date: Fri, 22 Jan 2021 12:04:13 +0000 From: "Leif Lindholm" To: Ling Jia Cc: devel@edk2.groups.io Subject: Re: added support for DurianPkg. Message-ID: <20210122120413.GZ1664@vanye> References: <20210115084802.62196-1-jialing@phytium.com.cn> MIME-Version: 1.0 In-Reply-To: <20210115084802.62196-1-jialing@phytium.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Ling, Apologies for not responding sooner. As you can imagine, the news last week that NUVIA was being acquired by Qualcomm has caused some distractions. I will get on with reviewing the individual patches, but I will start by proposing some name changes and structure changes to better fit with tianocore design principles. First of all - the concept of "packages" is fairly central to edk2. Any directory that contains a .dec file is a package, and this can be more strongly indicated by giving the directory a name ending in Pkg. Personally, I also tend to see directories containing .dsc/.fdf as packages, even if they don't currently hold a .dec. Platform Phytium DurianPkg DurianPkg.dsc DurianPkg.fdf Silicon Phytium Phytium2000-4Pkg Drivers Include Library Protocol Library PhytiumCommonPkg PhytiumCommon.dec PhytiumCommon.dsc.inc Drivers Include Library Protocol Library Logo You could then have a new Phytium2000-4Pkg.dec, to provide the [Include] statement for that package. Does this make sense? On Fri, Jan 15, 2021 at 08:47:52 +0000, Ling Jia wrote: > From: Ling > > The modules could be runed at the silicon of Phytium2000-4. > They supported Acpi parameter configuration, Pci bus scaning, > flash read-write and erase abd operating system boot function. > Maintainers.txt: Added maintainers and reviewers for the DurianPkg. > > The public git repository is : > https://github.com/jialing2020/edk2-platforms/tree/phytium_opensource_for_2004_v1 > > *** BLURB HERE *** You can delete this line - it's just there to remind you to write a message :) Best Regards, Leif > > Ling (10): > Silicon/Phytium/: added PhytiumPlatformLib to Phytium2000-4 > Silicon/Phytium: Added Acpi support to Phytium2000-4 > Silicon/Phytium: Added SMBIOS support to Phytium2000-4 > Silicon/Phytium/Phytium2000-4/Library: Added PciSegmentLib to > Phytium2000-4 > Silicon/Phytium: Added PciHostBridgeLib to Phytium2000-4 > Silicon/Phytium: Added Logo support to Phytium Silicon > Silicon/Phytium: Added Spi driver support to Phytium2000-4 > Silicon/Phytium: Added flash driver support to Phytium Silicon > Silicon/Phytium: Added fvb driver for norflash > Silicon/Phytium: Added Rtc driver to Phytium2000-4 > > Silicon/Phytium/Phytium.dec | 60 + > Silicon/Phytium/Phytium.dsc.inc | 388 ++++++ > Platform/Phytium/Durian/DurianPkg.dsc | 340 +++++ > Platform/Phytium/Durian/DurianPkg.fdf | 241 ++++ > Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.inf | 72 + > Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.inf | 54 + > Silicon/Phytium/Library/LogoLib/LogoLib.inf | 58 + > Silicon/Phytium/Phytium2000-4/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 58 + > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/AcpiTables.inf | 61 + > Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.inf | 52 + > Silicon/Phytium/Phytium2000-4/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 55 + > Silicon/Phytium/Phytium2000-4/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 55 + > Silicon/Phytium/Phytium2000-4/Library/PciSegmentLib/PciSegmentLib.inf | 28 + > Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLib.inf | 66 + > Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.inf | 44 + > Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.h | 106 ++ > Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.h | 106 ++ > Silicon/Phytium/Include/PhytiumPlatform.h | 93 ++ > Silicon/Phytium/Include/PhytiumSystemServiceInterface.h | 112 ++ > Silicon/Phytium/Include/Protocol/PhytiumSpi.h | 51 + > Silicon/Phytium/Include/Protocol/PhytiumSpiNorFlash.h | 74 + > Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.h | 73 + > Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.h | 24 + > Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.c | 1235 +++++++++++++++++ > Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.c | 435 ++++++ > Silicon/Phytium/Library/LogoLib/Logo.c | 133 ++ > Silicon/Phytium/Phytium2000-4/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 254 ++++ > Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.c | 189 +++ > Silicon/Phytium/Phytium2000-4/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 959 +++++++++++++ > Silicon/Phytium/Phytium2000-4/Library/PciHostBridgeLib/PciHostBridgeLib.c | 182 +++ > Silicon/Phytium/Phytium2000-4/Library/PciSegmentLib/PciSegmentLib.c | 1440 ++++++++++++++++++++ > Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLib.c | 135 ++ > Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLibMem.c | 148 ++ > Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.c | 468 +++++++ > Maintainers.txt | 7 + > Silicon/Phytium/Logo/PhytiumLogo.bmp | Bin 0 -> 32454 bytes > Silicon/Phytium/Phytium.fdf.inc | 119 ++ > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/AcpiSsdtRootPci.asl | 234 ++++ > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dbg2.aslc | 85 ++ > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Cpu.asl | 85 ++ > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Dsdt.asl | 15 + > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Uart.asl | 65 + > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Fadt.aslc | 81 ++ > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Gtdt.aslc | 87 ++ > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Iort.aslc | 89 ++ > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Madt.aslc | 66 + > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Mcfg.aslc | 69 + > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Pptt.aslc | 219 +++ > Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Spcr.aslc | 83 ++ > Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/AArch64/PhytiumPlatformHelper.S | 76 ++ > 50 files changed, 9229 insertions(+) > create mode 100644 Silicon/Phytium/Phytium.dec > create mode 100644 Silicon/Phytium/Phytium.dsc.inc > create mode 100644 Platform/Phytium/Durian/DurianPkg.dsc > create mode 100644 Platform/Phytium/Durian/DurianPkg.fdf > create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.inf > create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.inf > create mode 100644 Silicon/Phytium/Library/LogoLib/LogoLib.inf > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/AcpiTables.inf > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.inf > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.inf > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PciHostBridgeLib/PciHostBridgeLib.inf > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PciSegmentLib/PciSegmentLib.inf > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLib.inf > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.inf > create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.h > create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.h > create mode 100644 Silicon/Phytium/Include/PhytiumPlatform.h > create mode 100644 Silicon/Phytium/Include/PhytiumSystemServiceInterface.h > create mode 100644 Silicon/Phytium/Include/Protocol/PhytiumSpi.h > create mode 100644 Silicon/Phytium/Include/Protocol/PhytiumSpiNorFlash.h > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.h > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.h > create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumFlashFvbDxe/PhytiumFlashFvbDxe.c > create mode 100644 Silicon/Phytium/CommonDrivers/PhytiumSpiNorFlashDxe/PhytiumSpiNorFlashDxe.c > create mode 100644 Silicon/Phytium/Library/LogoLib/Logo.c > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiPlatformDxe/AcpiPlatform.c > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/PhytiumSpiDxe/PhytiumSpiDxe.c > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PciHostBridgeLib/PciHostBridgeLib.c > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PciSegmentLib/PciSegmentLib.c > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLib.c > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/PhytiumPlatformLibMem.c > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumRealTimeClockLib/PhytiumRealTimeClockLib.c > create mode 100644 Silicon/Phytium/Logo/PhytiumLogo.bmp > create mode 100644 Silicon/Phytium/Phytium.fdf.inc > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/AcpiSsdtRootPci.asl > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dbg2.aslc > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Cpu.asl > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Dsdt.asl > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Dsdt/Uart.asl > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Fadt.aslc > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Gtdt.aslc > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Iort.aslc > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Madt.aslc > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Mcfg.aslc > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Pptt.aslc > create mode 100644 Silicon/Phytium/Phytium2000-4/Drivers/AcpiTables/Spcr.aslc > create mode 100644 Silicon/Phytium/Phytium2000-4/Library/PhytiumPlatformLib/AArch64/PhytiumPlatformHelper.S > > -- > 2.25.1 >