public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Sami Mujawar <sami.mujawar@arm.com>
Cc: devel@edk2.groups.io, ard.biesheuvel@arm.com,
	thomas.abraham@arm.com, Matteo.Carlini@arm.com,
	Ben.Adderson@arm.com, nd@arm.com
Subject: Re: [PATCH edk2-platforms v1 0/6] Fix platform support for dynamic tables framework
Date: Mon, 25 Jan 2021 12:56:10 +0000	[thread overview]
Message-ID: <20210125125610.GB1664@vanye> (raw)
In-Reply-To: <20210122132935.22484-1-sami.mujawar@arm.com>

Hi Sami,

On Fri, Jan 22, 2021 at 13:29:29 +0000, Sami Mujawar wrote:
> This patch series fixes the following issues for FVP & Juno platform
> when Dynamic Tables Framework is enabled.
>  - Remove the usage of function macros as this does not comply with
>    the edk2 coding standard.
>  - Fix serial port usage on FVP.
>  - Remove serial port description from SSDT and DSDT as this is now
>    generated by Dynamic AML.
> 
> This series also includes a patch to remove PL050 KMI support on
> Juno.
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/1608_fix_config_mgr_handlers_v1
> 
> Sami Mujawar (6):
>   Platform/ARM: FVP: Remove usage of function macros
>   Platform/ARM: Juno: Remove usage of function macros
>   Platform/ARM: FVP: Fix serial port usage
>   Platform/ARM: Juno: Remove PL050 KMI description from DSDT
>   Platform/ARM: Juno: Remove Serial port SSDT
>   Platform/ARM: FVP: Remove Serial port description from DSDT

For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as c6d565eddf6f..fcf693c9e8d6.

Many thanks for quick response time.

> 
>  Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl                                                      |  16 +-
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl          |  16 +-
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtUart.asl      |  42 --
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 455 ++++++++++++++------
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h      | 107 +----
>  Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |   3 +-
>  Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc                                          |  11 +-
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc                    |  19 -
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl      |  22 +-
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c  | 347 ++++++++++-----
>  Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h  |  73 +---
>  11 files changed, 615 insertions(+), 496 deletions(-)
>  delete mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtUart.asl
>  delete mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc
> 
> -- 
> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> 

      parent reply	other threads:[~2021-01-25 12:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 13:29 [PATCH edk2-platforms v1 0/6] Fix platform support for dynamic tables framework Sami Mujawar
2021-01-22 13:29 ` [PATCH edk2-platforms v1 1/6] Platform/ARM: FVP: Remove usage of function macros Sami Mujawar
2021-01-22 13:29 ` [PATCH edk2-platforms v1 2/6] Platform/ARM: Juno: " Sami Mujawar
2021-01-22 13:29 ` [PATCH edk2-platforms v1 3/6] Platform/ARM: FVP: Fix serial port usage Sami Mujawar
2021-01-22 13:29 ` [PATCH edk2-platforms v1 4/6] Platform/ARM: Juno: Remove PL050 KMI description from DSDT Sami Mujawar
2021-01-22 13:29 ` [PATCH edk2-platforms v1 5/6] Platform/ARM: Juno: Remove Serial port SSDT Sami Mujawar
2021-01-22 13:29 ` [PATCH edk2-platforms v1 6/6] Platform/ARM: FVP: Remove Serial port description from DSDT Sami Mujawar
2021-01-25 12:56 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125125610.GB1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox