From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.groups.io with SMTP id smtpd.web10.36119.1611579374278648631 for ; Mon, 25 Jan 2021 04:56:14 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=WN1AimoY; spf=pass (domain: nuviainc.com, ip: 209.85.221.52, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f52.google.com with SMTP id m1so11657112wrq.12 for ; Mon, 25 Jan 2021 04:56:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yycDswtT0ECLWiocWuq+AXcTkLTumyhAWy5MJP0oFVc=; b=WN1AimoY3XGNezuDKsMeHRjzxE/BJEnPr01jvqmBtH8+wNYi7aHGvDQMUmT7cUAdqR dwf67z79fPvJtNsBiE7VYTkKvBARGDw9P8jBIdDf+ldoxvW51V0Q0Thj+Z+NzJIdHQwB wip3+y9LxfhxWLP8ufu5Of515WCqDFycWjriwtO7kp1BP6JkeCLdcj81OMcpqZvvZEdi i/dwGOXwvXe+3zekyDYN8uoE5iCW6wE55ZB+Qw7pYdlE+4EfGbuggWw5rOTqspnKUa6i tF4iX+3Y7W7C1xLsM7JjWw6my/s12tGGcal21iERy99L/+FZgF8A5sofLxKUQqA3Vgfk bSXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yycDswtT0ECLWiocWuq+AXcTkLTumyhAWy5MJP0oFVc=; b=XPjyMwqs+Jjk2VuIjb16d2c+XomqFSkS6w6hGfv7NVC6Icl3iqC9Flryz10tTRis7K fVlboXuj9wBt8kANfXhYG2QgcTPBTFxjBQdMhf15oGuYezbtHoAt5+mNqAXYox/+LUXc 3VQcGuecO9UzaSK4JBepRYrpMz7RJyDeqLTXp8wjx5rTmxBJFMpKKR4gJHQcTdD4A7g1 lM6Im78MOO+0SH2UBVIb+8CPaEpDqUCSSHAJ3DHUGo16yZ8qXrkSSTjiWmkyy4N5kIo2 mNXhwNOkknazQDzwKdyuZVn8fHQhSXCr9GEsLbmEF5CIdsjuKG5ToabS1rYOFDUlp4zA ikQA== X-Gm-Message-State: AOAM533JX1bMNcirsJXe1n/5J4OL1GUKBObsUQzYExpH2DzDhGQ/zF8Z iC6EPP0+T6AN+hxONOepSaXpig== X-Google-Smtp-Source: ABdhPJyWOFx/doAjVE2y2w2PWE1t2cdJGuFSViGrQWZcMv7I1KuDHAa3xH5yI0SlOM4xpqHmFaAu3A== X-Received: by 2002:adf:9b92:: with SMTP id d18mr866421wrc.170.1611579372704; Mon, 25 Jan 2021 04:56:12 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id b132sm21144469wmh.21.2021.01.25.04.56.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 04:56:12 -0800 (PST) Date: Mon, 25 Jan 2021 12:56:10 +0000 From: "Leif Lindholm" To: Sami Mujawar Cc: devel@edk2.groups.io, ard.biesheuvel@arm.com, thomas.abraham@arm.com, Matteo.Carlini@arm.com, Ben.Adderson@arm.com, nd@arm.com Subject: Re: [PATCH edk2-platforms v1 0/6] Fix platform support for dynamic tables framework Message-ID: <20210125125610.GB1664@vanye> References: <20210122132935.22484-1-sami.mujawar@arm.com> MIME-Version: 1.0 In-Reply-To: <20210122132935.22484-1-sami.mujawar@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Sami, On Fri, Jan 22, 2021 at 13:29:29 +0000, Sami Mujawar wrote: > This patch series fixes the following issues for FVP & Juno platform > when Dynamic Tables Framework is enabled. > - Remove the usage of function macros as this does not comply with > the edk2 coding standard. > - Fix serial port usage on FVP. > - Remove serial port description from SSDT and DSDT as this is now > generated by Dynamic AML. > > This series also includes a patch to remove PL050 KMI support on > Juno. > > The changes can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/1608_fix_config_mgr_handlers_v1 > > Sami Mujawar (6): > Platform/ARM: FVP: Remove usage of function macros > Platform/ARM: Juno: Remove usage of function macros > Platform/ARM: FVP: Fix serial port usage > Platform/ARM: Juno: Remove PL050 KMI description from DSDT > Platform/ARM: Juno: Remove Serial port SSDT > Platform/ARM: FVP: Remove Serial port description from DSDT For the series: Reviewed-by: Leif Lindholm Pushed as c6d565eddf6f..fcf693c9e8d6. Many thanks for quick response time. > > Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 16 +- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl | 16 +- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtUart.asl | 42 -- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 455 ++++++++++++++------ > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 107 +---- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 3 +- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 11 +- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc | 19 - > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl | 22 +- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 347 ++++++++++----- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 73 +--- > 11 files changed, 615 insertions(+), 496 deletions(-) > delete mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtUart.asl > delete mode 100644 Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManager.dsc.inc > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >