From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.groups.io with SMTP id smtpd.web11.291.1611597114354455699 for ; Mon, 25 Jan 2021 09:51:54 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=TLA5S2hD; spf=pass (domain: nuviainc.com, ip: 209.85.221.45, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f45.google.com with SMTP id c12so13878310wrc.7 for ; Mon, 25 Jan 2021 09:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sJqBFleaItZBSquv2JX7mVPHps0M0QmQ8MfNshwOyFQ=; b=TLA5S2hDN10rtHw/W0EW4XIRFQNuDip2/0nwWf1jK3QouS65LXEa6Msjm2BbKwwXhV +7c+1HYiyMHmo+uFjQ4WlM41O+XrVY2DrzKBAISa9cby/Sy2j7qFemjQ9W5bfOySSb9Q yyCiSTIKvTLLiXQX7Vh408KHr/VSf/E64bCzWZAmNKcbjEWGgAIrCpug4CspO9LCoJz/ XHckAQB21fDwLqvGXEzB6Q71Gu2v9+gKwCW2JQbmbyw3wzI2AaOBaYExeL1oB8vIsNTm YKV/5+LNmJmlaEfZ0DdIgy0INLrkBmvUre5MspFqns5oWEAeDA6XwdN+retl2xAdoKUb r4Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sJqBFleaItZBSquv2JX7mVPHps0M0QmQ8MfNshwOyFQ=; b=jC99xpg3WGeyLJSkpOZhWwIYTl4DCbACu0iY0FjExwuDXwxZpJKQhbEZAfIbOZP5L8 Q2uzRrAn+WtcHxB00M2vniRBidEnYtmg1DVH/dbGaHFA4dTY7qg9yWr63l9AFMolzju5 r2T/clwBcQ0YbkSIDNWisHvoyG9ABW3URLHQTT1kVDuOtR1XF66O+AeKqSKPGvwVvl0N 1PrlcnQv6mcXUhTY2jjYxeUxS9OWYZ0sQbWuHRyJJqwD8G1aDOeyGVvqZ66wUEEN8wBS NilwYdmiB8ts7zIIMWt1qwkcSyvYdyd6bJeEj1mdgCggHPqatOe4aawSpq3yzahzVJzv pOvA== X-Gm-Message-State: AOAM531C+Wz7UOm0wEdGmOkIAw2jt2lUJDpC1LcEOdjJDn/LDHg5QT+4 F/c50HalMOHRZHo95iGKJ8pqnQ== X-Google-Smtp-Source: ABdhPJyOKPCAplQGd2mcNWrzvybeNZ6ArUCprqbWPc5WdvkpYyk6N3oPAG79+8snz8/tsgCCKNkZ7g== X-Received: by 2002:adf:e9cf:: with SMTP id l15mr2226650wrn.317.1611597112995; Mon, 25 Jan 2021 09:51:52 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id h1sm20480186wrr.73.2021.01.25.09.51.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Jan 2021 09:51:52 -0800 (PST) Date: Mon, 25 Jan 2021 17:51:50 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel , nd@arm.com, Sami Mujawar , Liming Gao , Michael D Kinney , Zhiguang Liu Subject: Re: [PATCH v6 13/22] ArmPkg: Add Universal/Smbios/OemMiscLibNull Message-ID: <20210125175150.GD1664@vanye> References: <20210114163628.31952-1-rebecca@nuviainc.com> <20210114163628.31952-14-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210114163628.31952-14-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jan 14, 2021 at 09:36:19 -0700, Rebecca Cran wrote: > Add a Null implementation of OemMiscLib. > > OemMiscLib provides functions that platforms implement to fill in > SMBIOS information for the SmbiosMiscDxe and ProcessSubClassDxe drivers. > > Signed-off-by: Rebecca Cran Acked-by: Leif Lindholm > --- > ArmPkg/ArmPkg.dsc | 2 + > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 31 +++++ > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 143 ++++++++++++++++++++ > 3 files changed, 176 insertions(+) > > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > index 48059cf38ed3..0f77a6da4483 100644 > --- a/ArmPkg/ArmPkg.dsc > +++ b/ArmPkg/ArmPkg.dsc > @@ -84,6 +84,8 @@ [LibraryClasses.common] > > ArmMtlLib|ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf > > + OemMiscLib|ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > + > [LibraryClasses.common.PEIM] > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > new file mode 100644 > index 000000000000..b21eeade64b5 > --- /dev/null > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > @@ -0,0 +1,31 @@ > +#/** @file > +# OemMiscLib.inf > +# > +# Copyright (c) 2021, NUVIA Inc. All rights reserved. > +# Copyright (c) 2018, Hisilicon Limited. All rights reserved. > +# Copyright (c) 2018, Linaro Limited. All rights reserved. > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > +#**/ > + > +[Defines] > + INF_VERSION = 1.29 > + BASE_NAME = OemMiscLibNull > + FILE_GUID = e80b8e6b-fffb-4c39-b433-41de67c9d7b8 > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = OemMiscLib > + > +[Sources.common] > + OemMiscLib.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + EmbeddedPkg/EmbeddedPkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + > +[LibraryClasses] > + BaseMemoryLib > + > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > new file mode 100644 > index 000000000000..8233904647e5 > --- /dev/null > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > @@ -0,0 +1,143 @@ > +/** @file > +* OemMiscLib.c > +* > +* Copyright (c) 2021, NUVIA Inc. All rights reserved. > +* Copyright (c) 2018, Hisilicon Limited. All rights reserved. > +* Copyright (c) 2018, Linaro Limited. All rights reserved. > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > +* > +**/ > + > +#include > +#include > +#include > + > +#include > + > + > +/** Gets the CPU frequency of the specified processor. > + > + @param ProcessorIndex Index of the processor to get the frequency for. > + > + @return CPU frequency in Hz > +**/ > +EFIAPI > +UINTN > +OemGetCpuFreq ( > + IN UINT8 ProcessorIndex > + ) > +{ > + ASSERT (FALSE); > + return 0; > +} > + > +/** Gets information about the specified processor and stores it in > + the structures provided. > + > + @param ProcessorIndex Index of the processor to get the information for. > + @param ProcessorStatus Processor status. > + @param ProcessorCharacteristics Processor characteritics. > + @param MiscProcessorData Miscellaneous processor information. > + > + @return TRUE on success, FALSE on failure. > +**/ > +EFIAPI > +BOOLEAN > +OemGetProcessorInformation ( > + IN UINTN ProcessorIndex, > + IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus, > + IN OUT PROCESSOR_CHARACTERISTIC_FLAGS *ProcessorCharacteristics, > + IN OUT OEM_MISC_PROCESSOR_DATA *MiscProcessorData > + ) > +{ > + ASSERT (FALSE); > + return TRUE; > +} > + > +/** Gets information about the cache at the specified cache level. > + > + @param ProcessorIndex The processor to get information for. > + @param CacheLevel The cache level to get information for. > + @param InstructionOrUnifiedCache Whether the cache is instruction or > + unified, not data. > + @param SmbiosCacheTable The SMBIOS Type7 cache information structure. > + > + @return TRUE on success, FALSE on failure. > +**/ > +EFIAPI > +BOOLEAN > +OemGetCacheInformation ( > + IN UINT8 ProcessorIndex, > + IN UINT8 CacheLevel, > + IN BOOLEAN InstructionOrUnifiedCache, > + IN OUT SMBIOS_TABLE_TYPE7 *SmbiosCacheTable > + ) > +{ > + ASSERT (FALSE); > + return TRUE; > +} > + > +/** Gets the maximum number of sockets supported by the platform. > + > + @return The maximum number of sockets. > +**/ > +EFIAPI > +UINT8 > +OemGetProcessorMaxSockets ( > + VOID > + ) > +{ > + ASSERT (FALSE); > + return 1; > +} > + > +/** Gets the type of chassis for the system. > + > + @param ChassisType The type of the chassis. > + > + @retval EFI_SUCCESS The chassis type was fetched successfully. > +**/ > +EFI_STATUS > +EFIAPI > +OemGetChassisType ( > + UINT8 *ChassisType > + ) > +{ > + ASSERT (FALSE); > + *ChassisType = MiscChassisTypeUnknown; > + return EFI_SUCCESS; > +} > + > +/** Returns whether the specified processor is present or not. > + > + @param ProcessIndex The processor index to check. > + > + @return TRUE is the processor is present, FALSE otherwise. > +**/ > +EFIAPI > +BOOLEAN > +OemIsSocketPresent ( > + IN UINTN ProcessorIndex > + ) > +{ > + ASSERT (FALSE); > + return FALSE; > +} > + > +/** Updates the HII string for the specified field. > + > + @param mHiiHandle The HII handle. > + @param TokenToUpdate The string to update. > + @param Offset The field to get information about. > +**/ > +EFIAPI > +VOID > +OemUpdateSmbiosInfo ( > + IN EFI_HII_HANDLE mHiiHandle, > + IN EFI_STRING_ID TokenToUpdate, > + IN OEM_MISC_SMBIOS_HII_STRING_FIELD Offset > + ) > +{ > + ASSERT (FALSE); > +} > -- > 2.26.2 >