public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Vikas Singh <vikas.singh@puresoftware.com>
Cc: devel@edk2.groups.io, Sami Mujawar <sami.mujawar@arm.com>,
	meenakshi.aggarwal@nxp.com, Paul Yang <paul.yang@arm.com>,
	Augustine Philips <augustine.philips@arm.com>,
	samer.el-haj-mahmoud@arm.com, Varun Sethi <v.sethi@nxp.com>,
	Arokia Samy <arokia.samy@puresoftware.com>,
	Kuldip Dwivedi <kuldip.dwivedi@puresoftware.com>,
	ard.biesheuvel@arm.com, Vikas Singh <vikas.singh@nxp.com>
Subject: Re: [PATCH v0] Platform/NXP: Add Dynamic Acpi for layerscape platforms
Date: Tue, 26 Jan 2021 11:19:46 +0000	[thread overview]
Message-ID: <20210126111946.GN1664@vanye> (raw)
In-Reply-To: <CADvVLtVSnSpyL9r-FnKLEp8=4fQi5-1ZiM=6gDNy4faBAtL4ng@mail.gmail.com>

Hi Vikas,

On Tue, Jan 19, 2021 at 10:11:43 +0530, Vikas Singh wrote:
> > > > > +/** A helper macro for returning configuration manager objects
> > > > > +*/
> > > > > +#define HANDLE_CM_OBJECT(ObjId, CmObjectId, Object, ObjectCount)      \
> > > > > +  case ObjId: {                                                       \
> > > > > +    CmObject->ObjectId = CmObjectId;                                  \
> > > > > +    CmObject->Size = sizeof (Object);                                 \
> > > > > +    CmObject->Data = (VOID*)&Object;                                  \
> > > > > +    CmObject->Count = ObjectCount;                                    \
> > > > > +    DEBUG ((                                                          \
> > > > > +      DEBUG_INFO,                                                     \
> > > > > +      #CmObjectId ": Ptr = 0x%p, Size = %d, Count = %d\n",            \
> > > > > +      CmObject->Data,                                                 \
> > > > > +      CmObject->Size,                                                 \
> > > > > +      CmObject->Count                                                 \
> > > > > +      ));                                                             \
> > > > > +    break;                                                            \
> > > > > +  }
> > > >
> > > > This is code obfuscation. Please don't invent your own programming
> > > > languages. In C, the case, the start bracket, the break and the end
> > > > bracket always go inline.
> > > > The rest would be better as a static helper function than a macro.
> > > >
> > > Leif, changes are in accordance with :
> > > https://raw.githubusercontent.com/tianocore-docs/Docs/master/Specifications/CCS_2_1_Draft.pdf
> >
> > Do you mean 5.5.2.1:
> > Functional macros are generally discouraged.
> > ?
> 
> Leif + Sami, I was referring section 5.7.3.7, since you commented on
> switch case & break statement.
> However keeping section 5.5.2.1 in consideration, I have done few
> changes and shared updated V1 series.
> Could you please have a look on it and revert, if in case you have any concerns.

I have not seen any update?

Please have a look at Sami's updates to the ARM platform code, which I
merged yeaterday.

Best Regards,

Leif


  reply	other threads:[~2021-01-26 11:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29  7:25 [PATCH v0] Dynamic ACPI framework for fsl layerscape platforms Vikas Singh
2020-12-29  7:25 ` [PATCH v0] Platform/NXP: Add Dynamic Acpi for " Vikas Singh
2021-01-10  3:26   ` Leif Lindholm
2021-01-16  4:45     ` Vikas Singh
2021-01-18 16:55       ` Leif Lindholm
2021-01-19  4:41         ` Vikas Singh
2021-01-26 11:19           ` Leif Lindholm [this message]
2021-01-27  6:51             ` Vikas Singh
2021-02-10  7:12               ` Vikas Singh
2021-01-19 14:37         ` [edk2-devel] " Sami Mujawar
2021-01-10  2:30 ` [PATCH v0] Dynamic ACPI framework for fsl " Leif Lindholm
2021-01-16  4:08   ` Vikas Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210126111946.GN1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox