* [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident
@ 2021-01-29 4:19 Abner Chang
2021-02-01 1:54 ` 回复: [edk2-devel] " gaoliming
2021-02-18 3:33 ` Nickle Wang
0 siblings, 2 replies; 4+ messages in thread
From: Abner Chang @ 2021-01-29 4:19 UTC (permalink / raw)
To: devel; +Cc: Leif Lindholm, Nickle Wang, Michael D Kinney
json_string_value() in JsonValueGetAsciiString () is removed by a accident
when clean up the code.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Nickle Wang <nickle.wang@hpe.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
RedfishPkg/Library/JsonLib/JsonLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c b/RedfishPkg/Library/JsonLib/JsonLib.c
index 34ff381aee..d729e3ec27 100644
--- a/RedfishPkg/Library/JsonLib/JsonLib.c
+++ b/RedfishPkg/Library/JsonLib/JsonLib.c
@@ -430,10 +430,10 @@ JsonValueGetAsciiString (
IN EDKII_JSON_VALUE Json
)
{
- CHAR8 *AsciiStr;
+ CONST CHAR8 *AsciiStr;
UINTN Index;
- AsciiStr = (CHAR8 *) ((json_t *) Json);
+ AsciiStr = json_string_value ((json_t *) Json);
if (AsciiStr == NULL) {
return NULL;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* 回复: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident
2021-01-29 4:19 [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident Abner Chang
@ 2021-02-01 1:54 ` gaoliming
2021-02-01 2:59 ` Abner Chang
2021-02-18 3:33 ` Nickle Wang
1 sibling, 1 reply; 4+ messages in thread
From: gaoliming @ 2021-02-01 1:54 UTC (permalink / raw)
To: devel, abner.chang
Cc: 'Leif Lindholm', 'Nickle Wang',
'Michael D Kinney'
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Besides, does CI enable in RedfishPkg?
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+70885+4905953+8761045@groups.io
> <bounce+27952+70885+4905953+8761045@groups.io> 代表 Abner Chang
> 发送时间: 2021年1月29日 12:20
> 收件人: devel@edk2.groups.io
> 抄送: Leif Lindholm <leif@nuviainc.com>; Nickle Wang
> <nickle.wang@hpe.com>; Michael D Kinney <michael.d.kinney@intel.com>
> 主题: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing
> code by a accident
>
> json_string_value() in JsonValueGetAsciiString () is removed by a accident
> when clean up the code.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> RedfishPkg/Library/JsonLib/JsonLib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c
> b/RedfishPkg/Library/JsonLib/JsonLib.c
> index 34ff381aee..d729e3ec27 100644
> --- a/RedfishPkg/Library/JsonLib/JsonLib.c
> +++ b/RedfishPkg/Library/JsonLib/JsonLib.c
> @@ -430,10 +430,10 @@ JsonValueGetAsciiString (
> IN EDKII_JSON_VALUE Json
> )
> {
> - CHAR8 *AsciiStr;
> + CONST CHAR8 *AsciiStr;
> UINTN Index;
>
> - AsciiStr = (CHAR8 *) ((json_t *) Json);
> + AsciiStr = json_string_value ((json_t *) Json);
> if (AsciiStr == NULL) {
> return NULL;
> }
> --
> 2.17.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident
2021-02-01 1:54 ` 回复: [edk2-devel] " gaoliming
@ 2021-02-01 2:59 ` Abner Chang
0 siblings, 0 replies; 4+ messages in thread
From: Abner Chang @ 2021-02-01 2:59 UTC (permalink / raw)
To: devel@edk2.groups.io, gaoliming@byosoft.com.cn
Cc: 'Leif Lindholm', Wang, Nickle (HPS SW),
'Michael D Kinney'
Yes, CI is enabled on RedfishPkg.
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> gaoliming
> Sent: Monday, February 1, 2021 9:54 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> <abner.chang@hpe.com>
> Cc: 'Leif Lindholm' <leif@nuviainc.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; 'Michael D Kinney' <michael.d.kinney@intel.com>
> Subject: 回复: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of
> removing code by a accident
>
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
>
> Besides, does CI enable in RedfishPkg?
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: bounce+27952+70885+4905953+8761045@groups.io
> > <bounce+27952+70885+4905953+8761045@groups.io> 代表 Abner Chang
> > 发送时间: 2021年1月29日 12:20
> > 收件人: devel@edk2.groups.io
> > 抄送: Leif Lindholm <leif@nuviainc.com>; Nickle Wang
> > <nickle.wang@hpe.com>; Michael D Kinney
> <michael.d.kinney@intel.com>
> > 主题: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of
> > removing code by a accident
> >
> > json_string_value() in JsonValueGetAsciiString () is removed by a
> > accident when clean up the code.
> >
> > Signed-off-by: Abner Chang <abner.chang@hpe.com>
> >
> > Cc: Leif Lindholm <leif@nuviainc.com>
> > Cc: Nickle Wang <nickle.wang@hpe.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> > RedfishPkg/Library/JsonLib/JsonLib.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c
> > b/RedfishPkg/Library/JsonLib/JsonLib.c
> > index 34ff381aee..d729e3ec27 100644
> > --- a/RedfishPkg/Library/JsonLib/JsonLib.c
> > +++ b/RedfishPkg/Library/JsonLib/JsonLib.c
> > @@ -430,10 +430,10 @@ JsonValueGetAsciiString (
> > IN EDKII_JSON_VALUE Json
> > )
> > {
> > - CHAR8 *AsciiStr;
> > + CONST CHAR8 *AsciiStr;
> > UINTN Index;
> >
> > - AsciiStr = (CHAR8 *) ((json_t *) Json);
> > + AsciiStr = json_string_value ((json_t *) Json);
> > if (AsciiStr == NULL) {
> > return NULL;
> > }
> > --
> > 2.17.1
> >
> >
> >
> >
> >
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident
2021-01-29 4:19 [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident Abner Chang
2021-02-01 1:54 ` 回复: [edk2-devel] " gaoliming
@ 2021-02-18 3:33 ` Nickle Wang
1 sibling, 0 replies; 4+ messages in thread
From: Nickle Wang @ 2021-02-18 3:33 UTC (permalink / raw)
To: Chang, Abner (HPS SW/FW Technologist), devel@edk2.groups.io
Cc: Leif Lindholm, Michael D Kinney
Reviewed-by: Nickle Wang <nickle.wang@hpe.com>
Thanks,
Nickle
> -----Original Message-----
> From: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
> Sent: Friday, January 29, 2021 12:20 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm <leif@nuviainc.com>; Wang, Nickle (HPS SW)
> <nickle.wang@hpe.com>; Michael D Kinney <michael.d.kinney@intel.com>
> Subject: [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a
> accident
>
> json_string_value() in JsonValueGetAsciiString () is removed by a accident
> when clean up the code.
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Nickle Wang <nickle.wang@hpe.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
> RedfishPkg/Library/JsonLib/JsonLib.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/RedfishPkg/Library/JsonLib/JsonLib.c
> b/RedfishPkg/Library/JsonLib/JsonLib.c
> index 34ff381aee..d729e3ec27 100644
> --- a/RedfishPkg/Library/JsonLib/JsonLib.c
> +++ b/RedfishPkg/Library/JsonLib/JsonLib.c
> @@ -430,10 +430,10 @@ JsonValueGetAsciiString (
> IN EDKII_JSON_VALUE Json
> )
> {
> - CHAR8 *AsciiStr;
> + CONST CHAR8 *AsciiStr;
> UINTN Index;
>
> - AsciiStr = (CHAR8 *) ((json_t *) Json);
> + AsciiStr = json_string_value ((json_t *) Json);
> if (AsciiStr == NULL) {
> return NULL;
> }
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-18 3:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-29 4:19 [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident Abner Chang
2021-02-01 1:54 ` 回复: [edk2-devel] " gaoliming
2021-02-01 2:59 ` Abner Chang
2021-02-18 3:33 ` Nickle Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox