public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>
To: devel@edk2.groups.io, sami.mujawar@arm.com
Cc: ard+tianocore@kernel.org, sughosh.ganu@linaro.org,
	leif@nuviainc.com, Ilias Apalodimas <ilias.apalodimas@linaro.org>
Subject: [PATCH 0/2 v4] Add support for running StandaloneMm as OP-TEE TA
Date: Wed,  3 Feb 2021 12:16:24 +0200	[thread overview]
Message-ID: <20210203101626.1200943-1-ilias.apalodimas@linaro.org> (raw)

Hi, 

This is v4 of [1] 

Changes since V3:
 - Coding style fixes proposed by Sami
 - Fixed all reported PatchCheck errors
 - Added overflow checks on the base aaddress allocated for EFI variables.
   The size of the partition is user defined (via Pcd's) and the memory layout
   and allocation address depends on OP-TEE. So let's make sure we won't overflow
   when calculating the 3 partitions needed for FTW
 - Switched some PcdGet/Set32 to 64 to accomodate 64-bit addressing
 - Removed some duplicate entries in Platform/StMMRpmb/PlatformStandaloneMm.dsc
 - Added reviewed-by tags on patch 2/2

Changes since V2:
 - Allocate a dynamic number of pages based on the Pcd values instead
   of a static number
 - Clean up unused structs in header file
 - Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=0

Changes since V1:
Some enhancements made by Ilias to the Optee Rpmb driver

Ilias Apalodimas (2):
  Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver
  StMMRpmb: Add support for building StandaloneMm image for OP-TEE

 Drivers/OpTeeRpmb/FixupPcd.c               |  84 +++
 Drivers/OpTeeRpmb/FixupPcd.inf             |  44 ++
 Drivers/OpTeeRpmb/OpTeeRpmbFv.inf          |  58 ++
 Drivers/OpTeeRpmb/OpTeeRpmbFvb.c           | 822 +++++++++++++++++++++
 Drivers/OpTeeRpmb/OpTeeRpmbFvb.h           |  52 ++
 Platform/StMMRpmb/PlatformStandaloneMm.dsc | 165 +++++
 Platform/StMMRpmb/PlatformStandaloneMm.fdf | 111 +++
 7 files changed, 1336 insertions(+)
 create mode 100644 Drivers/OpTeeRpmb/FixupPcd.c
 create mode 100644 Drivers/OpTeeRpmb/FixupPcd.inf
 create mode 100644 Drivers/OpTeeRpmb/OpTeeRpmbFv.inf
 create mode 100644 Drivers/OpTeeRpmb/OpTeeRpmbFvb.c
 create mode 100644 Drivers/OpTeeRpmb/OpTeeRpmbFvb.h
 create mode 100644 Platform/StMMRpmb/PlatformStandaloneMm.dsc
 create mode 100644 Platform/StMMRpmb/PlatformStandaloneMm.fdf

-- 
2.30.0

Sami I tried to run Ecc but on the current EDK2 upstream I am getting:
File "/usr/lib/python3/dist-packages/antlr4/BufferedTokenStream.py", line 287, in getText
if start < 0 or stop < 0 or stop < start:
TypeError: '<' not supported between instances of 'tuple' and 'int'
Am I doing something wrong or Ecc is broken in current upstream?



             reply	other threads:[~2021-02-03 10:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-03 10:16 Ilias Apalodimas [this message]
2021-02-03 10:16 ` [PATCH 1/2 v4] Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver Ilias Apalodimas
2021-02-12 13:11   ` Sami Mujawar
2021-02-12 13:37     ` Ilias Apalodimas
2021-02-12 15:28       ` Sami Mujawar
2021-02-12 15:35         ` Ilias Apalodimas
2021-02-03 10:16 ` [PATCH 2/2 v4] StMMRpmb: Add support for building StandaloneMm image for OP-TEE Ilias Apalodimas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210203101626.1200943-1-ilias.apalodimas@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox