From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.groups.io with SMTP id smtpd.web09.7411.1612347391393845926 for ; Wed, 03 Feb 2021 02:16:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=rdTRbiRm; spf=pass (domain: linaro.org, ip: 209.85.221.42, mailfrom: ilias.apalodimas@linaro.org) Received: by mail-wr1-f42.google.com with SMTP id q7so23471676wre.13 for ; Wed, 03 Feb 2021 02:16:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=URfzNqYssdplbLaUdbGpPazHgKYZnsCa4SKjD/Vl38o=; b=rdTRbiRmNEteT6sBwlAeEfjDXA/BsJ5lqSEisP8geQ9x7U5gBhwEgyM6/5RGhrpanM bp4gxt0TPotLkVPO0wadkHfNiIaH+oIBrPIJuzMEnj+4F2lVNRwzOsOeZsdtYhPNLclp QPjRs6FvAPLIjSUMVPM+UQXurhkpTmdnVD6OFLKBOhvb1ngj7dD0kPByWhsXarO7ng0I GwtysumZfeKwy7k3bD2P7FGb6aZBY5jLZ6lnnKLk3wBey84Eb2bTK0wCj6qQ3cJZxNU5 O4M5UGWaxSKp2l9fOFndIKdGk19bm95WfuIiLFSvnauia7qS5waGIZi1ar7nIZu2dR/R aXOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=URfzNqYssdplbLaUdbGpPazHgKYZnsCa4SKjD/Vl38o=; b=fbiG3gSsQVu4HSYCRGXLeYRf7cefzbHNsY9jBFI1nguxlFutNXiyQ+D1yhyBRBaUkn rwo8SK8pPsww7GI6/7tpXeCNrEimUsyM55Rcw3g0rPO9vBM1HL2WGyMWgOi0EJFXFxyo 2p56LJnUyDl+YU4E0AXhcVIMXT8b5ts+i5G747Tqtsx/NXWkJrJWpZjKejgokao7rTqN JmzciO47tZgOp6U5LTxmGMqzwf9m4+mCi240O1PLmUg3HFE/b7TfpAHv7yMEq4kXpSg1 kU9Bx28+26esnT4GGhOZRdbCp+7rCDfMvO2Lt7wNsXnMh7gRojgIyVYy+IQy4QZe2V9P NcoQ== X-Gm-Message-State: AOAM530Vad6JgOA0cImwO89sJ+NMWVEbDPPRosF7uUt3bMvHkTeE1A9r TD7u/RcT6ACghhOXtfIMNPucB4zQ47hrHpiA X-Google-Smtp-Source: ABdhPJwtjMcZ6UIeIrucmFyAhEH+6LsKnFnZO7AJiVK2gsCOMdjUHAw6xpQ40daM/ZRQYWidoGuIVw== X-Received: by 2002:a5d:5411:: with SMTP id g17mr2660542wrv.54.1612347389804; Wed, 03 Feb 2021 02:16:29 -0800 (PST) Return-Path: Received: from apalos.home ([2a02:587:464c:6106:2e56:dcff:fe9a:8f06]) by smtp.gmail.com with ESMTPSA id r13sm2362906wmh.9.2021.02.03.02.16.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 02:16:29 -0800 (PST) From: "Ilias Apalodimas" To: devel@edk2.groups.io, sami.mujawar@arm.com Cc: ard+tianocore@kernel.org, sughosh.ganu@linaro.org, leif@nuviainc.com, Ilias Apalodimas Subject: [PATCH 0/2 v4] Add support for running StandaloneMm as OP-TEE TA Date: Wed, 3 Feb 2021 12:16:24 +0200 Message-Id: <20210203101626.1200943-1-ilias.apalodimas@linaro.org> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, This is v4 of [1] Changes since V3: - Coding style fixes proposed by Sami - Fixed all reported PatchCheck errors - Added overflow checks on the base aaddress allocated for EFI variables. The size of the partition is user defined (via Pcd's) and the memory layout and allocation address depends on OP-TEE. So let's make sure we won't overflow when calculating the 3 partitions needed for FTW - Switched some PcdGet/Set32 to 64 to accomodate 64-bit addressing - Removed some duplicate entries in Platform/StMMRpmb/PlatformStandaloneMm.dsc - Added reviewed-by tags on patch 2/2 Changes since V2: - Allocate a dynamic number of pages based on the Pcd values instead of a static number - Clean up unused structs in header file - Added checks in OpTeeRpmbFvbGetBlockSize and handle NumLba=0 Changes since V1: Some enhancements made by Ilias to the Optee Rpmb driver Ilias Apalodimas (2): Drivers/OpTeeRpmb: Add an OP-TEE backed RPMB driver StMMRpmb: Add support for building StandaloneMm image for OP-TEE Drivers/OpTeeRpmb/FixupPcd.c | 84 +++ Drivers/OpTeeRpmb/FixupPcd.inf | 44 ++ Drivers/OpTeeRpmb/OpTeeRpmbFv.inf | 58 ++ Drivers/OpTeeRpmb/OpTeeRpmbFvb.c | 822 +++++++++++++++++++++ Drivers/OpTeeRpmb/OpTeeRpmbFvb.h | 52 ++ Platform/StMMRpmb/PlatformStandaloneMm.dsc | 165 +++++ Platform/StMMRpmb/PlatformStandaloneMm.fdf | 111 +++ 7 files changed, 1336 insertions(+) create mode 100644 Drivers/OpTeeRpmb/FixupPcd.c create mode 100644 Drivers/OpTeeRpmb/FixupPcd.inf create mode 100644 Drivers/OpTeeRpmb/OpTeeRpmbFv.inf create mode 100644 Drivers/OpTeeRpmb/OpTeeRpmbFvb.c create mode 100644 Drivers/OpTeeRpmb/OpTeeRpmbFvb.h create mode 100644 Platform/StMMRpmb/PlatformStandaloneMm.dsc create mode 100644 Platform/StMMRpmb/PlatformStandaloneMm.fdf -- 2.30.0 Sami I tried to run Ecc but on the current EDK2 upstream I am getting: File "/usr/lib/python3/dist-packages/antlr4/BufferedTokenStream.py", line 287, in getText if start < 0 or stop < 0 or stop < start: TypeError: '<' not supported between instances of 'tuple' and 'int' Am I doing something wrong or Ecc is broken in current upstream?