From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.33497.1612782257402380620 for ; Mon, 08 Feb 2021 03:04:17 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0E2BB31B; Mon, 8 Feb 2021 03:04:07 -0800 (PST) Received: from e120189.arm.com (unknown [10.57.13.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 40EB13F719; Mon, 8 Feb 2021 03:04:06 -0800 (PST) From: "PierreGondois" To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com Cc: sami.mujawar@arm.com Subject: [PATCH v2 00/26] Fix Ecc reported errors in ArmPkg Date: Mon, 8 Feb 2021 11:03:20 +0000 Message-Id: <20210208110346.31211-1-Pierre.Gondois@arm.com> X-Mailer: git-send-email 2.17.1 From: Pierre Gondois The Ecc tools available in the BaseTools package checks for good practice coding standards. Some errors reported while running Ecc on the ArmPkg require modifications. The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v2 v2: For ArmPkg: Fix Ecc error 8001 in Chipset - Only use one trailing underscore for the ARM_CORTEX_A5x_H__ include guard. [Sami] - 2 patches had the same name and fixed the same Ecc error in V1. They are merged in V2. [Pierre] Pierre Gondois (26): ArmPkg: Fix Ecc error 8001 in Chipset ArmPkg: Fix Ecc error 8001 in SemihostLib ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib ArmPkg: Fix Ecc error 9005 in CpuDxe ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib ArmPkg: Fix Ecc error 10014 in ArmScmiDxe ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe ArmPkg: Fix Ecc error 10014 in SemihostLib ArmPkg: Remove ArmGic/ArmGicSecLib.c ArmPkg: Fix Ecc error 5003 in ArmExceptionLib ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib ArmPkg: Rename include guard in ArmGicLib.h ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE ArmPkg: Fix Ecc error 8005 for SCMI_STATUS ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE ArmPkg/ArmPkg.dsc | 6 +- ArmPkg/Drivers/ArmGic/ArmGicSecLib.c | 58 ------- ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf | 9 +- .../ArmScmiPerformanceProtocolPrivate.h | 4 +- ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 10 +- ArmPkg/Drivers/ArmScmiDxe/ScmiBaseProtocol.c | 24 +-- ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c | 44 ++--- ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 10 +- .../ArmScmiDxe/ScmiPerformanceProtocol.c | 30 ++-- ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h | 48 +++--- ArmPkg/Drivers/CpuDxe/CpuMpCore.c | 4 +- .../GenericWatchdogDxe/GenericWatchdogDxe.inf | 3 +- .../MmCommunicationDxe/MmCommunicate.h | 8 +- .../MmCommunicationDxe/MmCommunication.inf | 3 +- ArmPkg/Include/Chipset/AArch64.h | 12 +- ArmPkg/Include/Chipset/AArch64Mmu.h | 4 +- ArmPkg/Include/Chipset/ArmCortexA5x.h | 8 +- ArmPkg/Include/Chipset/ArmV7.h | 4 +- ArmPkg/Include/Library/ArmGicLib.h | 8 +- ArmPkg/Include/Library/OpteeLib.h | 11 +- ArmPkg/Include/Protocol/ArmScmiBaseProtocol.h | 10 +- .../Include/Protocol/ArmScmiClock2Protocol.h | 6 +- .../Include/Protocol/ArmScmiClockProtocol.h | 32 ++-- .../Protocol/ArmScmiPerformanceProtocol.h | 14 +- .../Library/ArmArchTimerLib/ArmArchTimerLib.c | 12 +- .../ArmDisassemblerLib/ArmDisassembler.c | 159 +++++++++--------- .../ArmDisassemblerLib/ThumbDisassembler.c | 158 ++++++++--------- .../AArch64/AArch64Exception.c | 4 +- .../AArch64/ExceptionSupport.S | 10 +- .../ArmExceptionLib/Arm/ArmException.c | 5 +- ArmPkg/Library/ArmSoftFloatLib/platform.h | 6 + ArmPkg/Library/SemihostLib/SemihostLib.c | 26 +-- ArmPkg/Library/SemihostLib/SemihostLib.inf | 3 +- ArmPkg/Library/SemihostLib/SemihostPrivate.h | 80 ++++----- .../ArmMmuStandaloneMmLib.inf | 4 +- ArmPlatformPkg/PrePeiCore/AArch64/Exception.S | 10 +- 36 files changed, 416 insertions(+), 431 deletions(-) delete mode 100644 ArmPkg/Drivers/ArmGic/ArmGicSecLib.c -- 2.17.1