public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, ardb+tianocore@kernel.org, leif@nuviainc.com
Cc: sami.mujawar@arm.com
Subject: [PATCH v2 25/26] ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT
Date: Mon,  8 Feb 2021 11:03:45 +0000	[thread overview]
Message-ID: <20210208110346.31211-26-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20210208110346.31211-1-Pierre.Gondois@arm.com>

From: Pierre Gondois <Pierre.Gondois@arm.com>

This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v2

 ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c   | 8 ++++----
 ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h | 6 +++---
 ArmPkg/Include/Protocol/ArmScmiClockProtocol.h  | 8 ++++----
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c
index 9cd3a7ed232d..cc223d672028 100644
--- a/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c
+++ b/ArmPkg/Drivers/ArmScmiDxe/ScmiClockProtocol.c
@@ -152,10 +152,10 @@ ClockGetClockAttributes (
   @param[in] This        A pointer to SCMI_CLOCK_PROTOCOL Instance.
   @param[in] ClockId     Identifier for the clock device.

-  @param[out] Format      SCMI_CLOCK_RATE_FORMAT_DISCRETE: Clock device
+  @param[out] Format      ScmiClockRateFormatDiscrete: Clock device
                           supports range of clock rates which are non-linear.

-                          SCMI_CLOCK_RATE_FORMAT_LINEAR: Clock device supports
+                          ScmiClockRateFormatLinear: Clock device supports
                           range of linear clock rates from Min to Max in steps.

   @param[out] TotalRates  Total number of rates.
@@ -236,7 +236,7 @@ ClockDescribeRates (
       *TotalRates = NUM_RATES (DescribeRates->NumRatesFlags)
                     + NUM_REMAIN_RATES (DescribeRates->NumRatesFlags);

-      if (*Format == SCMI_CLOCK_RATE_FORMAT_DISCRETE) {
+      if (*Format == ScmiClockRateFormatDiscrete) {
          RequiredArraySize = (*TotalRates) * sizeof (UINT64);
       } else {
          // We need to return triplet of 64 bit value for each rate
@@ -251,7 +251,7 @@ ClockDescribeRates (

     RateOffset = 0;

-    if (*Format == SCMI_CLOCK_RATE_FORMAT_DISCRETE) {
+    if (*Format == ScmiClockRateFormatDiscrete) {
       for (RateNo = 0; RateNo < NUM_RATES (DescribeRates->NumRatesFlags); RateNo++) {
         Rate = &DescribeRates->Rates[RateOffset++];
         // Non-linear discrete rates.
diff --git a/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h b/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h
index 950141cbd2da..0e26491a62c4 100644
--- a/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h
+++ b/ArmPkg/Include/Protocol/ArmScmiClock2Protocol.h
@@ -1,6 +1,6 @@
 /** @file

-  Copyright (c) 2017-2018, Arm Limited. All rights reserved.
+  Copyright (c) 2017-2021, Arm Limited. All rights reserved.

   SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -89,10 +89,10 @@ EFI_STATUS
   @param[in] This        A pointer to SCMI_CLOCK2_PROTOCOL Instance.
   @param[in] ClockId     Identifier for the clock device.

-  @param[out] Format      SCMI_CLOCK_RATE_FORMAT_DISCRETE: Clock device
+  @param[out] Format      ScmiClockRateFormatDiscrete: Clock device
                           supports range of clock rates which are non-linear.

-                          SCMI_CLOCK_RATE_FORMAT_LINEAR: Clock device supports
+                          ScmiClockRateFormatLinear: Clock device supports
                           range of linear clock rates from Min to Max in steps.

   @param[out] TotalRates  Total number of rates.
diff --git a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h
index cd62f05a58fd..4210a53cf98d 100644
--- a/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h
+++ b/ArmPkg/Include/Protocol/ArmScmiClockProtocol.h
@@ -30,8 +30,8 @@ typedef enum {
 } SCMI_MESSAGE_ID_CLOCK;

 typedef enum {
-  SCMI_CLOCK_RATE_FORMAT_DISCRETE, // Non-linear range.
-  SCMI_CLOCK_RATE_FORMAT_LINEAR    // Linear range.
+  ScmiClockRateFormatDiscrete, // Non-linear range.
+  ScmiClockRateFormatLinear    // Linear range.
 } SCMI_CLOCK_RATE_FORMAT;

 // Clock management protocol version.
@@ -139,10 +139,10 @@ EFI_STATUS
   @param[in] This        A pointer to SCMI_CLOCK_PROTOCOL Instance.
   @param[in] ClockId     Identifier for the clock device.

-  @param[out] Format      SCMI_CLOCK_RATE_FORMAT_DISCRETE: Clock device
+  @param[out] Format      ScmiClockRateFormatDiscrete: Clock device
                           supports range of clock rates which are non-linear.

-                          SCMI_CLOCK_RATE_FORMAT_LINEAR: Clock device supports
+                          ScmiClockRateFormatLinear: Clock device supports
                           range of linear clock rates from Min to Max in steps.

   @param[out] TotalRates  Total number of rates.
--
2.17.1


  parent reply	other threads:[~2021-02-08 11:04 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 11:03 [PATCH v2 00/26] Fix Ecc reported errors in ArmPkg PierreGondois
2021-02-08 11:03 ` [PATCH v2 01/26] ArmPkg: Fix Ecc error 8001 in Chipset PierreGondois
2021-02-22 14:13   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 02/26] ArmPkg: Fix Ecc error 8001 in SemihostLib PierreGondois
2021-02-22 14:14   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 03/26] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib PierreGondois
2021-02-22 14:16   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 04/26] ArmPkg: Fix Ecc error 9005 in CpuDxe PierreGondois
2021-02-22 14:17   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 05/26] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc PierreGondois
2021-02-22 14:24   ` [edk2-devel] " Sami Mujawar
2021-02-23 10:31     ` PierreGondois
2021-02-23 11:15       ` Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 06/26] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib PierreGondois
2021-02-22 14:26   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 07/26] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe PierreGondois
2021-02-22 14:27   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 08/26] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe PierreGondois
2021-02-22 14:28   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 09/26] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe PierreGondois
2021-02-22 14:29   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 10/26] ArmPkg: Fix Ecc error 10014 in SemihostLib PierreGondois
2021-02-22 14:30   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 11/26] ArmPkg: Remove ArmGic/ArmGicSecLib.c PierreGondois
2021-02-22 14:31   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 12/26] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib PierreGondois
2021-02-22 14:33   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 13/26] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe PierreGondois
2021-02-22 14:34   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 14/26] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib PierreGondois
2021-02-22 14:35   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 15/26] ArmPkg: Rename include guard in ArmGicLib.h PierreGondois
2021-02-22 14:37   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 16/26] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE PierreGondois
2021-02-22 14:41   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 17/26] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM PierreGondois
2021-02-22 14:48   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 18/26] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib PierreGondois
2021-02-22 17:26   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 19/26] ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID PierreGondois
2021-02-22 15:37   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 20/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE PierreGondois
2021-02-22 15:38   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 21/26] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS PierreGondois
2021-02-22 15:39   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 22/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID PierreGondois
2021-02-22 15:40   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 23/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE PierreGondois
2021-02-22 15:41   ` [edk2-devel] " Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 24/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK PierreGondois
2021-02-22 15:49   ` [edk2-devel] " Sami Mujawar
2021-02-23  9:05     ` PierreGondois
2021-02-08 11:03 ` PierreGondois [this message]
2021-02-22 15:50   ` [edk2-devel] [PATCH v2 25/26] ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT Sami Mujawar
2021-02-08 11:03 ` [PATCH v2 26/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE PierreGondois
2021-02-22 15:52   ` [edk2-devel] " Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210208110346.31211-26-Pierre.Gondois@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox