From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.groups.io with SMTP id smtpd.web11.11335.1612882697193684350 for ; Tue, 09 Feb 2021 06:58:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=lEEGxtIi; spf=pass (domain: nuviainc.com, ip: 209.85.221.53, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f53.google.com with SMTP id g6so9261838wrs.11 for ; Tue, 09 Feb 2021 06:58:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fyrOe492bGQss0P9YbvPeS0B4OJrAiQvCaZpgY17cNg=; b=lEEGxtIi1CWa+wBOHGuvZHaeUGIdyigmR/2MsWBDn5YBsqCI4cHpNqz9wHB3VyKy5L R9jFFQSxE4phnTNKG7cVUBVv0lOGPXTSk83E2R6qpESHJZ+u1SGXp8KJR4yAjazUuB5y zynY5zGClpZMLu5+agdcz5kmj6yV9Zkkza9qX6dAz7MVI2IxVVFo2AQYpZK+5r+YJAhn wzuypRS5mze9D0IaP3SXQ9mO5+XCl4YaP2T3xVERu5h10bzIWIrK2ko1BVoZcZVqLE6b SZVr0lbo0lyuKbHHriOH4+Qt5AUGGPQKl0XeXUGdzY4BYIYcnYNl1kZA7xkPTq+9mc7S MKow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fyrOe492bGQss0P9YbvPeS0B4OJrAiQvCaZpgY17cNg=; b=bmJ7f+2/uzcw7LTNnV1WjgCkmA2S8gG3UrSmorb6iUuS5UP3ZeX2FiBf6AHSYFI9cH uV85bfYVLhe3FWFpY9Mptza490hwDKi1v2WmmefcqzMm/sWUR67aN1sLDvVyaTBsSH9k Gxm7Bb6S40OGGYih5J+1e/c1/EQxTf8yizUpn0c709PUOgv58rFY7Qd21thIj3NaZImS cSzarYnUbmlxWj1Pc0Sfrxsombi+LS1fc328bgJ/pUujVgkESjIiScNKgBYDXnlPdj+2 CIcjG+dvnd0uz5/wX/DIUZ8qXPgkmU4nY66WOlTDfOXwvlWwoGB4mHVOjhEuEBXsGQ3d LsGQ== X-Gm-Message-State: AOAM532LWbge13kzTAkGG7MF8yBh8SyKh2Z3AACn8b+hVbbXtYKIX2hy lpYpBu4kgy1GUFkBH+CMWbu06w== X-Google-Smtp-Source: ABdhPJwstkferx753Ppu4E4reI6w0aSRQMZieRf2X+RvUXVa6GQau7Ck0s6H3NTadUJfMLS5nOpVOw== X-Received: by 2002:a5d:53c5:: with SMTP id a5mr7050507wrw.263.1612882695837; Tue, 09 Feb 2021 06:58:15 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id h12sm3858728wru.18.2021.02.09.06.58.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 06:58:15 -0800 (PST) Date: Tue, 9 Feb 2021 14:58:13 +0000 From: "Leif Lindholm" To: Heinrich Schuchardt Cc: Daniel Schaefer , devel@edk2.groups.io, Abner Chang , Gilbert Chen , Eric Jin , G Edhaya Chandran , Barton Gao , Samer El-Haj-Mahmoud Subject: Re: [edk2-devel] [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources Message-ID: <20210209145813.GI1664@vanye> References: <20201201161752.23734-1-daniel.schaefer@hpe.com> <20201201161752.23734-3-daniel.schaefer@hpe.com> <20201202120436.GE1664@vanye> <7741f08d-efeb-e959-7118-fb74474e3424@gmx.de> <20210209124219.GG1664@vanye> <5e8de9b9-17cc-65c5-1b47-e3f087f8ce85@gmx.de> MIME-Version: 1.0 In-Reply-To: <5e8de9b9-17cc-65c5-1b47-e3f087f8ce85@gmx.de> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 09, 2021 at 14:47:46 +0100, Heinrich Schuchardt wrote: > >>> I have no idea why the alignment would be 3 on other platforms, so I > >>> don't know how to fix it. > >>> If anyone knows more, please let me know. I'll just change the comment > >>> to say Riscv64. > >>> > >>>>> +.align 3 > >> > >> Both on Aarch64 and on RISC-V an odd alignment value makes no sense. > >> > >> .align 8 should do no harm. But is it needed? > > > > The glory of the GAS .align directive is that its meaning differs > > between architectures and executable formats. On ARM/AArch64, as well > > as on RISC-V (I think?) the alignment is described as a power of 2. > > > > So .align 3 on ARM and others are the same as .align 8 on x86 (ELF) > > and others. > > > > (It might not be a bad idea to start replacing .align directives with > > .baligh to reduce confusion.) > > Thanks for pointing out the different meanings of .align. They are > documented in binutils-2.36/gas/doc/as.info chapter 7.3. > > .balign is GNU assembler specific. > > Do we have to consider other assemblers here? I don't think so. The GNU family of toolchains are the only ones using .s/.S sources. Unless there are GNU-compatible assemblers that don't support the directive. Visual Studio uses .asm on ARM* and .nasm on x86. / Leif