public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif@nuviainc.com>
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build
Date: Wed, 10 Feb 2021 20:17:00 +0000	[thread overview]
Message-ID: <20210210201700.GW1664@vanye> (raw)
In-Reply-To: <20210210150457.25897-1-rebecca@nuviainc.com>

On Wed, Feb 10, 2021 at 08:04:57 -0700, Rebecca Cran wrote:
> The ARM ProcessorSubClassDxe build was broken due to changes in the
> SmbiosProcessor API and an unused variable.
> 
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>

Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as c615265b366d.

Thanks!

> ---
>  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
> index 0be4403c765f..c78bd41a7e06 100644
> --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
> +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c
> @@ -22,7 +22,7 @@
>      @return The cache size.
>  **/
>  UINT64
> -ArmGetCacheSize (
> +SmbiosProcessorGetCacheSize (
>    IN UINT8   CacheLevel,
>    IN BOOLEAN DataCache,
>    IN BOOLEAN UnifiedCache
> @@ -66,14 +66,13 @@ ArmGetCacheSize (
>      @return The cache associativity.
>  **/
>  UINT32
> -ArmGetCacheAssociativity (
> +SmbiosProcessorGetCacheAssociativity (
>    IN UINT8   CacheLevel,
>    IN BOOLEAN DataCache,
>    IN BOOLEAN UnifiedCache
>    )
>  {
>    CCSIDR_DATA  Ccsidr;
> -  CCSIDR2_DATA Ccsidr2;
>    CSSELR_DATA  Csselr;
>    BOOLEAN      CcidxSupported;
>    UINT32       Associativity;
> @@ -88,7 +87,6 @@ ArmGetCacheAssociativity (
>    CcidxSupported = ArmHasCcidx ();
>  
>    if (CcidxSupported) {
> -    Ccsidr2.Data = ReadCCSIDR2 (Csselr.Data);
>      Associativity = Ccsidr.BitsCcidxAA32.Associativity + 1;
>    } else {
>      Associativity = Ccsidr.BitsNonCcidx.Associativity + 1;
> -- 
> 2.26.2
> 

  reply	other threads:[~2021-02-10 20:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 15:04 [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build Rebecca Cran
2021-02-10 20:17 ` Leif Lindholm [this message]
2021-02-18  3:33 ` 回复: [edk2-devel] " gaoliming
2021-02-18  3:41   ` Rebecca Cran
2021-02-18  5:54     ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210210201700.GW1664@vanye \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox