From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mx.groups.io with SMTP id smtpd.web09.11891.1612988223513620011 for ; Wed, 10 Feb 2021 12:17:03 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=i8SaVDaq; spf=pass (domain: nuviainc.com, ip: 209.85.128.48, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f48.google.com with SMTP id m1so3019373wml.2 for ; Wed, 10 Feb 2021 12:17:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=r9pGnoJKndYNZ1xa9rle6bRWGjvi5FXkaeZU7geOxdU=; b=i8SaVDaqZ9kBjWJa3Rte7HF/BrRQsQBVQlGFj8DIwESjvfkHardycQk2hj3KtLN/Iw 7qcAIgegMayXq8FCkMvDyIR7VQt4+NZTL7gdsHeJmBNhD4pjwYs8OiDgCvVBaPB2c5uW pjg4AVYyCzNgWafaUp9wKrcVPyH8WXu9cU4Apn+H84dlR528UngmnmOzTVvo9WElxVR/ lwla0Vfw20fiODkFElW8/SFUjs0miNb2FMMMyUbK1HqzSiDPhs1jvxovSnagqZ6C8aw0 QmAU7NzuqONNCqc82I1Kc4JpDcySe/4ZBw3nqpxgjQIK2NS5g1gRKWw0o8nxfhpXHnkF PpJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=r9pGnoJKndYNZ1xa9rle6bRWGjvi5FXkaeZU7geOxdU=; b=tUp8MHWZyTRrYl73iuIjmxfGgBG3qWWJBALb+F+6VhD0y25Z8rNGIDx6JmeKjVLaqs BN2QoA/WSKC7Nls1xw8YSlmaSAXr+PmFyaKgd4NiAVRBwwpUzBG5SSrkyfZBUVEOR/EN XTdUBzpYL2GL4vW3DO5XhwPh9LOk8HSavL6EyAr4IZamMAa1EKKWZPCg9ey8VJ9Nt2ki iUxoX88CbRFqv7HciyTZtRNjGuZ5wnfvBXngqpM8UuOfVyAYlkEve2pmqAODBVe/gc2z 7pdcV5+9o+fAFtMRtfRi94HG92+teogu/ixqNxLb+ORqtC2bj/oV6O3GNGXNLsONCs+u xoxg== X-Gm-Message-State: AOAM530HAOI2uLFa4ZjALG8n/np64jON5e/lGsrx9lcwn8EuTr88I9kl V4agTVGDGq1faQvqJIBSl3TWmA== X-Google-Smtp-Source: ABdhPJwE40cobzxCAjyxJTY3zCy+5J2UAcfqR5I1tzGE4SYIL7BP0Z3xpxPa8YHvwug1oTUZRlCNqw== X-Received: by 2002:a1c:1f4d:: with SMTP id f74mr751636wmf.12.1612988222162; Wed, 10 Feb 2021 12:17:02 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id f14sm4049582wmc.32.2021.02.10.12.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 12:17:01 -0800 (PST) Date: Wed, 10 Feb 2021 20:17:00 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build Message-ID: <20210210201700.GW1664@vanye> References: <20210210150457.25897-1-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210210150457.25897-1-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 10, 2021 at 08:04:57 -0700, Rebecca Cran wrote: > The ARM ProcessorSubClassDxe build was broken due to changes in the > SmbiosProcessor API and an unused variable. > > Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Pushed as c615265b366d. Thanks! > --- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c > index 0be4403c765f..c78bd41a7e06 100644 > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArm.c > @@ -22,7 +22,7 @@ > @return The cache size. > **/ > UINT64 > -ArmGetCacheSize ( > +SmbiosProcessorGetCacheSize ( > IN UINT8 CacheLevel, > IN BOOLEAN DataCache, > IN BOOLEAN UnifiedCache > @@ -66,14 +66,13 @@ ArmGetCacheSize ( > @return The cache associativity. > **/ > UINT32 > -ArmGetCacheAssociativity ( > +SmbiosProcessorGetCacheAssociativity ( > IN UINT8 CacheLevel, > IN BOOLEAN DataCache, > IN BOOLEAN UnifiedCache > ) > { > CCSIDR_DATA Ccsidr; > - CCSIDR2_DATA Ccsidr2; > CSSELR_DATA Csselr; > BOOLEAN CcidxSupported; > UINT32 Associativity; > @@ -88,7 +87,6 @@ ArmGetCacheAssociativity ( > CcidxSupported = ArmHasCcidx (); > > if (CcidxSupported) { > - Ccsidr2.Data = ReadCCSIDR2 (Csselr.Data); > Associativity = Ccsidr.BitsCcidxAA32.Associativity + 1; > } else { > Associativity = Ccsidr.BitsNonCcidx.Associativity + 1; > -- > 2.26.2 >