[PATCH edk2-platforms v1 0/1] Alignment with ArmPkg Ecc errors fixes

[PATCH edk2-platforms v1 0/1] Alignment with ArmPkg Ecc errors fixes

[PierreGondois]

From: Pierre Gondois <Pierre.Gondois@arm.com>

A patch serie fixing Ecc errors in edk2/ArmPkg and modifying
C structures was submitted at:
https://edk2.groups.io/g/devel/message/71439

This patch serie requires some modifications to be done in the
edk2-platforms repository. If accepted, the patches for edk2 and
edk2-platforms must be merged synchronously.

Pierre Gondois (1):
  Platform/Arm: Fix Ecc error 7008 for SCMI_CLOCK_RATE

 .../Library/HdLcdArmJunoLib/HdLcdArmJuno.c    | 33 +++++++++++++++----
 1 file changed, 26 insertions(+), 7 deletions(-)

--
2.17.1

[PATCH edk2-platforms v1 1/1] Platform/Arm: Fix Ecc error 7008 for SCMI_CLOCK_RATE

[PierreGondois]

From: Pierre Gondois <Pierre.Gondois@arm.com>

Following the Ecc reported error in the edk2 repository,
the SCMI_CLOCK_RATE structure has been modified in:
an enum and its elements have been renamed in:
ArmPkg/Include/Protocol/ArmScmiClockProtocol.h

This patch is a follow-up and fixes the following Ecc
reported error:
Complex types should be typedef-ed

The error is due to the a nested structure declaration.

The patch also re-formats the debug messages to fit in
a 80 chars line.

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tree/1552_Ecc_ArmPkg_BIS_v1

 .../Library/HdLcdArmJunoLib/HdLcdArmJuno.c    | 33 +++++++++++++++----
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c b/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
index 30558878f068..67c9d43cf2b7 100644
--- a/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
+++ b/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
@@ -1,6 +1,6 @@
 /** @file

-  Copyright (c) 2013 - 2020, Arm Limited. All rights reserved.<BR>
+  Copyright (c) 2013 - 2021, Arm Limited. All rights reserved.<BR>

   SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -352,12 +352,31 @@ ProbeHdLcdClock (
     return Status;
   }

-  DEBUG ((DEBUG_ERROR, "Clock ID = %d Clock name = %a\n", *ClockId, ClockName));
-  DEBUG ((DEBUG_ERROR, "Minimum frequency = %uHz\n", ClockRate.Min));
-  DEBUG ((DEBUG_ERROR, "Maximum frequency = %uHz\n", ClockRate.Max));
-  DEBUG ((DEBUG_ERROR, "Clock rate step = %uHz\n", ClockRate.Step));
-
-  DEBUG ((DEBUG_ERROR, "HDLCD Current frequency = %uHz\n", CurrentHdLcdFreq));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Clock ID = %d Clock name = %a\n",
+    *ClockId, ClockName
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Minimum frequency = %uHz\n",
+    ClockRate.ContinuousRate.Min
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Maximum frequency = %uHz\n",
+    ClockRate.ContinuousRate.Max
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Clock rate step = %uHz\n",
+    ClockRate.ContinuousRate.Step
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "HDLCD Current frequency = %uHz\n",
+    CurrentHdLcdFreq
+    ));

   return EFI_SUCCESS;
 }
--
2.17.1

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/Arm: Fix Ecc error 7008 for SCMI_CLOCK_RATE

[Sami Mujawar]

[-- Attachment #1: Type: text/plain, Size: 78 bytes --]

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar

[-- Attachment #2: Type: text/html, Size: 100 bytes --]