public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "PierreGondois" <pierre.gondois@arm.com>
To: devel@edk2.groups.io, sami.mujawar@arm.com
Subject: [PATCH edk2-platforms v1 1/1] Platform/Arm: Fix Ecc error 7008 for SCMI_CLOCK_RATE
Date: Thu, 11 Feb 2021 17:58:22 +0000	[thread overview]
Message-ID: <20210211175822.16254-2-Pierre.Gondois@arm.com> (raw)
In-Reply-To: <20210211175822.16254-1-Pierre.Gondois@arm.com>

From: Pierre Gondois <Pierre.Gondois@arm.com>

Following the Ecc reported error in the edk2 repository,
the SCMI_CLOCK_RATE structure has been modified in:
an enum and its elements have been renamed in:
ArmPkg/Include/Protocol/ArmScmiClockProtocol.h

This patch is a follow-up and fixes the following Ecc
reported error:
Complex types should be typedef-ed

The error is due to the a nested structure declaration.

The patch also re-formats the debug messages to fit in
a 80 chars line.

Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
The changes can be seen at: https://github.com/PierreARM/edk2-platforms/tree/1552_Ecc_ArmPkg_BIS_v1

 .../Library/HdLcdArmJunoLib/HdLcdArmJuno.c    | 33 +++++++++++++++----
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c b/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
index 30558878f068..67c9d43cf2b7 100644
--- a/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
+++ b/Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
@@ -1,6 +1,6 @@
 /** @file

-  Copyright (c) 2013 - 2020, Arm Limited. All rights reserved.<BR>
+  Copyright (c) 2013 - 2021, Arm Limited. All rights reserved.<BR>

   SPDX-License-Identifier: BSD-2-Clause-Patent

@@ -352,12 +352,31 @@ ProbeHdLcdClock (
     return Status;
   }

-  DEBUG ((DEBUG_ERROR, "Clock ID = %d Clock name = %a\n", *ClockId, ClockName));
-  DEBUG ((DEBUG_ERROR, "Minimum frequency = %uHz\n", ClockRate.Min));
-  DEBUG ((DEBUG_ERROR, "Maximum frequency = %uHz\n", ClockRate.Max));
-  DEBUG ((DEBUG_ERROR, "Clock rate step = %uHz\n", ClockRate.Step));
-
-  DEBUG ((DEBUG_ERROR, "HDLCD Current frequency = %uHz\n", CurrentHdLcdFreq));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Clock ID = %d Clock name = %a\n",
+    *ClockId, ClockName
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Minimum frequency = %uHz\n",
+    ClockRate.ContinuousRate.Min
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Maximum frequency = %uHz\n",
+    ClockRate.ContinuousRate.Max
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "Clock rate step = %uHz\n",
+    ClockRate.ContinuousRate.Step
+    ));
+  DEBUG ((
+    DEBUG_ERROR,
+    "HDLCD Current frequency = %uHz\n",
+    CurrentHdLcdFreq
+    ));

   return EFI_SUCCESS;
 }
--
2.17.1


  reply	other threads:[~2021-02-11 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 17:58 [PATCH edk2-platforms v1 0/1] Alignment with ArmPkg Ecc errors fixes PierreGondois
2021-02-11 17:58 ` PierreGondois [this message]
2021-02-23 11:25   ` [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/Arm: Fix Ecc error 7008 for SCMI_CLOCK_RATE Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210211175822.16254-2-Pierre.Gondois@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox