From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.40]) by mx.groups.io with SMTP id smtpd.web09.1981.1613125449553224658 for ; Fri, 12 Feb 2021 02:24:10 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=KmIJU5MA; spf=pass (domain: arm.com, ip: 40.107.21.40, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ukVanBIGptsYu4ST8diuoKIiJvbf5rPnlIttXWz5VFg=; b=KmIJU5MAzHyf5lBBoE7lm8Q5QliLOhnAZr7dyiCRFOlv2hQJGBIyp2+ZPPteq9Sww8KZjPz6+23ALbrNcDuKgkX6aVghg7M0JSl1y9GzXqzxr5ntXv4cJb31jov/wiy0M8xhB4I9PMgPPnWMo1ATyO4h742t76mCCPl+mYuczxg= Received: from AM6PR08CA0009.eurprd08.prod.outlook.com (2603:10a6:20b:b2::21) by DB7PR08MB3561.eurprd08.prod.outlook.com (2603:10a6:10:42::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25; Fri, 12 Feb 2021 10:24:01 +0000 Received: from AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:b2:cafe::e0) by AM6PR08CA0009.outlook.office365.com (2603:10a6:20b:b2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25 via Frontend Transport; Fri, 12 Feb 2021 10:24:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT027.mail.protection.outlook.com (10.152.16.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25 via Frontend Transport; Fri, 12 Feb 2021 10:24:01 +0000 Received: ("Tessian outbound 4d8113405d55:v71"); Fri, 12 Feb 2021 10:24:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a6bc6749752fbd22 X-CR-MTA-TID: 64aa7808 Received: from 8ad3b5d4472c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 06EA691E-8A0F-4729-A798-BC6A89FA4931.1; Fri, 12 Feb 2021 10:23:55 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8ad3b5d4472c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 12 Feb 2021 10:23:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J5ZM6CEg6Z/8yJ8ymwqwakmbyId3MV+73nnOiuJm7ww2zssDkqZJ66Lc27kvzbxAca2hHAZi3ggTtJ8vtW2nKVqUaQlUAiNQijvFIbhGkzsupdbFOk/GGToOIkRYG6/X2UV+99LUb+0hRSHZ92jtwDkig3Wp9G8S5frYlv9SWFsJEP9pMJIIcQOnKiScWKbPy8ILiWV8UKFd8vfHjfzzL14xkLlLEEla5ynBc1zqJKm7qUNdDueF22Sb/8piuZ62zRtdbQcpGh7WxADSvu33CAMhzO5u8dOy2MB3cPsy6oUT4sIZz/dYbCRaMkM8R11zBs/oMhZU+50L4kEu6T2DEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ukVanBIGptsYu4ST8diuoKIiJvbf5rPnlIttXWz5VFg=; b=WSnYwHIFCuDpmqzz84vX8aqAjeejASFZ9fJyASzU1yywX1V+CiANR9Al/M9SrX671zHyG2/LIp1d9LElyk7mrRkGC/D4P7/zA0jW1THosa4M6+SEEnmi9ses/mtJgPxwIgsR5ES1C7T56Zgb2KjW+u5PlPy3Pxdwg3UVoxUIx3Q4wZkTbvJWHlPGIT7tDiR2+TYuQrGRyFLWQatmNig1MHXoGRCS46mlD3cMnT3qDRWzs/tASZcpUBRH8CgsuGb/2wd+NIIHiw07X4sKau6ImYAwGpQkvweAqk93VDY5vWOHYC5LXA4UqZQQvkstJoW/XB409yH12Xtmgc51S18hQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ukVanBIGptsYu4ST8diuoKIiJvbf5rPnlIttXWz5VFg=; b=KmIJU5MAzHyf5lBBoE7lm8Q5QliLOhnAZr7dyiCRFOlv2hQJGBIyp2+ZPPteq9Sww8KZjPz6+23ALbrNcDuKgkX6aVghg7M0JSl1y9GzXqzxr5ntXv4cJb31jov/wiy0M8xhB4I9PMgPPnWMo1ATyO4h742t76mCCPl+mYuczxg= Received: from DB6PR0601CA0006.eurprd06.prod.outlook.com (2603:10a6:4:7b::16) by AM7PR08MB5527.eurprd08.prod.outlook.com (2603:10a6:20b:de::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.29; Fri, 12 Feb 2021 10:23:54 +0000 Received: from DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:7b:cafe::29) by DB6PR0601CA0006.outlook.office365.com (2603:10a6:4:7b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.27 via Frontend Transport; Fri, 12 Feb 2021 10:23:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT037.mail.protection.outlook.com (10.152.20.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.3846.25 via Frontend Transport; Fri, 12 Feb 2021 10:23:54 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Fri, 12 Feb 2021 10:23:44 +0000 Received: from E107187.Arm.com (10.57.49.120) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2044.4 via Frontend Transport; Fri, 12 Feb 2021 10:23:44 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , , Subject: [PATCH edk2-platforms v1 03/12] Platform/ARM/VExpressPkg: Memory map for FVP RevC model Date: Fri, 12 Feb 2021 10:23:32 +0000 Message-ID: <20210212102341.24056-4-sami.mujawar@arm.com> X-Mailer: git-send-email 2.11.0.windows.3 In-Reply-To: <20210212102341.24056-1-sami.mujawar@arm.com> References: <20210212102341.24056-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f08c079-0706-4e56-580e-08d8cf4050c9 X-MS-TrafficTypeDiagnostic: AM7PR08MB5527:|DB7PR08MB3561: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2201;OLM:2201; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hDJVpnEpLPpTIM8N+o9uTh6tK+cLs2ySGgxdSjxKb3HOsL8OnZIAg0BVxl3xdkxJ1OaNnVnOv63k8UqCBTC5033xohA7HzOvSC3RKuHRn7wSIBzziCnVzxzCyRYAzcyAKyMEpL8yIF82QJTwmUTh89DbWh200PEE+oGTVBkyAy/y5KFKXL33IsYLjIzLi8EI+2EnbKLTrVjf2WHxIU8PGStkIl5F+1iZbCovWWyHc210ZHJozagB9ac/UTvwIi4PUKckuzHW45gGbZSHLH+F2ESiRk86xPUbZYFxGhdJB1OebOrKOnmS3axoUQaAX77MDvedIJ/Ax16V7RQfTvjO84b7MafxViL5VkKk3Cu9cb9IsZJIqfh4SGDBpdjQwb/LGyqdHiP++fF8OzwgxCEtYHqRH8FQKGcQMVWsIZklbWssHKAmzNy6ldS8iI6AGBifsOa+DYxfzfzm5s2rPAaZub9nC4ihP2DztFRF21mAgkNGnQ7aQOQWDkKSAO87oRH16NFUpXUVjrmfF1zRZxT6r1dFd6vzbgSUikL0Z45uG3wWuFNFOi7WdLQB+Yei+pvDgM5jRSlOCsJ/KVdsP3FLmC10qZdcAgFW0WwQuEYtnUxIwK6NRrO6cW+J69NmHCiGl+o4VhbbxmhQCY9HrOIzz4q5RbiF/gYqBLUfZwM/MCOa1OZahbugFZtlJ3tbhdBI X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(396003)(39860400002)(376002)(136003)(346002)(36840700001)(46966006)(1076003)(83380400001)(26005)(81166007)(4326008)(36860700001)(6916009)(82740400003)(186003)(316002)(478600001)(47076005)(7696005)(2906002)(2616005)(36756003)(8676002)(6666004)(44832011)(19627235002)(82310400003)(426003)(54906003)(86362001)(8936002)(5660300002)(70206006)(356005)(70586007)(336012)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5527 Return-Path: Sami.Mujawar@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a54df073-46dc-484a-b8c0-08d8cf404cc6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pAjMNbXVItr6elIKl2IlrscnbMDftk0FLByHpd+wn+J5NCmtR2C0kdLWUL03zjtwWEWv0ui0JQ6+CDMlRPskuLCcJtMlh9yFnbmfZFo0kng8JdZxRex0PxdYG1q3E3Jbn/Fo3Yj54noxyMW3xpa+zbGclp0H/BJZXMCpLOvotATrmTCfGvyvsReAMtF6X4l8+r8Ok7BYA0jjFb8Df8rD8PEJh7Pob74Kj/+dMxXsgLAdkAZ/ri+68+xhW644TUSnb+Ih4XkgNXo5WJojkhd3jZRLDRrvil1HnbVb5nq2Mt3coEOEV1iUdcKyTOzO/gTPfHCDL2fmc6kkx57V8wB9Vd9hVlN9UJUbEbX/ep8BKiymrY3JeCJQYX4O41tWcPAkXk3qd+pACjLoJCI1WdtHNyD9/l/VUPOWIIeri4nn9KtyO8QOZknPMFwaUScnLCl6MHG7IAGP093bMm9o3UlAh6XeZA6FQK5OY9eRoiMt2/0eEmY+pM5yuSEm8W/ejyxODhja+T6AtLs9j1/qWtAD9nT7Bu0uluGE5NI4jS7yGzeORm1ngCzcyv4um9zA6oToMPsxLBTnaFeDGMlzzCtQJ1Hj7NzvDOQAqafMNIeud5pP62979Lm56Rr1PYcAjkhAV9CvDVk5kjdXZ5L7SJj6fz15t6K4HHAuBBTAOIqbpbY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(376002)(396003)(346002)(39860400002)(136003)(46966006)(36840700001)(6666004)(8676002)(70206006)(5660300002)(82740400003)(7696005)(316002)(83380400001)(70586007)(19627235002)(36756003)(478600001)(8936002)(47076005)(6916009)(54906003)(426003)(4326008)(86362001)(36860700001)(82310400003)(26005)(336012)(1076003)(81166007)(2616005)(186003)(44832011)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2021 10:24:01.2584 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f08c079-0706-4e56-580e-08d8cf4050c9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3561 Content-Type: text/plain FVP Base Platform RevC is a configuration of the Base Platform that includes a SMMUv3 and a PCIe subsystem. The PCIe subsystem has a PCIe config region (ECAM) and two PCIe memory regions. Add the SMMUv3 and PCIe config and memory regions to the memory map so that the firmware can access and configure these components. Signed-off-by: Sami Mujawar --- Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h | 6 +++- Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 12 +++++++- Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c | 31 ++++++++++++++++++-- 3 files changed, 45 insertions(+), 4 deletions(-) diff --git a/Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h b/Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h index 499f62b2dc405c777e2266f4cbdaba963f5d26a2..96cc131dac91e428881f2506d277222490b649cb 100644 --- a/Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h +++ b/Platform/ARM/VExpressPkg/Include/Platform/RTSM/ArmPlatform.h @@ -1,7 +1,7 @@ /** @file * Header defining Versatile Express constants (Base addresses, sizes, flags) * -* Copyright (c) 2011, ARM Limited. All rights reserved. +* Copyright (c) 2011 - 2021, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -73,4 +73,8 @@ #define SBSA_WATCHDOG_BASE 0x2a440000 #define SBSA_WATCHDOG_SIZE (2 * SIZE_64KB) +// SMMUv3 - FVP RevC +#define FVP_REVC_SMMUV3_BASE 0x2B400000 +#define FVP_REVC_SMMUV3_SIZE SIZE_1MB + #endif diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf index d3441b0852c67b697067191f6b46f3ac6dce7707..929dadc28a84cdb2ca6c6a733b75a5c352922112 100644 --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf @@ -1,5 +1,5 @@ #/* @file -# Copyright (c) 2011-2018, ARM Limited. All rights reserved. +# Copyright (c) 2011-2021, Arm Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -54,5 +54,15 @@ [FixedPcd] gArmPlatformTokenSpaceGuid.PcdArmMaliDpBase gArmPlatformTokenSpaceGuid.PcdArmMaliDpMemoryRegionLength + # PCI Configuration space + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress + gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseSize + + gArmTokenSpaceGuid.PcdPciMmio32Base + gArmTokenSpaceGuid.PcdPciMmio32Size + + gArmTokenSpaceGuid.PcdPciMmio64Base + gArmTokenSpaceGuid.PcdPciMmio64Size + [Ppis] gArmMpCoreInfoPpiGuid diff --git a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c index 21ffd64fb6350608b661298e4f336493696081df..13f181834ba8a3a8225a18147cbdbbde3807eb53 100644 --- a/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c +++ b/Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2011-2018, ARM Limited. All rights reserved. +* Copyright (c) 2011-2021, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -17,7 +17,7 @@ #define DP_BASE_DESCRIPTOR ((FixedPcdGet64 (PcdArmMaliDpBase) != 0) ? 1 : 0) // Number of Virtual Memory Map Descriptors -#define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS (10 + DP_BASE_DESCRIPTOR) +#define MAX_VIRTUAL_MEMORY_MAP_DESCRIPTORS (14 + DP_BASE_DESCRIPTOR) // DDR attributes #define DDR_ATTRIBUTES_CACHED ARM_MEMORY_REGION_ATTRIBUTE_WRITE_BACK @@ -161,6 +161,33 @@ ArmPlatformGetVirtualMemoryMap ( VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; } + // Map the PCI configration and memory space if the platform is FVP RevC. + if ((SysId & ARM_FVP_SYS_ID_REV_MASK) == ARM_FVP_BASE_REVC_REV) { + // SMMUv3 + VirtualMemoryTable[++Index].PhysicalBase = FVP_REVC_SMMUV3_BASE; + VirtualMemoryTable[Index].VirtualBase = FVP_REVC_SMMUV3_BASE; + VirtualMemoryTable[Index].Length = FVP_REVC_SMMUV3_SIZE; + VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; + + // PCI Configuration Space + VirtualMemoryTable[++Index].PhysicalBase = FixedPcdGet64 (PcdPciExpressBaseAddress); + VirtualMemoryTable[Index].VirtualBase = FixedPcdGet64 (PcdPciExpressBaseAddress); + VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdPciExpressBaseSize); + VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; + + // PCI Memory Space + VirtualMemoryTable[++Index].PhysicalBase = FixedPcdGet32 (PcdPciMmio32Base); + VirtualMemoryTable[Index].VirtualBase = FixedPcdGet32 (PcdPciMmio32Base); + VirtualMemoryTable[Index].Length = FixedPcdGet32 (PcdPciMmio32Size); + VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; + + // 64-bit PCI Memory Space + VirtualMemoryTable[++Index].PhysicalBase = FixedPcdGet64 (PcdPciMmio64Base); + VirtualMemoryTable[Index].VirtualBase = FixedPcdGet64 (PcdPciMmio64Base); + VirtualMemoryTable[Index].Length = FixedPcdGet64 (PcdPciMmio64Size); + VirtualMemoryTable[Index].Attributes = ARM_MEMORY_REGION_ATTRIBUTE_DEVICE; + } + // Map sparse memory region if present if (HasSparseMemory) { VirtualMemoryTable[++Index].PhysicalBase = SparseMemoryBase; -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'