From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web12.30572.1613395113493375776 for ; Mon, 15 Feb 2021 05:18:33 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=oGmgPdHv; spf=pass (domain: nuviainc.com, ip: 209.85.128.49, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f49.google.com with SMTP id h7so1042344wmq.0 for ; Mon, 15 Feb 2021 05:18:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=BBWAYw21NAS6CcOmTjAbMK1n+MB+vnbG/VlYBi8n10I=; b=oGmgPdHvSfu+1fm+kBN4eeVpDLZLxRgD0bHRh2AFH5poUkjCHx2Njr2wZsVHr84fkz q7JgH6UnzJVxajs0c5ZRtOD/rDS0Lh2FHwyLWFzQyM4TQuIXIsg7XRWVTEhqzRuFYjKE 67CZ88uT+m2oNrsk1Y+AproS2kuKkigz5eP4HmVag9U8o63kBkpXTcRfV9rNHzL0G48G w+cruuiybxUsgVXsIizC9NAa325sleWHWENSqJHTaF/HJiUfWcDvCovdlO2eQ2U5tyRw bKBfH+25c1Z6RvzH0eWd6FHAcOK6XKCFeYxJMTgFxdpaZ5g1+OfVoAEu2wLZbyVOYOfK fQbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=BBWAYw21NAS6CcOmTjAbMK1n+MB+vnbG/VlYBi8n10I=; b=l192sbCYtfzwob6/qbW0KDl7sU+FgUh7tyWOPcRQBs28qlMjZMUCQLlfA9h90Mz/oW LQG3r4KK8CWBj7FBv7Y+syzIp37dIy9MkDR2Mtq6TXPmOGdnrm30DuA7FuUwlP0Nud7H aDKH8bOslBnwu2G3swdniv//j53OGhWLvzRfVeUyHOAgY8p2FcksDlUrB/dFi9YIJKu7 YJY+joxxL+T2is6ungzRUxWpJ+jXZZD+obOfpJq/XMyJaqCMZhiisC/zZKAcMzp0wRwO mMkaefzam75wcmnRbuEzha2W62ZQcCgMGKQn8XXF7lg/1JBX8cBYOv9qAyQU0Mi5aTj9 /QjA== X-Gm-Message-State: AOAM531eqsDM5y5/wok3YaoVyCUnhTHvKkxOE/BvGnXTPEDI7I2OY5TJ Y3W1ZCt1eyEIYSls9DMLEjQ5eA== X-Google-Smtp-Source: ABdhPJzZW/YM60ipwzSWSSliwgmA2in7jsjTyFzDSbT8kw2waKNx4hROhdQ7OMqYRo1QtXFcHyXydQ== X-Received: by 2002:a1c:9851:: with SMTP id a78mr13994906wme.66.1613395112035; Mon, 15 Feb 2021 05:18:32 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id w16sm9631064wrk.38.2021.02.15.05.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 05:18:31 -0800 (PST) Date: Mon, 15 Feb 2021 13:18:29 +0000 From: "Leif Lindholm" To: Vikas Singh , sami.mujawar@arm.com Cc: devel@edk2.groups.io, meenakshi.aggarwal@nxp.com, paul.yang@arm.com, augustine.philips@arm.com, samer.el-haj-mahmoud@arm.com, v.sethi@nxp.com, arokia.samy@puresoftware.com, kuldip.dwivedi@puresoftware.com, ard.biesheuvel@arm.com, vikas.singh@nxp.com Subject: Re: [PATCH v2 0/2] Dynamic ACPI framework for fsl layerscape platforms Message-ID: <20210215131829.GB1664@vanye> References: <1611729899-23741-1-git-send-email-vikas.singh@puresoftware.com> MIME-Version: 1.0 In-Reply-To: <1611729899-23741-1-git-send-email-vikas.singh@puresoftware.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Vikas, Apologies for very slow review. However, this set doesn't build for me. It fails with In file included from /work/git/edk2-platforms/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c:26: /work/git/edk2-platforms/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.h:17:10: fatal error: Platform.h: No such file or directory #include ^~~~~~~~~~~~ Since the location of ConfigurationManagerPkg suggests the intent to use this for additional platforms in the future, this cannot be resolved by referencing LX2160aRdbPkg.dec from ConfigurationManagerDxe.inf. I would suggest doing like the ARM VExpressPkg and add: [BuildOptions] GCC:*_*_AARCH64_PLATFORM_FLAGS == -I$(WORKSPACE)/Platform/NXP/LX2160aRdbPkg/Include to LX2160aRdbPkg.dsc. Also, I'm seeing a build failure in edk2 DynamicTablesPkg when building with NOOPT: /work/git/edk2/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c: In function ‘AmlEnumeratePathCallback’: /work/git/edk2/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c:1081:31: error: variable ‘CurrNodePath’ set but not used [-Werror=unused-but-set-variable] CHAR8 * CurrNodePath; ^~~~~~~~~~~~ /work/git/edk2/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c:1078:31: error: variable ‘SearchedPath’ set but not used [-Werror=unused-but-set-variable] CHAR8 * SearchedPath; ^~~~~~~~~~~~ Sami - can you have a look at that? I'll follow up with a couple of minor comments on the patches. Best Regards, Leif On Wed, Jan 27, 2021 at 12:14:57 +0530, Vikas Singh wrote: > This patch series sets the foundation of Dynamic ACPI framework for all > fsl layerscape platforms. In order to achieve: > - Configurable firmware builds. > - Unify firmware build for similar platforms. > - Minimize/eliminate human induced errors. > - Validate and generate firmware that complies with relevant specifications. > this change set will introduce following changes in below defined order under > edk2-platforms/NXP for LX2160ARDB platform. > > (1) Introduced edk2-platforms/NXP/ConfigurationManager > It creates the platform repositories dynamically during build time > and initializes with platform specific information and serves all requestes > coming from OEM/standard firmware table generators. Configuration Manager(CM) > will be common for all fsl platforms. > > (2) Introduced edk2-platforms/NXP/LX2160ARDB/Include/Platform.h > It has all the declarations and the definitions specified for the platforms. > These definitions will be inturn consumed by Configuration Manager. > Additionally the placement of this header under "Include" dir will make these > macro's availale to other translation units of the platform built. > > (3) Introduced edk2-platforms/NXP/LX2160ARDB/AcpiTablesInclude > This is a placeholder for - OEM specific firmware acpi table generators. > This also includes IP specific - DSDT/SSDT generators for the OEM's platform. > Currently Dsdt.asl is a place holder having only platform's clock related dsdt > properties for LX2160ARDB but it is intended to extend this "Dsdt.asl" to hold > other table as well in next patch series. > > (4) Introduced a new "DYNAMIC_ACPI_ENABLE" flag to control DACPI framework. > Currently this flag is used for LX2160ARDB and by default it is enabled. > This flag can also extend to other fsl layerscape platforms in future. > Changes can be referred under: > - LX2160ARDb.dsc > - LX2160ARDB.fdf > > (5) Introduced a "build.sh" script under edk2-platforms/NXP/ to automate builds. > And also mandatorily need to support Dynamic ACPI framework for all fsl platforms. > It exports build environment variables and also invokes "Env.sh". > > Vikas Singh (2): > Platform/NXP: Add Dynamic Acpi for layerscape platforms > Platform/NXP: Add OEM specific DSDT generator > > .../ConfigurationManagerDxe/ConfigurationManager.c | 843 +++++++++++++++++++++ > .../ConfigurationManagerDxe/ConfigurationManager.h | 153 ++++ > .../ConfigurationManagerDxe.inf | 52 ++ > .../ConfigurationManagerPkg.dec | 23 + > .../Include/PlatformAcpiTableGenerator.h | 20 + > Platform/NXP/Env.sh | 67 ++ > .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl | 40 + > .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl | 15 + > .../AcpiTablesInclude/PlatformAcpiDsdtLib.inf | 39 + > .../PlatformAcpiDsdtLib/RawDsdtGenerator.c | 146 ++++ > .../AcpiTablesInclude/PlatformAcpiLib.h | 24 + > Platform/NXP/LX2160aRdbPkg/Include/Platform.h | 246 ++++++ > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec | 4 + > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 29 + > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 12 + > Platform/NXP/Readme.md | 35 +- > Platform/NXP/build.sh | 115 +++ > Silicon/NXP/LX2160A/LX2160A.dsc.inc | 9 + > 18 files changed, 1871 insertions(+), 1 deletion(-) > create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c > create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.h > create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerPkg.dec > create mode 100644 Platform/NXP/ConfigurationManagerPkg/Include/PlatformAcpiTableGenerator.h > create mode 100755 Platform/NXP/Env.sh > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h > create mode 100644 Platform/NXP/LX2160aRdbPkg/Include/Platform.h > create mode 100755 Platform/NXP/build.sh > > -- > 2.7.4 >