From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.groups.io with SMTP id smtpd.web11.31243.1613396680919658931 for ; Mon, 15 Feb 2021 05:44:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=KKp5zTTc; spf=pass (domain: nuviainc.com, ip: 209.85.128.50, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f50.google.com with SMTP id h67so4568174wmh.1 for ; Mon, 15 Feb 2021 05:44:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jhZ8Os9Gg2AhVJiFs3OjbyPgSZqj7E4hDUiqiM4TMRM=; b=KKp5zTTcX7QgCE86GveHsgtKsdYSp0rjKpNCbPNYz7E4eCXCAO2ASoYLoyCBtTfLtk LNnWucNqeTmYy/SWe+sMcj9tgH871c9yVA2fw3VibOdx/0eZAtXz5lZnF0qum4MZX8/y DOtRbWPYSWZwMbW8aXCzvnaaEDQX9/n7++uo2DNJewX+F9hxlJgOgOpo1jBTeDW9s8nu M+UZtZGewQPYxLzRKHFgPgz6MlK4oJid7xElXIh6UCX5Ai7tcCngeEzF6ItBZlqifrJ1 yYEBbN/3egua2mkcrWKOnJdHZqhdvQk2rhglLEDIyCxrsYdPq7u62+bNdasX4AbwWGUW dOkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jhZ8Os9Gg2AhVJiFs3OjbyPgSZqj7E4hDUiqiM4TMRM=; b=S16tM392cESnzriRi41otRg2Kp/UKiFj4rxJZbJLGc4RAoxvHmPa4h17WEeGiRfMzW mxIfWU+EVa6CmqK5mcRlyTMcgv7pYal0P1Mh2QdvuZR8XnHwcNyxZJROkBVlxgiE2By+ NMnbDyNsCcadvDhZR8mbidmMibZ8U4VGcaL+zcFIapx/XbrwkEbbI2nZJQ+9E6KIjkkH DxgACEo2yVRAS9qrCBgq+pUK97iLq0ecD/KdV8bJVzippGiAfrEHkEIiCHmcqz11ZYNQ SgATbiMDvU9eGQSTBTlUClcLQFUWRX7Xswwh5mKUwS+Sjd4vv4JYkiKKPuojkQvwHCSb VkLQ== X-Gm-Message-State: AOAM531PYsyLWzUixrn+SG/USiYP9gv8Ok6RZxS2RivZBtK/Q5zFflYe +/PAH73ylC958R8rJK/BXqKhbg== X-Google-Smtp-Source: ABdhPJzreNownaVjzWOewPRvYOjZLqCu0aGgPnfBi/7LECL2t3I+lGbZi/2daRIMNA0J+/dzResPBw== X-Received: by 2002:a1c:7e4e:: with SMTP id z75mr14541229wmc.168.1613396679245; Mon, 15 Feb 2021 05:44:39 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id n5sm22625806wmq.7.2021.02.15.05.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 05:44:38 -0800 (PST) Date: Mon, 15 Feb 2021 13:44:36 +0000 From: "Leif Lindholm" To: Vikas Singh Cc: devel@edk2.groups.io, sami.mujawar@arm.com, meenakshi.aggarwal@nxp.com, paul.yang@arm.com, augustine.philips@arm.com, samer.el-haj-mahmoud@arm.com, v.sethi@nxp.com, arokia.samy@puresoftware.com, kuldip.dwivedi@puresoftware.com, ard.biesheuvel@arm.com, vikas.singh@nxp.com Subject: Re: [PATCH v2 2/2] Platform/NXP: Add OEM specific DSDT generator Message-ID: <20210215134436.GC1664@vanye> References: <1611729899-23741-1-git-send-email-vikas.singh@puresoftware.com> <1611729899-23741-3-git-send-email-vikas.singh@puresoftware.com> MIME-Version: 1.0 In-Reply-To: <1611729899-23741-3-git-send-email-vikas.singh@puresoftware.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 27, 2021 at 12:14:59 +0530, Vikas Singh wrote: > These changes add platform specific DSDT generator > and Clk dsdt properties for LX2160ARDB. > > Signed-off-by: Vikas Singh > --- > .../ConfigurationManagerDxe/ConfigurationManager.c | 9 ++ > .../ConfigurationManagerDxe/ConfigurationManager.h | 4 +- > .../ConfigurationManagerDxe.inf | 1 + > .../ConfigurationManagerPkg.dec | 23 ++++ > .../Include/PlatformAcpiTableGenerator.h | 20 +++ > .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl | 40 ++++++ > .../LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl | 15 +++ > .../AcpiTablesInclude/PlatformAcpiDsdtLib.inf | 39 ++++++ > .../PlatformAcpiDsdtLib/RawDsdtGenerator.c | 146 +++++++++++++++++++++ > .../AcpiTablesInclude/PlatformAcpiLib.h | 24 ++++ > Platform/NXP/LX2160aRdbPkg/Include/Platform.h | 6 + > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec | 3 + > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 1 + > 13 files changed, 330 insertions(+), 1 deletion(-) Please use --stat=1000 --stat-graph-width=20 when generating patches, to prevent the ... above. > create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerPkg.dec > create mode 100644 Platform/NXP/ConfigurationManagerPkg/Include/PlatformAcpiTableGenerator.h > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h > > diff --git a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c > index bec9131..80ce841 100644 > --- a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c > +++ b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c > @@ -78,6 +78,15 @@ FSL_PLATFORM_REPOSITORY_INFO FslPlatformRepositoryInfo = { > CREATE_STD_ACPI_TABLE_GEN_ID (EStdAcpiTableIdSpcr), > NULL, > CFG_MGR_TABLE_ID > + }, > + > + // DSDT (OEM) Table > + { > + EFI_ACPI_6_2_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_SIGNATURE, > + 0, > + CREATE_OEM_ACPI_TABLE_GEN_ID (PlatAcpiTableIdDsdt), > + NULL, > + CFG_MGR_TABLE_ID > } > > }, > diff --git a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.h b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.h > index ab320e5..0c7dd41 100644 > --- a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.h > +++ b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.h > @@ -15,6 +15,7 @@ > #define CONFIGURATION_MANAGER_H > > #include > +#include > > /** The configuration manager version > */ > @@ -62,7 +63,8 @@ typedef EFI_STATUS (*CM_OBJECT_HANDLER_PROC) ( > > /** The number of ACPI tables to install > */ > -#define PLAT_ACPI_TABLE_COUNT 5 > +#define CM_MANDATORY_ACPI_TABLES 5 > +#define PLAT_ACPI_TABLE_COUNT (CM_MANDATORY_ACPI_TABLES + OEM_ACPI_TABLES) > > /** A structure describing the platform configuration > manager repository information > diff --git a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManagerDxe.inf b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > index 496c8bf..7c082cb 100644 > --- a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > +++ b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > @@ -31,6 +31,7 @@ > EmbeddedPkg/EmbeddedPkg.dec > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > + Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerPkg.dec > Silicon/NXP/NxpQoriqLs.dec > > [LibraryClasses] > diff --git a/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerPkg.dec b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerPkg.dec > new file mode 100644 > index 0000000..e4af8e4 > --- /dev/null > +++ b/Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerPkg.dec > @@ -0,0 +1,23 @@ > +# ConfigurationManager.dec > +# > +# Copyright 2020 NXP > +# Copyright 2020 Puresoftware Ltd > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +# > + > +[Defines] > + PACKAGE_NAME = ConfigurationManagerPkg > + PACKAGE_GUID = 0222b1b1-247f-404e-bdc3-baab65f2ddd3 > + > +################################################################################ > +# > +# Include Section - list of Include Paths that are provided by this package. > +# Comments are used for Keywords and Module Types. > +# > +# Supported Module Types: > +# BASE SEC PEI_CORE PEIM DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SMM_DRIVER DXE_SAL_DRIVER UEFI_DRIVER UEFI_APPLICATION > +# > +################################################################################ > +[Includes] > + Include > diff --git a/Platform/NXP/ConfigurationManagerPkg/Include/PlatformAcpiTableGenerator.h b/Platform/NXP/ConfigurationManagerPkg/Include/PlatformAcpiTableGenerator.h > new file mode 100644 > index 0000000..c1ec114 > --- /dev/null > +++ b/Platform/NXP/ConfigurationManagerPkg/Include/PlatformAcpiTableGenerator.h > @@ -0,0 +1,20 @@ > +/** @file > + Acpi Table generator headers > + > + Copyright 2020 NXP > + Copyright 2020 Puresoftware Ltd > + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef PLATFORM_ACPI_TABLE_GENERATOR_H > +#define PLATFORM_ACPI_TABLE_GENERATOR_H > + > +typedef enum PlatAcpiTableId { > + PlatAcpiTableIdReserved = 0x0000, ///< Reserved > + PlatAcpiTableIdDsdt, > + PlatAcpiTableIdMax > +} PLAT_ACPI_TABLE_ID; > + > +#endif // PLATFORM_ACPI_TABLE_GENERATOR_H > diff --git a/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl b/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl > new file mode 100644 > index 0000000..1008476 > --- /dev/null > +++ b/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl > @@ -0,0 +1,40 @@ > +/** @file > + Differentiated System Description Table Fields (DSDT) > + > + Copyright 2020 NXP > + Copyright 2020 Puresoftware Ltd > + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +Scope(_SB) > +{ > + Device(PCLK) { > + Name(_HID, "NXP0017") > + Name(CLK, 0) > + Name(AVBL, 0) > + OperationRegion(RCWS, SystemMemory, DCFG_BASE, DCFG_LEN) > + Method(_REG,2) { > + if (Arg0 == "RCWS") { > + Store(Arg1, AVBL) > + } > + } > + Field (RCWS, ByteAcc, NoLock, Preserve) { > + offset(0x100), > + PCFG, 2, > + PRAT, 6, > + offset(0x124), > + RESV, 4, > + SFRQ, 10 > + } > + > + Method(_INI, 0, NotSerialized) { > + Store(SFRQ, Local0) > + Multiply(Local0, 500000, Local0) > + Multiply(Local0, PRAT, Local0) > + Divide(Local0, 6, , Local0) > + Store(Local0, CLK) > + } > + } > +} // end of device PCLK > diff --git a/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl b/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl > new file mode 100644 > index 0000000..e4f04ce > --- /dev/null > +++ b/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl > @@ -0,0 +1,15 @@ > +/** @file > + Differentiated System Description Table Fields (DSDT) > + > + Copyright 2020 NXP > + Copyright 2020 Puresoftware Ltd. > + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include "Platform.h" > + > +DefinitionBlock("DsdtTable.aml", "DSDT", 2, "NXP ", "LX2160 ", EFI_ACPI_ARM_OEM_REVISION) { > + include ("Clk.asl") > +} > diff --git a/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf b/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf > new file mode 100644 > index 0000000..ac7d0b6 > --- /dev/null > +++ b/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf > @@ -0,0 +1,39 @@ > +## @file > +# Raw Table Generator > +# > +# Copyright 2020 NXP > +# Copyright 2020 Puresoftware Ltd > +# > +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +[Defines] > + INF_VERSION = 0x00010019 > + BASE_NAME = PlatformAcpiDsdtLib > + FILE_GUID = 0b1768cf-13fa-4ecf-b640-338a636d1abb > + VERSION_STRING = 1.0 > + MODULE_TYPE = DXE_DRIVER > + LIBRARY_CLASS = NULL|DXE_DRIVER > + CONSTRUCTOR = AcpiDsdtLibConstructor > + DESTRUCTOR = AcpiDsdtLibDestructor > + > +[Sources] > + PlatformAcpiDsdtLib/RawDsdtGenerator.c > + Dsdt/Dsdt.asl > + > +[Packages] > + DynamicTablesPkg/DynamicTablesPkg.dec > + EmbeddedPkg/EmbeddedPkg.dec > + MdePkg/MdePkg.dec > + MdeModulePkg/MdeModulePkg.dec > + Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec > + > +[LibraryClasses] > + BaseLib > + > +[Pcd] > + > +[Protocols] > + > +[Guids] > + Please drop blank trailing lines (git complains about this when I import the patch). > diff --git a/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c b/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c > new file mode 100644 > index 0000000..375598c > --- /dev/null > +++ b/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c > @@ -0,0 +1,146 @@ > +/** @file > + Raw DSDT Table Generator > + > + Copyright 2020 NXP > + Copyright 2020 Puresoftware Ltd. > + > + SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > +#include > + > +// Module specific include files. > +#include > +#include > +#include > +#include > +#include > + > +#include "PlatformAcpiLib.h" > + > +/** Construct the ACPI table using the ACPI table data provided. > + > + This function invokes the Configuration Manager protocol interface > + to get the required hardware information for generating the ACPI > + table. > + > + If this function allocates any resources then they must be freed > + in the FreeXXXXTableResources function. > + > + @param [in] This Pointer to the table generator. > + @param [in] AcpiTableInfo Pointer to the ACPI Table Info. > + @param [in] CfgMgrProtocol Pointer to the Configuration Manager > + Protocol Interface. > + @param [out] Table Pointer to the constructed ACPI Table. > + > + @retval EFI_SUCCESS Table generated successfully. > + @retval EFI_INVALID_PARAMETER A parameter is invalid. > +**/ > +STATIC > +EFI_STATUS > +EFIAPI > +BuildRawDsdtTable ( > + IN CONST ACPI_TABLE_GENERATOR * CONST This, > + IN CONST CM_STD_OBJ_ACPI_TABLE_INFO * CONST AcpiTableInfo, > + IN CONST EDKII_CONFIGURATION_MANAGER_PROTOCOL * CONST CfgMgrProtocol, > + OUT EFI_ACPI_DESCRIPTION_HEADER ** CONST Table > + ) > +{ > + ASSERT (This != NULL); > + ASSERT (AcpiTableInfo != NULL); > + ASSERT (CfgMgrProtocol != NULL); > + ASSERT (Table != NULL); > + ASSERT (AcpiTableInfo->TableGeneratorId == This->GeneratorID); > + > + if (AcpiTableInfo->AcpiTableData == NULL) { > + // Add the dsdt aml code here, Currently NULL place holder. > + *Table = (EFI_ACPI_DESCRIPTION_HEADER *)&dsdt_aml_code; > + } > + > + return EFI_SUCCESS; > +} > + > +/** This macro defines the Raw Generator revision. > +*/ > +#define DSDT_GENERATOR_REVISION CREATE_REVISION (1, 0) > + > +/** The interface for the Raw Table Generator. > +*/ > +STATIC > +CONST > +ACPI_TABLE_GENERATOR RawDsdtGenerator = { > + // Generator ID > + CREATE_OEM_ACPI_TABLE_GEN_ID (PlatAcpiTableIdDsdt), > + // Generator Description > + L"ACPI.OEM.RAW.DSDT.GENERATOR", > + // ACPI Table Signature - Unused > + 0, > + // ACPI Table Revision - Unused > + 0, > + // Minimum ACPI Table Revision - Unused > + 0, > + // Creator ID > + TABLE_GENERATOR_CREATOR_ID_ARM, > + // Creator Revision > + DSDT_GENERATOR_REVISION, > + // Build Table function > + BuildRawDsdtTable, > + // No additional resources are allocated by the generator. > + // Hence the Free Resource function is not required. > + NULL, > + // Extended build function not needed > + NULL, > + // Extended build function not implemented by the generator. > + // Hence extended free resource function is not required. > + NULL > +}; > + > +/** Register the Generator with the ACPI Table Factory. > + > + @param [in] ImageHandle The handle to the image. > + @param [in] SystemTable Pointer to the System Table. > + > + @retval EFI_SUCCESS The Generator is registered. > + @retval EFI_INVALID_PARAMETER A parameter is invalid. > + @retval EFI_ALREADY_STARTED The Generator for the Table ID > + is already registered. > +**/ > +EFI_STATUS > +EFIAPI > +AcpiDsdtLibConstructor ( > + IN CONST EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE * CONST SystemTable > + ) > +{ > + EFI_STATUS Status; > + Status = RegisterAcpiTableGenerator (&RawDsdtGenerator); > + DEBUG ((DEBUG_INFO, "OEM: Register DSDT Generator. Status = %r\n", Status)); > + ASSERT_EFI_ERROR (Status); > + return Status; > +} > + > +/** Deregister the Generator from the ACPI Table Factory. > + > + @param [in] ImageHandle The handle to the image. > + @param [in] SystemTable Pointer to the System Table. > + > + @retval EFI_SUCCESS The Generator is deregistered. > + @retval EFI_INVALID_PARAMETER A parameter is invalid. > + @retval EFI_NOT_FOUND The Generator is not registered. > +**/ > +EFI_STATUS > +EFIAPI > +AcpiDsdtLibDestructor ( > + IN CONST EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE * CONST SystemTable > + ) > +{ > + EFI_STATUS Status; > + Status = DeregisterAcpiTableGenerator (&RawDsdtGenerator); > + DEBUG ((DEBUG_INFO, "OEM: Deregister DSDT Generator. Status = %r\n", Status)); > + ASSERT_EFI_ERROR (Status); > + return Status; > +} > diff --git a/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h b/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h > new file mode 100644 > index 0000000..3ab2fd0 > --- /dev/null > +++ b/Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h > @@ -0,0 +1,24 @@ > +/** @file > + * Acpi lib headers > + * > + * Copyright 2020 NXP > + * Copyright 2020 Puresoftware Ltd > + * > + * SPDX-License-Identifier: BSD-2-Clause-Patent > + * > +**/ > + > + > +#ifndef LX2160ARDB_PLATFORM_ACPI_LIB_H > +#define LX2160ARDB_PLATFORM_ACPI_LIB_H > + > +#include > + > +/** C array containing the compiled AML template. > + These symbols are defined in the auto generated C file > + containing the AML bytecode array. > +*/ > +extern CHAR8 dsdt_aml_code[]; > + > +#endif > + Please drop blank traling lines. > diff --git a/Platform/NXP/LX2160aRdbPkg/Include/Platform.h b/Platform/NXP/LX2160aRdbPkg/Include/Platform.h > index e11ac37..76a41d4 100644 > --- a/Platform/NXP/LX2160aRdbPkg/Include/Platform.h > +++ b/Platform/NXP/LX2160aRdbPkg/Include/Platform.h > @@ -21,6 +21,10 @@ > > #define SVR_LX2160A 0x873600 > > +// PCLK > +#define DCFG_BASE 0x1E00000 > +#define DCFG_LEN 0x1FFFF > + > // Gic > #define GIC_VERSION 3 > #define GICD_BASE 0x6000000 > @@ -80,6 +84,8 @@ > > // Platform specific info needed by Configuration Manager > > +#define OEM_ACPI_TABLES 1 // OEM defined DSDT > + > #define CFG_MGR_TABLE_ID SIGNATURE_64 ('L','X','2','1','6','0',' ',' ') > > #define PLAT_PCI_SEG0_CONFIG_BASE LX2160A_PCI_SEG0_CONFIG_BASE > diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec > index 459440c..8f10d96 100644 > --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec > +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec > @@ -22,3 +22,6 @@ > ################################################################################ > [Includes.common] > Include # Root include for the package > + . No. This is neither permitted nor required. A package cannot declare include paths outside itself, and you can always #include "file.h" without needing it on the path. > + AcpiTablesInclude > + Platform/NXP/ConfigurationManagerPkg/Include You cannot have one package declaring the include paths of another package. Whatever module wants to grab header files from Platform/NXP/ConfigurationManagerPkg/Include needs to include Platform/NXP/ConfigurationManagerPkg.dec / Leif > diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc > index 6ba429d..9d898f2 100644 > --- a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc > +++ b/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc > @@ -82,6 +82,7 @@ > NULL|DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/AcpiMadtLibArm.inf > NULL|DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/AcpiMcfgLibArm.inf > NULL|DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/AcpiSpcrLibArm.inf > + NULL|Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf > } > !endif > > -- > 2.7.4 >