* [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables
@ 2021-02-15 18:29 PierreGondois
2021-02-15 20:04 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: PierreGondois @ 2021-02-15 18:29 UTC (permalink / raw)
To: devel, Alexei.Fedorov, leif, sami.mujawar
From: Pierre Gondois <Pierre.Gondois@arm.com>
Building the DynamicTablesPkg for a NOOPT target
fails because unused variables are set.
Remove these variables.
Fixes: d9800046ea43
Reported-by: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
---
.../Library/Common/AmlLib/NameSpace/AmlNameSpace.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
index 2d055e9fb964..8da47405af85 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
+++ b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
@@ -1,7 +1,7 @@
/** @file
AML NameSpace.
- Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.<BR>
+ Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -1075,10 +1075,8 @@ AmlEnumeratePathCallback (
AML_PATH_SEARCH_CONTEXT * PathSearchContext;
AML_STREAM * SearchPathBStream;
- CHAR8 * SearchedPath;
AML_STREAM * CurrNodePathBStream;
- CHAR8 * CurrNodePath;
UINT32 CurrNodePathSize;
ContinueEnum = TRUE;
@@ -1123,9 +1121,6 @@ AmlEnumeratePathCallback (
goto exit_handler;
}
- SearchedPath = (CHAR8*)AmlStreamGetCurrPos (SearchPathBStream);
- CurrNodePath = (CHAR8*)AmlStreamGetCurrPos (CurrNodePathBStream);
-
// Get the raw AML absolute pathname of the current node.
Status1 = AmlGetRawNameSpacePath (Node, 0, CurrNodePathBStream);
if (EFI_ERROR (Status1)) {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables
2021-02-15 18:29 [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables PierreGondois
@ 2021-02-15 20:04 ` Leif Lindholm
2021-02-15 23:37 ` Sami Mujawar
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2021-02-15 20:04 UTC (permalink / raw)
To: Pierre.Gondois; +Cc: devel, Alexei.Fedorov, sami.mujawar
On Mon, Feb 15, 2021 at 18:29:57 +0000, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> Building the DynamicTablesPkg for a NOOPT target
> fails because unused variables are set.
> Remove these variables.
>
> Fixes: d9800046ea43
> Reported-by: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
(also build tested)
Thanks for quick turnaround!
> ---
> .../Library/Common/AmlLib/NameSpace/AmlNameSpace.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
> index 2d055e9fb964..8da47405af85 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
> @@ -1,7 +1,7 @@
> /** @file
> AML NameSpace.
>
> - Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.<BR>
> + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
> @@ -1075,10 +1075,8 @@ AmlEnumeratePathCallback (
> AML_PATH_SEARCH_CONTEXT * PathSearchContext;
>
> AML_STREAM * SearchPathBStream;
> - CHAR8 * SearchedPath;
>
> AML_STREAM * CurrNodePathBStream;
> - CHAR8 * CurrNodePath;
> UINT32 CurrNodePathSize;
>
> ContinueEnum = TRUE;
> @@ -1123,9 +1121,6 @@ AmlEnumeratePathCallback (
> goto exit_handler;
> }
>
> - SearchedPath = (CHAR8*)AmlStreamGetCurrPos (SearchPathBStream);
> - CurrNodePath = (CHAR8*)AmlStreamGetCurrPos (CurrNodePathBStream);
> -
> // Get the raw AML absolute pathname of the current node.
> Status1 = AmlGetRawNameSpacePath (Node, 0, CurrNodePathBStream);
> if (EFI_ERROR (Status1)) {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables
2021-02-15 20:04 ` Leif Lindholm
@ 2021-02-15 23:37 ` Sami Mujawar
0 siblings, 0 replies; 3+ messages in thread
From: Sami Mujawar @ 2021-02-15 23:37 UTC (permalink / raw)
To: Leif Lindholm, Pierre Gondois; +Cc: devel@edk2.groups.io, Alexei Fedorov, nd
Pushed as 2e1e8c35f317..4f4d862c1c72
Thanks,
Sami Mujawar
-----Original Message-----
From: Leif Lindholm <leif@nuviainc.com>
Sent: 15 February 2021 08:04 PM
To: Pierre Gondois <Pierre.Gondois@arm.com>
Cc: devel@edk2.groups.io; Alexei Fedorov <Alexei.Fedorov@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>
Subject: Re: [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables
On Mon, Feb 15, 2021 at 18:29:57 +0000, Pierre.Gondois@arm.com wrote:
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> Building the DynamicTablesPkg for a NOOPT target
> fails because unused variables are set.
> Remove these variables.
>
> Fixes: d9800046ea43
> Reported-by: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
(also build tested)
Thanks for quick turnaround!
> ---
> .../Library/Common/AmlLib/NameSpace/AmlNameSpace.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
> index 2d055e9fb964..8da47405af85 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c
> @@ -1,7 +1,7 @@
> /** @file
> AML NameSpace.
>
> - Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.<BR>
> + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> **/
> @@ -1075,10 +1075,8 @@ AmlEnumeratePathCallback (
> AML_PATH_SEARCH_CONTEXT * PathSearchContext;
>
> AML_STREAM * SearchPathBStream;
> - CHAR8 * SearchedPath;
>
> AML_STREAM * CurrNodePathBStream;
> - CHAR8 * CurrNodePath;
> UINT32 CurrNodePathSize;
>
> ContinueEnum = TRUE;
> @@ -1123,9 +1121,6 @@ AmlEnumeratePathCallback (
> goto exit_handler;
> }
>
> - SearchedPath = (CHAR8*)AmlStreamGetCurrPos (SearchPathBStream);
> - CurrNodePath = (CHAR8*)AmlStreamGetCurrPos (CurrNodePathBStream);
> -
> // Get the raw AML absolute pathname of the current node.
> Status1 = AmlGetRawNameSpacePath (Node, 0, CurrNodePathBStream);
> if (EFI_ERROR (Status1)) {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-15 23:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-15 18:29 [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables PierreGondois
2021-02-15 20:04 ` Leif Lindholm
2021-02-15 23:37 ` Sami Mujawar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox