From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.groups.io with SMTP id smtpd.web09.36951.1613419451005656474 for ; Mon, 15 Feb 2021 12:04:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=cKv4WKDH; spf=pass (domain: nuviainc.com, ip: 209.85.221.44, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f44.google.com with SMTP id g6so10391573wrs.11 for ; Mon, 15 Feb 2021 12:04:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=m3WGWZNFTqwT1+/U57JDjiUZ9+fFbfyNiNk121Hi76o=; b=cKv4WKDH7ih9LIpnYs3diBi8E+tKBtJwB2wkTmKO4/IYVm9N2ZffGDeXJ3gkDyS+JB Oe0QSj2ReH3ES85qTA3ZRZW7M6xosVz9z/5c9HlJPRoKVxFHe0OWEaZLaceiGJcA5eJz EH1kTbNgsgv6IM5E9y49XIxWVT48C+IuQlCNqV2AA58zyLeqTdaSQi1RPSQepxZn5bbB Z5T86eHfUnQrerK+UkihPwDkW2bTUS0WRE+Idhp5VK0SAZx64lxSwUJxDkS+vQ8uCavq 7HZzczyd9deuYfK1EKrkykokuOsXU3iAb8ZHtzjIuSK5ZElOfhV4Wk5pPg4qtLRKSpiy avSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=m3WGWZNFTqwT1+/U57JDjiUZ9+fFbfyNiNk121Hi76o=; b=HcfWJJGlgKtSUiDeahizPL0M9aW4TEo7m5qc0jmhkd2ftJW86J5J2nq6NlACqG0f65 2lL8XM7v1vCuPuDdeHNDe2wk1KVzpfIoMmkxe6unFEqE9hKkJJ+GGXsF3NAh6ICSmiAD P+oTgODyRBi7j642b1lHn9jnyBvoF484Qr4OM/OxD8S95O0vTy4+HT458e12NcvLU1or 18UaHVfjzlfMjhQt5P2AOjLT0cq+iyIXktL/B/zGHAZRu8TdtmOLGpmKDlkKHUOuPn+p ONp367pTH3E/lo3xBlFPjyVjb/toHw4Wsx43KC56jEDe7nmHukC3qp+Ita3PeBSSy2bO mIIg== X-Gm-Message-State: AOAM533ujagqCuL/n9Qj1XbivH81JLegeRCtJE6rLbV49ogsL56m4uty fwxA0qraNpYnF8fH4hs4kAQdPQ== X-Google-Smtp-Source: ABdhPJwyhARFrN8Ggk6N6oLJEs4hciy+O7cAeOTPcKIGS8hfpk67ngyUdO+Lphjs7fY2RDf0zpLzOg== X-Received: by 2002:a05:6000:8b:: with SMTP id m11mr6716386wrx.240.1613419449610; Mon, 15 Feb 2021 12:04:09 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id a9sm22275448wrn.60.2021.02.15.12.04.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Feb 2021 12:04:09 -0800 (PST) Date: Mon, 15 Feb 2021 20:04:07 +0000 From: "Leif Lindholm" To: Pierre.Gondois@arm.com Cc: devel@edk2.groups.io, Alexei.Fedorov@arm.com, sami.mujawar@arm.com Subject: Re: [PATCH 1/1] DynamicTablesPkg/AmlLib: Remove unused variables Message-ID: <20210215200407.GE1664@vanye> References: <20210215182957.14642-1-Pierre.Gondois@arm.com> MIME-Version: 1.0 In-Reply-To: <20210215182957.14642-1-Pierre.Gondois@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 15, 2021 at 18:29:57 +0000, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > Building the DynamicTablesPkg for a NOOPT target > fails because unused variables are set. > Remove these variables. > > Fixes: d9800046ea43 > Reported-by: Leif Lindholm > Signed-off-by: Pierre Gondois Reviewed-by: Leif Lindholm (also build tested) Thanks for quick turnaround! > --- > .../Library/Common/AmlLib/NameSpace/AmlNameSpace.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c > index 2d055e9fb964..8da47405af85 100644 > --- a/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c > +++ b/DynamicTablesPkg/Library/Common/AmlLib/NameSpace/AmlNameSpace.c > @@ -1,7 +1,7 @@ > /** @file > AML NameSpace. > > - Copyright (c) 2019 - 2020, Arm Limited. All rights reserved.
> + Copyright (c) 2019 - 2021, Arm Limited. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > @@ -1075,10 +1075,8 @@ AmlEnumeratePathCallback ( > AML_PATH_SEARCH_CONTEXT * PathSearchContext; > > AML_STREAM * SearchPathBStream; > - CHAR8 * SearchedPath; > > AML_STREAM * CurrNodePathBStream; > - CHAR8 * CurrNodePath; > UINT32 CurrNodePathSize; > > ContinueEnum = TRUE; > @@ -1123,9 +1121,6 @@ AmlEnumeratePathCallback ( > goto exit_handler; > } > > - SearchedPath = (CHAR8*)AmlStreamGetCurrPos (SearchPathBStream); > - CurrNodePath = (CHAR8*)AmlStreamGetCurrPos (CurrNodePathBStream); > - > // Get the raw AML absolute pathname of the current node. > Status1 = AmlGetRawNameSpacePath (Node, 0, CurrNodePathBStream); > if (EFI_ERROR (Status1)) { > -- > 2.17.1 >