From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <ardb+tianocore@kernel.org>,
<thomas.abraham@arm.com>, <leif@nuviainc.com>,
<Matteo.Carlini@arm.com>, <Ben.Adderson@arm.com>, <nd@arm.com>
Subject: [PATCH edk2-platforms v1 1/1] Platform/ARM/VExpressPkg: Remove non-ASCII characters
Date: Wed, 17 Feb 2021 16:10:36 +0000 [thread overview]
Message-ID: <20210217161036.17708-1-sami.mujawar@arm.com> (raw)
The patch at "4be8625ab1b008057ae9a500aa8978be2a02d6e2
Platform/ARM/VExpressPkg: Add support for FVP RevC model"
introduced a new file SsdtPci.asl. The file SsdtPci.asl
had a few non-ASCII characters in the code comments.
These resulted in the Trim utility generating a warning
that caused the firmware build to fail on a Linux
development PC.
Therefore, remove the non-ASCII characters as it results
in builds failures on a Linux development PC.
Note: This issue was not observed on a Windows development
PC.
Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---
The changes can be seen at:
https://github.com/samimujawar/edk2-platforms/tree/1650_fix_non_ascii_chars_v1
Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
index e4b5a02cc9571743c4a0300a0657f090ae996326..deabeb08c848d7d66f11fa53f7001ed14b74f193 100644
--- a/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
+++ b/Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
@@ -51,7 +51,7 @@
/*
See Reference [1] 6.1.1
- "High word�Device #, Low word�Function #. (for example, device 3,
+ "High word Device #, Low word Function #. (for example, device 3,
function 2 is 0x00030002). To refer to all the functions on a device #,
use a function number of FFFF)."
*/
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next reply other threads:[~2021-02-17 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 16:10 Sami Mujawar [this message]
2021-02-17 16:21 ` [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM/VExpressPkg: Remove non-ASCII characters Thomas Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217161036.17708-1-sami.mujawar@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox