From: "Sughosh Ganu" <sughosh.ganu@linaro.org>
To: devel@edk2.groups.io
Cc: Sami Mujawar <sami.mujawar@arm.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: [PATCH v5 00/14] Add support for using FF-A calls
Date: Fri, 19 Feb 2021 12:05:53 +0530 [thread overview]
Message-ID: <20210219063607.27920-1-sughosh.ganu@linaro.org> (raw)
The following patch series adds support for using the Firmware
Framework(FF-A) as a transport mechanism for requesting services from
the Secure Partition Manager(SPM). This is done through a Pcd which
can be used to enable the FF-A mechanism or to use the earlier used
SVC calls.
The patches have been pushed to my github repository[1]
Ran the CI tests through the github draft pull request, and all the CI
test pass. Ran the PatchCheck script, with no errors.
Changes since V4:
* Define all variable Pcd's under the [Pcd] section instead of
[FixedPcd], as suggested by Liming Gao
Changes since V3:
* Put the PcdFfaEnable under the PcdsFeatureFlag.AARCH64 section to
avoid build breakage for the X64 StandaloneMm builds.
* Put the macro definitions for the SPM major and minor versions in a
separate patch, as suggested by Sami.
* Separated out the declaration of the SPM major and minor version
macros in the earlier patch as was suggested by Sami.
* Put the macro definitions for the SPM major and minor versions with
FF-A support in a separate patch, as suggested by Sami.
* Declare the PcdFfaEnable Pcd Feature flag under FeaturePcd.AARCH64
to avoid build break for the X64 build of StandaloneMm.
* Change the patch header to have the ArmPkg prefix instead of
StandaloneMmMmuLib as suggested by Sami.
Changes since V2:
* Added a STATIC storage class specifier for mSpmMajorVer and
mSpmMinorVer variables
* Added a STATIC storage class specifier for mSpmMajorVerFfa and
mSpmMinorVerFfa variables
* Add braces for if/else statements
* Add a check for EFI_NOT_FOUND as a possible return value from
LocateStandaloneMmCorePeCoffData in _ModuleEntryPoint function
* Check for the return value in Arg0 after the Direct Request call to
handle errors returned
* Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS
response won't be expected in return to a Direct Request call to get
the memory attributes
* Check for the return value in Arg0 after the Direct Request call to
handle errors returned
* Put a comment to reflect the fact that FFA_INTERRUPT and FFA_SUCCESS
response won't be expected in return to a Direct Request call to set
the memory attributes
Changes since V1:
Handled review comments from Sami Mujawar
[1] - https://github.com/sughoshg/edk2/tree/implement_ffa_svc_optional_v5
Achin Gupta (7):
ArmPkg/IndustryStandard: Add barebones FF-A header
ArmPkg/ArmSvcLib: Return x4-x7 in output parameters
StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry
point
StandaloneMmPkg: Add option to use FF-A calls for communication with
SPM
ArmPkg: Use FF-A header file in Standalone MM Arm MMU library
ArmPkg: Allow FF-A calls to get memory region's attributes
ArmPkg: Allow FF-A calls to set memory region's attributes
Ilias Apalodimas (2):
MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase
to Pcd
StandaloneMmPkg: Allow sending FFA Direct Request message to
StandaloneMm
Sughosh Ganu (5):
ArmPkg: Introduce support for PcdFfaEnable
ArmPkg: Add macros for SPM version
StandaloneMmPkg: Use macros for SPM version check
ArmPkg: Add macros for SPM version with FF-A support enabled
StandaloneMmPkg: Add option to use FF-A calls for getting SPM version
ArmPkg/ArmPkg.dec | 7 +
.../ArmMmuStandaloneMmLib.inf | 3 +
.../RuntimeDxe/VariableStandaloneMm.inf | 4 +-
.../StandaloneMmCoreEntryPoint.inf | 3 +
ArmPkg/Include/IndustryStandard/ArmFfaSvc.h | 44 +++++
ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 3 +
ArmPkg/Include/Library/ArmSvcLib.h | 10 +-
.../AArch64/ArmMmuStandaloneMmLib.c | 167 +++++++++++++++---
.../StandaloneMmCpu/AArch64/EventHandle.c | 4 +-
.../AArch64/StandaloneMmCoreEntryPoint.c | 133 +++++++++++---
ArmPkg/Library/ArmSvcLib/AArch64/ArmSvc.S | 4 +-
11 files changed, 321 insertions(+), 61 deletions(-)
create mode 100644 ArmPkg/Include/IndustryStandard/ArmFfaSvc.h
--
2.17.1
next reply other threads:[~2021-02-19 6:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 6:35 Sughosh Ganu [this message]
2021-02-19 6:35 ` [PATCH v5 01/14] ArmPkg/IndustryStandard: Add barebones FF-A header Sughosh Ganu
2021-02-19 6:35 ` [PATCH v5 02/14] ArmPkg/ArmSvcLib: Return x4-x7 in output parameters Sughosh Ganu
2021-02-19 6:35 ` [PATCH v5 03/14] StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point Sughosh Ganu
2021-02-19 6:35 ` [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable Sughosh Ganu
2021-02-22 9:28 ` [edk2-devel] " Sami Mujawar
2021-02-22 10:48 ` Ard Biesheuvel
2021-02-22 11:47 ` Sughosh Ganu
2021-02-22 14:05 ` Ard Biesheuvel
2021-02-19 6:35 ` [PATCH v5 05/14] ArmPkg: Add macros for SPM version Sughosh Ganu
2021-02-22 9:30 ` [edk2-devel] " Sami Mujawar
2021-02-19 6:35 ` [PATCH v5 06/14] StandaloneMmPkg: Use macros for SPM version check Sughosh Ganu
2021-02-22 9:31 ` [edk2-devel] " Sami Mujawar
2021-02-19 6:36 ` [PATCH v5 07/14] ArmPkg: Add macros for SPM version with FF-A support enabled Sughosh Ganu
2021-02-22 9:32 ` [edk2-devel] " Sami Mujawar
2021-02-19 6:36 ` [PATCH v5 08/14] StandaloneMmPkg: Add option to use FF-A calls for getting SPM version Sughosh Ganu
2021-02-22 9:37 ` [edk2-devel] " Sami Mujawar
2021-02-19 6:36 ` [PATCH v5 09/14] StandaloneMmPkg: Add option to use FF-A calls for communication with SPM Sughosh Ganu
2021-02-19 6:36 ` [PATCH v5 10/14] ArmPkg: Use FF-A header file in Standalone MM Arm MMU library Sughosh Ganu
2021-02-19 6:36 ` [PATCH v5 11/14] ArmPkg: Allow FF-A calls to get memory region's attributes Sughosh Ganu
2021-02-22 9:38 ` [edk2-devel] " Sami Mujawar
2021-02-19 6:36 ` [PATCH v5 12/14] ArmPkg: Allow FF-A calls to set " Sughosh Ganu
2021-02-19 6:36 ` [PATCH v5 13/14] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd Sughosh Ganu
2021-02-19 6:36 ` [PATCH v5 14/14] StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm Sughosh Ganu
2021-02-22 14:10 ` [PATCH v5 00/14] Add support for using FF-A calls Ard Biesheuvel
2021-02-22 15:19 ` Sughosh Ganu
2021-02-23 16:04 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219063607.27920-1-sughosh.ganu@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox