public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sughosh Ganu" <sughosh.ganu@linaro.org>
To: devel@edk2.groups.io
Cc: Sami Mujawar <sami.mujawar@arm.com>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: [PATCH v5 13/14] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd
Date: Fri, 19 Feb 2021 12:06:06 +0530	[thread overview]
Message-ID: <20210219063607.27920-14-sughosh.ganu@linaro.org> (raw)
In-Reply-To: <20210219063607.27920-1-sughosh.ganu@linaro.org>

From: Ilias Apalodimas <ilias.apalodimas@linaro.org>

Instead of running StMM in SPM, OP-TEE creates a new secure partition,
which emulates SPM and isolates StMM from the rest of the Trusted
Applications (TAs). We can then compile StMM as an FD image and run it
in OP-TEE. With the addition of a new RPMB driver, we can leverage OP-TEE
and store variables to an RPMB device.

Since EDK2 upper layers expect byte addressable code, for the RPMB to
work, we need to allocate memory and sync it with the hardware on
read/writes. Since DynamicPCDs are not supported in that context we
can only use PatchablePCDs. So let's switch them to Pcd instead of
FixedPcd and accomodate the new driver. While at it, move the rest
of the variables under Pcd section, instead of FixedPcd -- this is in
line with how the variables are defined in the other Variable
modules.

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
---

Changes since V4:
* Define all variable Pcd's under the [Pcd] section instead of
  [FixedPcd], as suggested by Liming Gao

 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf
index fada0bf3c5..d8c4f77e7f 100644
--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf
+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf
@@ -119,10 +119,10 @@
   ## SOMETIMES_PRODUCES   ## Variable:L"VarErrorFlag"
   gEdkiiVarErrorFlagGuid
 
-[FixedPcd]
-  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize       ## CONSUMES
+[Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase       ## SOMETIMES_CONSUMES
   gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase64     ## CONSUMES
+  gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize       ## CONSUMES
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize                  ## CONSUMES
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize              ## CONSUMES
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVolatileVariableSize          ## CONSUMES
-- 
2.17.1


  parent reply	other threads:[~2021-02-19  6:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-19  6:35 [PATCH v5 00/14] Add support for using FF-A calls Sughosh Ganu
2021-02-19  6:35 ` [PATCH v5 01/14] ArmPkg/IndustryStandard: Add barebones FF-A header Sughosh Ganu
2021-02-19  6:35 ` [PATCH v5 02/14] ArmPkg/ArmSvcLib: Return x4-x7 in output parameters Sughosh Ganu
2021-02-19  6:35 ` [PATCH v5 03/14] StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point Sughosh Ganu
2021-02-19  6:35 ` [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable Sughosh Ganu
2021-02-22  9:28   ` [edk2-devel] " Sami Mujawar
2021-02-22 10:48   ` Ard Biesheuvel
2021-02-22 11:47     ` Sughosh Ganu
2021-02-22 14:05       ` Ard Biesheuvel
2021-02-19  6:35 ` [PATCH v5 05/14] ArmPkg: Add macros for SPM version Sughosh Ganu
2021-02-22  9:30   ` [edk2-devel] " Sami Mujawar
2021-02-19  6:35 ` [PATCH v5 06/14] StandaloneMmPkg: Use macros for SPM version check Sughosh Ganu
2021-02-22  9:31   ` [edk2-devel] " Sami Mujawar
2021-02-19  6:36 ` [PATCH v5 07/14] ArmPkg: Add macros for SPM version with FF-A support enabled Sughosh Ganu
2021-02-22  9:32   ` [edk2-devel] " Sami Mujawar
2021-02-19  6:36 ` [PATCH v5 08/14] StandaloneMmPkg: Add option to use FF-A calls for getting SPM version Sughosh Ganu
2021-02-22  9:37   ` [edk2-devel] " Sami Mujawar
2021-02-19  6:36 ` [PATCH v5 09/14] StandaloneMmPkg: Add option to use FF-A calls for communication with SPM Sughosh Ganu
2021-02-19  6:36 ` [PATCH v5 10/14] ArmPkg: Use FF-A header file in Standalone MM Arm MMU library Sughosh Ganu
2021-02-19  6:36 ` [PATCH v5 11/14] ArmPkg: Allow FF-A calls to get memory region's attributes Sughosh Ganu
2021-02-22  9:38   ` [edk2-devel] " Sami Mujawar
2021-02-19  6:36 ` [PATCH v5 12/14] ArmPkg: Allow FF-A calls to set " Sughosh Ganu
2021-02-19  6:36 ` Sughosh Ganu [this message]
2021-02-19  6:36 ` [PATCH v5 14/14] StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm Sughosh Ganu
2021-02-22 14:10 ` [PATCH v5 00/14] Add support for using FF-A calls Ard Biesheuvel
2021-02-22 15:19   ` Sughosh Ganu
2021-02-23 16:04     ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210219063607.27920-14-sughosh.ganu@linaro.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox