From: "Leif Lindholm" <leif@nuviainc.com>
To: Vikas Singh <vikas.singh@puresoftware.com>
Cc: devel@edk2.groups.io, sami.mujawar@arm.com,
meenakshi.aggarwal@nxp.com, paul.yang@arm.com,
augustine.philips@arm.com, samer.el-haj-mahmoud@arm.com,
v.sethi@nxp.com, arokia.samy@puresoftware.com,
kuldip.dwivedi@puresoftware.com, ard.biesheuvel@arm.com,
vikas.singh@nxp.com
Subject: Re: [PATCH v3 0/2] Dynamic ACPI framework for fsl layerscape platforms
Date: Fri, 19 Feb 2021 22:48:34 +0000 [thread overview]
Message-ID: <20210219224834.GJ1664@vanye> (raw)
In-Reply-To: <1613552612-15642-1-git-send-email-vikas.singh@puresoftware.com>
On Wed, Feb 17, 2021 at 14:33:30 +0530, Vikas Singh wrote:
> This patch series sets the foundation of Dynamic ACPI framework for all
> fsl layerscape platforms. In order to achieve:
> - Configurable firmware builds.
> - Unify firmware build for similar platforms.
> - Minimize/eliminate human induced errors.
> - Validate and generate firmware that complies with relevant specifications.
> this change set will introduce following changes in below defined order under
> edk2-platforms/NXP for LX2160ARDB platform.
>
> (1) Introduced edk2-platforms/NXP/ConfigurationManager
> It creates the platform repositories dynamically during build time
> and initializes with platform specific information and serves all requestes
> coming from OEM/standard firmware table generators. Configuration Manager(CM)
> will be common for all fsl platforms.
>
> (2) Introduced edk2-platforms/NXP/LX2160ARDB/Include/Platform.h
> It has all the declarations and the definitions specified for the platforms.
> These definitions will be inturn consumed by Configuration Manager.
> Additionally the placement of this header under "Include" dir will make these
> macro's availale to other translation units of the platform built.
>
> (3) Introduced edk2-platforms/NXP/LX2160ARDB/AcpiTablesInclude
> This is a placeholder for - OEM specific firmware acpi table generators.
> This also includes IP specific - DSDT/SSDT generators for the OEM's platform.
> Currently Dsdt.asl is a place holder having only platform's clock related dsdt
> properties for LX2160ARDB but it is intended to extend this "Dsdt.asl" to hold
> other table as well in next patch series.
>
> (4) Introduced a new "DYNAMIC_ACPI_ENABLE" flag to control DACPI framework.
> Currently this flag is used for LX2160ARDB and by default it is enabled.
> This flag can also extend to other fsl layerscape platforms in future.
> Changes can be referred under:
> - LX2160ARDb.dsc
> - LX2160ARDB.fdf
>
> Vikas Singh (2):
> Platform/NXP: Add Dynamic Acpi for layerscape platforms
> Platform/NXP: Add OEM specific DSDT generator
For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
Pushed as bb1f054af0cf..f8926df263ad.
Thanks!
>
> Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c | 843 ++++++++++++++++++++
> Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.h | 153 ++++
> Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 52 ++
> Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerPkg.dec | 23 +
> Platform/NXP/ConfigurationManagerPkg/Include/PlatformAcpiTableGenerator.h | 20 +
> Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl | 40 +
> Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl | 15 +
> Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf | 39 +
> Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c | 146 ++++
> Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h | 23 +
> Platform/NXP/LX2160aRdbPkg/Include/Platform.h | 246 ++++++
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 29 +
> Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 12 +
> Silicon/NXP/LX2160A/LX2160A.dsc.inc | 10 +
> 14 files changed, 1651 insertions(+)
> create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c
> create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.h
> create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
> create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerPkg.dec
> create mode 100644 Platform/NXP/ConfigurationManagerPkg/Include/PlatformAcpiTableGenerator.h
> create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl
> create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl
> create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf
> create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c
> create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h
> create mode 100644 Platform/NXP/LX2160aRdbPkg/Include/Platform.h
>
> --
> 2.7.4
>
prev parent reply other threads:[~2021-02-19 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 9:03 [PATCH v3 0/2] Dynamic ACPI framework for fsl layerscape platforms Vikas Singh
2021-02-17 9:03 ` [PATCH v3 1/2] Platform/NXP: Add Dynamic Acpi for " Vikas Singh
2021-02-17 9:03 ` [PATCH v3 2/2] Platform/NXP: Add OEM specific DSDT generator Vikas Singh
2021-02-19 22:48 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219224834.GJ1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox