From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.groups.io with SMTP id smtpd.web10.1109.1613774920231484301 for ; Fri, 19 Feb 2021 14:48:40 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=qLexR06x; spf=pass (domain: nuviainc.com, ip: 209.85.128.49, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f49.google.com with SMTP id n10so8972698wmq.0 for ; Fri, 19 Feb 2021 14:48:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Zfq+xYwoKf1ZsVMR7zBMveaQlg641qzko2s1TuIbPcE=; b=qLexR06x4dpQ37SQIjcak7e5nVgzqKNnpRSLsTjC4FTJbBYWO1WkkZbVnCiUNXS6H9 N0iDrgft/ANgPw9hQaZFvXaUE0q86gis/TpW7StZmXmo/Lr6X4MMTaCVz/HSQ6YkM0ID ODv1cyyygpW4F7+Nht/MvR5//EKykBVvMXo+BgWsGpOmzZ6l7GtpATEmpsfxPdclbAl8 0T9/U5MilOIOL2lpq4Zdg2KN+a1vXjr95faMMJ706QSmZWRemQCBnxsM09utUdOKaJgz yxZhytQZICDMoVpuSOh0N8uIxfzNjNcsSACizOXLVHphViRZMDURUQblq82toEefRdQ+ PcFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Zfq+xYwoKf1ZsVMR7zBMveaQlg641qzko2s1TuIbPcE=; b=NLOZePst4wsWaPHnVhfduEsj3DGgi6f4H1PCesb8qug5y1cW01cw71lZdr1/pjpGfS 6KGsgwoQye74I1HTS5/qXs8hnBcjlEBcSu2kuYTdbjj2oYHq0l5AQnzdJ9Uw4b/OI1FF rAFUs5/Uxd8PJ4yr9gvh7mT+xCoMjIjakLofAaj/cKYktHg7gr0Nu4tiA1sEyv0HkqNS Z9wAeuXJRUJwiqEA8x8Y/iAW7pShz/dKiS5c3yvlsKn0WwDe7SFxIwkvR2Zpjl6ma0UC f90Rzyrc6WCWmcQAvVt17s+RIMWhnQpManfiYaikGWq2guxnycS54/pbGAqkCJTAlEbu GeLQ== X-Gm-Message-State: AOAM531OwBUNbI8eoTOCyHQ2Tp276FJ0gnOSN8kFJr0SemdVdZ+aHa7C AX9Us0+yJJNmScPtP3+AVhCshw== X-Google-Smtp-Source: ABdhPJyxW/uzBOcCHGg1NMQj8h9UyaQ9oo5rq4XmDSU1aANeZjwf2eM/KpQMK7IzgZQx1WnNvSB6Yg== X-Received: by 2002:a7b:c055:: with SMTP id u21mr10181974wmc.68.1613774918805; Fri, 19 Feb 2021 14:48:38 -0800 (PST) Return-Path: Received: from vanye ([82.27.183.148]) by smtp.gmail.com with ESMTPSA id z14sm15473578wrt.89.2021.02.19.14.48.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 14:48:38 -0800 (PST) Date: Fri, 19 Feb 2021 22:48:34 +0000 From: "Leif Lindholm" To: Vikas Singh Cc: devel@edk2.groups.io, sami.mujawar@arm.com, meenakshi.aggarwal@nxp.com, paul.yang@arm.com, augustine.philips@arm.com, samer.el-haj-mahmoud@arm.com, v.sethi@nxp.com, arokia.samy@puresoftware.com, kuldip.dwivedi@puresoftware.com, ard.biesheuvel@arm.com, vikas.singh@nxp.com Subject: Re: [PATCH v3 0/2] Dynamic ACPI framework for fsl layerscape platforms Message-ID: <20210219224834.GJ1664@vanye> References: <1613552612-15642-1-git-send-email-vikas.singh@puresoftware.com> MIME-Version: 1.0 In-Reply-To: <1613552612-15642-1-git-send-email-vikas.singh@puresoftware.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 17, 2021 at 14:33:30 +0530, Vikas Singh wrote: > This patch series sets the foundation of Dynamic ACPI framework for all > fsl layerscape platforms. In order to achieve: > - Configurable firmware builds. > - Unify firmware build for similar platforms. > - Minimize/eliminate human induced errors. > - Validate and generate firmware that complies with relevant specifications. > this change set will introduce following changes in below defined order under > edk2-platforms/NXP for LX2160ARDB platform. > > (1) Introduced edk2-platforms/NXP/ConfigurationManager > It creates the platform repositories dynamically during build time > and initializes with platform specific information and serves all requestes > coming from OEM/standard firmware table generators. Configuration Manager(CM) > will be common for all fsl platforms. > > (2) Introduced edk2-platforms/NXP/LX2160ARDB/Include/Platform.h > It has all the declarations and the definitions specified for the platforms. > These definitions will be inturn consumed by Configuration Manager. > Additionally the placement of this header under "Include" dir will make these > macro's availale to other translation units of the platform built. > > (3) Introduced edk2-platforms/NXP/LX2160ARDB/AcpiTablesInclude > This is a placeholder for - OEM specific firmware acpi table generators. > This also includes IP specific - DSDT/SSDT generators for the OEM's platform. > Currently Dsdt.asl is a place holder having only platform's clock related dsdt > properties for LX2160ARDB but it is intended to extend this "Dsdt.asl" to hold > other table as well in next patch series. > > (4) Introduced a new "DYNAMIC_ACPI_ENABLE" flag to control DACPI framework. > Currently this flag is used for LX2160ARDB and by default it is enabled. > This flag can also extend to other fsl layerscape platforms in future. > Changes can be referred under: > - LX2160ARDb.dsc > - LX2160ARDB.fdf > > Vikas Singh (2): > Platform/NXP: Add Dynamic Acpi for layerscape platforms > Platform/NXP: Add OEM specific DSDT generator For the series: Reviewed-by: Leif Lindholm Pushed as bb1f054af0cf..f8926df263ad. Thanks! > > Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c | 843 ++++++++++++++++++++ > Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.h | 153 ++++ > Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 52 ++ > Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerPkg.dec | 23 + > Platform/NXP/ConfigurationManagerPkg/Include/PlatformAcpiTableGenerator.h | 20 + > Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl | 40 + > Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl | 15 + > Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf | 39 + > Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c | 146 ++++ > Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h | 23 + > Platform/NXP/LX2160aRdbPkg/Include/Platform.h | 246 ++++++ > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 29 + > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 12 + > Silicon/NXP/LX2160A/LX2160A.dsc.inc | 10 + > 14 files changed, 1651 insertions(+) > create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c > create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.h > create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManagerDxe.inf > create mode 100644 Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerPkg.dec > create mode 100644 Platform/NXP/ConfigurationManagerPkg/Include/PlatformAcpiTableGenerator.h > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Clk.asl > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/Dsdt/Dsdt.asl > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib.inf > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiDsdtLib/RawDsdtGenerator.c > create mode 100644 Platform/NXP/LX2160aRdbPkg/AcpiTablesInclude/PlatformAcpiLib.h > create mode 100644 Platform/NXP/LX2160aRdbPkg/Include/Platform.h > > -- > 2.7.4 >