From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mx.groups.io with SMTP id smtpd.web12.12784.1613857578723497821 for ; Sat, 20 Feb 2021 13:46:19 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=YYM9D/aO; spf=pass (domain: nuviainc.com, ip: 209.85.128.51, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f51.google.com with SMTP id o82so10109630wme.1 for ; Sat, 20 Feb 2021 13:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=64HZs58/yzHECyGwsmGsKvvq7ykLSQQ0Qbq0D0wge6Y=; b=YYM9D/aO/jHRdYMU1LmGgU9xE9tjF/jkUNGl0wuOC7zWwmYxaI0kgBpDQGnC9R0f25 L27z9Q57/U5ucIHf3JOFvB6t5IPT3RJQOxHlfz+1r98gB2jIczoEZ0xNBztak6ZDANLG R/i0ub+n8oJSKK3gUcRm/RNKNbJv3ce7SEMDvRxsh9Ztga4QmtyXAxWNtco6zSb3UnGK ZkO7WfYEOJsV1ZDtLmb4I95srb6VHWefJGhZ7vQpw/w3xlrLiM9PnHr2qk5R8GOkg93h ADy5ngDQcKD+65YYnnZjlDMust/boZjB6fxc8+L3iqzF7YQxmhkAppO0Nd086LGjgl9A Cp1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=64HZs58/yzHECyGwsmGsKvvq7ykLSQQ0Qbq0D0wge6Y=; b=nen0M0xuLaigr1M8G5S/cr5DxYq+of4M69WtXKKFuQ2wVErFhqMsK8QprpAzgNKwlt 1KCapFAQHCQBrcE4ohA3f7fzYkgk435wpoyAT4tq0qlIFD/Su4d+eXmcAY6vVgmKJh1L F6G0+PKs8OeA8jRBtIjMku2Me4//BKrKaD4UeRWCcvkXgcmhxMhyJF2Qwoe2p4rNS4B9 dEX/c9ONZTevVAl5bB9GT/L/xdOwDmbdHDsm/PIh3DLevYXrQqq4fOUnYhZrP7TOeIq7 vMZNJ3S6nBaG/5Ya954BzSoZmFUpp9MX6eQEtswHPYYn3UZ2OFLtlj0janHWLu732/Y2 itvg== X-Gm-Message-State: AOAM533EDEBWYll3F7jsrulPddc2qdyWOVzMedEmAJLdwtmCdokqMpec t1FsN3221aQy1nrOKuQjoSumsQ== X-Google-Smtp-Source: ABdhPJwqWeX9e+tG2MpD7umwnMQK8EtYppvzUy29OuATfRDA7mQ/W4h/UISYrrTxabAZyatIakxOYg== X-Received: by 2002:a1c:2ed4:: with SMTP id u203mr13935532wmu.45.1613857577289; Sat, 20 Feb 2021 13:46:17 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id 36sm22073628wrj.97.2021.02.20.13.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 13:46:16 -0800 (PST) Date: Sat, 20 Feb 2021 21:46:14 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: Samer El-Haj-Mahmoud , devel@edk2.groups.io, Ard Biesheuvel , Pete Batard Subject: Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity Message-ID: <20210220214614.GL1664@vanye> References: <20210220164133.21746-1-Samer.El-Haj-Mahmoud@arm.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline *How* annoying was this? This is kind of useful information, well at the "would be good to see in a regular DEBUG build" level. This change will have suddenly effectively hidden a message that was already present in many platforms, where they were not (very) annoyingly repetitive during a normal boot. It feels the test suite is not the thing that we need to optimise debug output for. Is there some alternative way we can rate limit this? / Leif On Sat, Feb 20, 2021 at 17:50:43 +0100, Ard Biesheuvel wrote: > On Sat, 20 Feb 2021 at 17:41, Samer El-Haj-Mahmoud > wrote: > > > > the DEBUG message for using compilation time epoch is appearing very > > frequently on DEBUG firmware builds, for example during UEFI SCT runs. > > Reduce verbosity to avoid the annoying repetitive message. > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Pete Batard > > Signed-off-by: Samer El-Haj-Mahmoud > > > Reviewed-by: Ard Biesheuvel > > Merged as #1434 into master. > > > --- > > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c > > index 5c13ed4cf190..4210708cff36 100644 > > --- a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c > > +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c > > @@ -88,7 +88,7 @@ LibGetTime ( > > // > > EpochSeconds = BUILD_EPOCH; > > DEBUG (( > > - DEBUG_INFO, > > + DEBUG_VERBOSE, > > "LibGetTime: %s non volatile variable was not found - Using compilation time epoch.\n", > > mEpochVariableName > > )); > > -- > > 2.25.1 > >