From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by mx.groups.io with SMTP id smtpd.web08.16238.1613878147384817623 for ; Sat, 20 Feb 2021 19:29:07 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=RN1d8UFm; spf=pass (domain: nuviainc.com, ip: 209.85.166.44, mailfrom: rebecca@nuviainc.com) Received: by mail-io1-f44.google.com with SMTP id f20so9823916ioo.10 for ; Sat, 20 Feb 2021 19:29:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XVma0+zc0vW6GA6twiYbQWUsYB1yCAFNlVMiuuHLTB8=; b=RN1d8UFmK7c3EMv7NXXDeDp/Wrl5a7Xp/nsHk2Og4wbHeAvIoIcvR9/xBjHWNS/L/A nKLEiF0namQYgD0JeC7uyGP/mr2lLdBXGbraDcnKR3qEbcIWR5mhf6Mheqlk5u7lBLUE y8KnP7PYsXs82huB3PGmAX/JSlq3hvxsdzlbOoeLW7Xh7mqS4rciD76s3ApK61eBxx16 fjbEn3HpRA/N+6KShieLh+qrjs+tDW6Z1VhXajROg3FtIn98cbGc9XgZolW61V/l7sv7 8lrPO2XWctPtw7klXSjGjsPuhmrfm0tb5NhD5CEVyNpsvkGSQ4umhKNbuRn8EOeOg4CA xZhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XVma0+zc0vW6GA6twiYbQWUsYB1yCAFNlVMiuuHLTB8=; b=Q8+wrUNzuppNyxVkkB+X8Dfyd5zv1Ra706oTR/g5s7pLF7YC3eaV8xWXKBMqlBAkRV IhpAshVxDxdfE/8QZU/3KZFopMN4Yt8TUBw2nkfm3MmG6nR4x1rHzFQbE1n+1JlkZjq/ OaTWY71mBZN+EmwQK4SUQCL3dmV3sv05Uyt5XfR+WFrWAblP4nFP9xKmy0XnE7IXtsxL faElFQ/RFEoyuvMs2d6GjssoHsQ4ovT3Cr1LbNqNeXPIZdK2J0riWd+20cjGn76SBcaP erIKNH7lvopa7pUoznbjIER1daE30gmT5XA/fLYedcEnPzCRgU1OpU7UxjQ1MQKEfEC/ iMFg== X-Gm-Message-State: AOAM5310AppqrTh3P5nuzTywph3Kx1kwCdSCibpbvQLYqAc4KkYRutxb gqwS+S0CNBypleUdY3lwYz8N63bvzaB5tL70uq01E3Cvxks6JomL8jKFAabDFxuIXWbtGJ9kdRb oIjYLjG7JA4z0WFQ8JS7Vnvh6s0bzvOUaXaTpB4BeJGHujyfuvmnUNIcoOB042y7PmEh4Xw== X-Google-Smtp-Source: ABdhPJyK+pGcZ3a2ln+ZF4PH1y9Jfyins9QpOU2oX3NbMFwVr10UAzK2/HP56iF6DnPe/ztAe39wsg== X-Received: by 2002:a05:6602:2cd0:: with SMTP id j16mr10004004iow.96.1613878146410; Sat, 20 Feb 2021 19:29:06 -0800 (PST) Return-Path: Received: from cube.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id x17sm1098785ilm.40.2021.02.20.19.29.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 19:29:06 -0800 (PST) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Leif Lindholm , Ard Biesheuvel Subject: [PATCH v2 1/3] ArmPkg: Fix ordering of return type and EFIAPI specifier in OemMiscLib Date: Sat, 20 Feb 2021 20:28:58 -0700 Message-Id: <20210221032900.6485-2-rebecca@nuviainc.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210221032900.6485-1-rebecca@nuviainc.com> References: <20210221032900.6485-1-rebecca@nuviainc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The return type should be on the line before any EFIAPI specifier. Signed-off-by: Rebecca Cran --- ArmPkg/Include/Library/OemMiscLib.h | 14 +++++++------- ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 12 ++++++------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h index e70019d05f15..ad0e77685dbe 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -71,8 +71,8 @@ typedef enum @return CPU frequency in Hz **/ -EFIAPI UINTN +EFIAPI OemGetCpuFreq ( IN UINT8 ProcessorIndex ); @@ -87,8 +87,8 @@ OemGetCpuFreq ( @return TRUE on success, FALSE on failure. **/ -EFIAPI BOOLEAN +EFIAPI OemGetProcessorInformation ( IN UINTN ProcessorIndex, IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus, @@ -106,8 +106,8 @@ OemGetProcessorInformation ( @return TRUE on success, FALSE on failure. **/ -EFIAPI BOOLEAN +EFIAPI OemGetCacheInformation ( IN UINT8 ProcessorIndex, IN UINT8 CacheLevel, @@ -120,8 +120,8 @@ OemGetCacheInformation ( @return The maximum number of sockets. **/ -EFIAPI UINT8 +EFIAPI OemGetProcessorMaxSockets ( VOID ); @@ -132,8 +132,8 @@ OemGetProcessorMaxSockets ( @retval EFI_SUCCESS The chassis type was fetched successfully. **/ -EFIAPI EFI_STATUS +EFIAPI OemGetChassisType ( OUT UINT8 *ChassisType ); @@ -144,8 +144,8 @@ OemGetChassisType ( @return TRUE is the processor is present, FALSE otherwise. **/ -EFIAPI BOOLEAN +EFIAPI OemIsSocketPresent ( IN UINTN ProcessorIndex ); @@ -156,8 +156,8 @@ OemIsSocketPresent ( @param TokenToUpdate The string to update. @param Offset The field to get information about. **/ -EFIAPI VOID +EFIAPI OemUpdateSmbiosInfo ( IN EFI_HII_HANDLE HiiHandle, IN EFI_STRING_ID TokenToUpdate, diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c index 73cebef2d1b9..6b179941e414 100644 --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c @@ -23,8 +23,8 @@ @return CPU frequency in Hz **/ -EFIAPI UINTN +EFIAPI OemGetCpuFreq ( IN UINT8 ProcessorIndex ) @@ -43,8 +43,8 @@ OemGetCpuFreq ( @return TRUE on success, FALSE on failure. **/ -EFIAPI BOOLEAN +EFIAPI OemGetProcessorInformation ( IN UINTN ProcessorIndex, IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus, @@ -66,8 +66,8 @@ OemGetProcessorInformation ( @return TRUE on success, FALSE on failure. **/ -EFIAPI BOOLEAN +EFIAPI OemGetCacheInformation ( IN UINT8 ProcessorIndex, IN UINT8 CacheLevel, @@ -84,8 +84,8 @@ OemGetCacheInformation ( @return The maximum number of sockets. **/ -EFIAPI UINT8 +EFIAPI OemGetProcessorMaxSockets ( VOID ) @@ -117,8 +117,8 @@ OemGetChassisType ( @return TRUE is the processor is present, FALSE otherwise. **/ -EFIAPI BOOLEAN +EFIAPI OemIsSocketPresent ( IN UINTN ProcessorIndex ) @@ -133,8 +133,8 @@ OemIsSocketPresent ( @param TokenToUpdate The string to update. @param Offset The field to get information about. **/ -EFIAPI VOID +EFIAPI OemUpdateSmbiosInfo ( IN EFI_HII_HANDLE mHiiHandle, IN EFI_STRING_ID TokenToUpdate, -- 2.26.2