From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mx.groups.io with SMTP id smtpd.web09.16455.1613878151473257398 for ; Sat, 20 Feb 2021 19:29:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=SYL2bUY7; spf=pass (domain: nuviainc.com, ip: 209.85.166.179, mailfrom: rebecca@nuviainc.com) Received: by mail-il1-f179.google.com with SMTP id e2so7989431ilu.0 for ; Sat, 20 Feb 2021 19:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zSoj1NrFRKJSOkxKw64qGDA/6Ye/9Cu9vwGMFwvfQFE=; b=SYL2bUY7Hhe7EU4tp4fIokcXc7KiW4MeVdEIkuIfFPw6rGMu6KQ1xbuzQyZbHVn3Sl ts7c7PHHZQr9V2iUwtWPnGTW0LMVs1xximVjoDnM2tho76h2ZuoA72WvpuVrqDenAev0 5Yd8Ntc8Vpe/D4RygIM8o8dNVXtDa2n7vGidHqOHE3jeKA/ePeON81HTZjEGHfJHhaLk uP/ZVOp1Jxg9zmbDWwa10eFGHAQlpE7mjzgFDwr/GPHwxF8+jvS3PmNZ9+sws2lF+vjx vwJ2EfMD1djBZyoPOB7vWXeCwCP8z7lp7Ts+K40slYg+Khhy2pUWJD2PWL3qu4GNAAvh U9CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zSoj1NrFRKJSOkxKw64qGDA/6Ye/9Cu9vwGMFwvfQFE=; b=RwP7Razm4MYy5Vd5Nx6N55dMmPkSWXKzJO2osPGmvecJYE5c5jIdnr6Zv/U0k5hrrG HGYBbaK96n3llM7Fuhk4nqip3zdpzMlh1WwY61Cn2eDT8eWokFSH3m0Hd70X1Aj4nTf+ /wasPo08VyhHxO+w6UCkSdV/F57ogutIcqjtv5jcCWGNsp2sbzCnQG18ODURALR0FWKP SHmFphoAHFAS8lYglEilmfLBTFkqHwTI2ClAaowyg91sijrBHnqnfD5L/x76Iy7iIXR8 i3tCLBwuOBtrPbi3O14Tq0fXeo9dyHYjhovo3kZIC6EC8fHXDO2yX6fyEzSpNYUudOtF ncYg== X-Gm-Message-State: AOAM531zoYoMMwFfDPBs9Gut6jLHBQWFGQdGrd+RdPFilwg5zzQ1t/bO APpuz3mU2noKTNrlp35CRynbNGTiJPEJVwbfxnseVxCWLNKGUDGWwNMkeh2MV0r9oWSnD+aVw9o PDCYUb7q9zoy5WUZep8+3xJmaqROAfMEJyQQi19q7IumVUQf2+z2h8b/stS/lqiltEv4poQ== X-Google-Smtp-Source: ABdhPJyhQ7fb3YNOf3dpamrnr3lPhHi2HxMRP1iYapcdhDgL1YHwPBH9nU2J+b78d16nCdEGeppfyw== X-Received: by 2002:a92:4151:: with SMTP id o78mr10068756ila.117.1613878150638; Sat, 20 Feb 2021 19:29:10 -0800 (PST) Return-Path: Received: from cube.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id x17sm1098785ilm.40.2021.02.20.19.29.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Feb 2021 19:29:10 -0800 (PST) From: "Rebecca Cran" To: devel@edk2.groups.io Cc: Rebecca Cran , Leif Lindholm , Ard Biesheuvel Subject: [PATCH v2 3/3] ArmPkg: Update OemGetChassisType function to return MISC_CHASSIS_TYPE Date: Sat, 20 Feb 2021 20:29:00 -0700 Message-Id: <20210221032900.6485-4-rebecca@nuviainc.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210221032900.6485-1-rebecca@nuviainc.com> References: <20210221032900.6485-1-rebecca@nuviainc.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Update OemGetChassisType in OemMiscLib to return MISC_CHASSIS_TYPE instead of EFI_STATUS, which matches other OemMiscLib functions. Signed-off-by: Rebecca Cran --- ArmPkg/Include/Library/OemMiscLib.h | 8 +++----- ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 11 ++++------- 2 files changed, 7 insertions(+), 12 deletions(-) diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h index 31dfe7dac2a6..5f71b2ad48c7 100644 --- a/ArmPkg/Include/Library/OemMiscLib.h +++ b/ArmPkg/Include/Library/OemMiscLib.h @@ -128,14 +128,12 @@ OemGetMaxProcessors ( /** Gets the type of chassis for the system. - @param ChassisType The type of the chassis. - - @retval EFI_SUCCESS The chassis type was fetched successfully. + @retval The type of the chassis. **/ -EFI_STATUS +MISC_CHASSIS_TYPE EFIAPI OemGetChassisType ( - OUT UINT8 *ChassisType + VOID ); /** Returns whether the specified processor is present or not. diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c index b02a568426dd..6b233742feb0 100644 --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c @@ -95,19 +95,16 @@ OemGetMaxProcessors ( /** Gets the type of chassis for the system. - @param ChassisType The type of the chassis. - - @retval EFI_SUCCESS The chassis type was fetched successfully. + @retval The type of the chassis. **/ -EFI_STATUS +MISC_CHASSIS_TYPE EFIAPI OemGetChassisType ( - UINT8 *ChassisType + VOID ) { ASSERT (FALSE); - *ChassisType = MiscChassisTypeUnknown; - return EFI_SUCCESS; + return MiscChassisTypeUnknown; } /** Returns whether the specified processor is present or not. -- 2.26.2