From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.groups.io with SMTP id smtpd.web10.25532.1613940195850514861 for ; Sun, 21 Feb 2021 12:43:16 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=BMOXhTUI; spf=pass (domain: nuviainc.com, ip: 209.85.128.41, mailfrom: leif@nuviainc.com) Received: by mail-wm1-f41.google.com with SMTP id i9so1754637wml.5 for ; Sun, 21 Feb 2021 12:43:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=n0LAaPdxVzQniVVxidz6IYp8oiTxBy+uTRvYCseixCc=; b=BMOXhTUIa3HeLdQ/4qI1z4DFYlVeijRnUMuvWC/vZWCo9O67/D7xeYgtmZSQe3SQjs bit1RFulYGPdVxswPvDpKfcNoxN5D12ObW56gtadqt9rgKmauZii/pz4xFKvJ9YubX1A S3Wzg3FCVSAt1ULb+GOlPa/p1tOSc1tz6oVdTpnKG95m2T6wd+A53dBwQqs+Nb4T9MAQ 7T3XHte4pnFl/+HyPUGP6p27Qwb+BYnO6Sid3MMGQCMoGmImbA61/xvuxFPoIOk40XJb r1aaAC4XJz2TNabDrgZ7xkiGzB7zTD9VZCfTpM3mFw4xJEre051ufIpU0AsYb7vaNSnx Eemg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=n0LAaPdxVzQniVVxidz6IYp8oiTxBy+uTRvYCseixCc=; b=hqC1j8h1leIFAiYaJ3UoyAxY1+kn33QjDhBWabWba+zE0hByqpAcsAZm8vW4qC0yHA o6ndYeWvPfHnJp6Wpx4zQEPv9NJEfAPoed7i0HYKarmjAxY0yZipGLTS7AHv3YgPW+sz ID4EvEWTbQraG6E9MK8+MYI6H2FZ8SOYN303Yxq7S2k3Q2UusZb6tpIY3GbJ1ho5HhMM kLnMMU/uvq5Ba1DjzD158aalj31Pj6DIrd4LTxuPg2jIlcjevrweEVWw/ck6QfNqy6ON JgT2mKaM/hVulLBgue83rcWNTWFdiVV0KWSskaoQDYi3DLNd2zeDcc19BQN+NwmmKtkm qzCg== X-Gm-Message-State: AOAM533Ueac1RVbOApO21Bx5FqBQ+9G7KKv6FrFgsXzIpjiksvQePxVC /937D9iwi+GhKtgB9tctOk+/xg== X-Google-Smtp-Source: ABdhPJwPIk7O1PZN0Tc6QXPUYAwPe9eRFrdRAyQ2nFGz1AEWkA/d4aKQmfxIfZ0Gaix49OZfF9tm2A== X-Received: by 2002:a1c:80c6:: with SMTP id b189mr17513260wmd.21.1613940194480; Sun, 21 Feb 2021 12:43:14 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id p13sm12968149wrj.52.2021.02.21.12.43.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 12:43:14 -0800 (PST) Date: Sun, 21 Feb 2021 20:43:12 +0000 From: "Leif Lindholm" To: Ard Biesheuvel Cc: Samer El-Haj-Mahmoud , devel@edk2.groups.io, Ard Biesheuvel , Pete Batard Subject: Re: [edk2-platform][PATCH v1 1/1] EmbeddedPkg/VirtualRealTimeClockLib : Reduce DEBUG message verbosity Message-ID: <20210221204312.GM1664@vanye> References: <20210220164133.21746-1-Samer.El-Haj-Mahmoud@arm.com> <20210220214614.GL1664@vanye> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Feb 21, 2021 at 11:50:27 +0100, Ard Biesheuvel wrote: > On Sat, 20 Feb 2021 at 22:46, Leif Lindholm wrote: > > > > *How* annoying was this? > > > > This is kind of useful information, well at the "would be good to see > > in a regular DEBUG build" level. > > > > This change will have suddenly effectively hidden a message that was > > already present in many platforms, where they were not (very) annoyingly > > repetitive during a normal boot. > > > > It feels the test suite is not the thing that we need to optimise > > debug output for. > > > > Is there some alternative way we can rate limit this? > > Given that the sole purpose of this library is to paper over the fact > that the platform violates the spec, and lacks the ability to tell > time, I think it makes little sense to obsess over how wrong the value > is that it returns. I'm not obsessing about anything, I'm saying that using tediousness when running a testsuite as an argument, potential issues with the only aspect that makes this implementation useful without having to rebuild firmware every few weeks are now hidden. If we truly don't care about the feature, nuke it. Don't hide when it breaks. / Leif