From: "Leif Lindholm" <leif@nuviainc.com>
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>
Subject: Re: [PATCH v2 1/3] ArmPkg: Fix ordering of return type and EFIAPI specifier in OemMiscLib
Date: Sun, 21 Feb 2021 20:48:24 +0000 [thread overview]
Message-ID: <20210221204824.GN1664@vanye> (raw)
In-Reply-To: <20210221032900.6485-2-rebecca@nuviainc.com>
On Sat, Feb 20, 2021 at 20:28:58 -0700, Rebecca Cran wrote:
> The return type should be on the line before any EFIAPI specifier.
>
> Signed-off-by: Rebecca Cran <rebecca@nuviainc.com>
Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> ---
> ArmPkg/Include/Library/OemMiscLib.h | 14 +++++++-------
> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 12 ++++++------
> 2 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h
> index e70019d05f15..ad0e77685dbe 100644
> --- a/ArmPkg/Include/Library/OemMiscLib.h
> +++ b/ArmPkg/Include/Library/OemMiscLib.h
> @@ -71,8 +71,8 @@ typedef enum
>
> @return CPU frequency in Hz
> **/
> -EFIAPI
> UINTN
> +EFIAPI
> OemGetCpuFreq (
> IN UINT8 ProcessorIndex
> );
> @@ -87,8 +87,8 @@ OemGetCpuFreq (
>
> @return TRUE on success, FALSE on failure.
> **/
> -EFIAPI
> BOOLEAN
> +EFIAPI
> OemGetProcessorInformation (
> IN UINTN ProcessorIndex,
> IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus,
> @@ -106,8 +106,8 @@ OemGetProcessorInformation (
>
> @return TRUE on success, FALSE on failure.
> **/
> -EFIAPI
> BOOLEAN
> +EFIAPI
> OemGetCacheInformation (
> IN UINT8 ProcessorIndex,
> IN UINT8 CacheLevel,
> @@ -120,8 +120,8 @@ OemGetCacheInformation (
>
> @return The maximum number of sockets.
> **/
> -EFIAPI
> UINT8
> +EFIAPI
> OemGetProcessorMaxSockets (
> VOID
> );
> @@ -132,8 +132,8 @@ OemGetProcessorMaxSockets (
>
> @retval EFI_SUCCESS The chassis type was fetched successfully.
> **/
> -EFIAPI
> EFI_STATUS
> +EFIAPI
> OemGetChassisType (
> OUT UINT8 *ChassisType
> );
> @@ -144,8 +144,8 @@ OemGetChassisType (
>
> @return TRUE is the processor is present, FALSE otherwise.
> **/
> -EFIAPI
> BOOLEAN
> +EFIAPI
> OemIsSocketPresent (
> IN UINTN ProcessorIndex
> );
> @@ -156,8 +156,8 @@ OemIsSocketPresent (
> @param TokenToUpdate The string to update.
> @param Offset The field to get information about.
> **/
> -EFIAPI
> VOID
> +EFIAPI
> OemUpdateSmbiosInfo (
> IN EFI_HII_HANDLE HiiHandle,
> IN EFI_STRING_ID TokenToUpdate,
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> index 73cebef2d1b9..6b179941e414 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> @@ -23,8 +23,8 @@
>
> @return CPU frequency in Hz
> **/
> -EFIAPI
> UINTN
> +EFIAPI
> OemGetCpuFreq (
> IN UINT8 ProcessorIndex
> )
> @@ -43,8 +43,8 @@ OemGetCpuFreq (
>
> @return TRUE on success, FALSE on failure.
> **/
> -EFIAPI
> BOOLEAN
> +EFIAPI
> OemGetProcessorInformation (
> IN UINTN ProcessorIndex,
> IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus,
> @@ -66,8 +66,8 @@ OemGetProcessorInformation (
>
> @return TRUE on success, FALSE on failure.
> **/
> -EFIAPI
> BOOLEAN
> +EFIAPI
> OemGetCacheInformation (
> IN UINT8 ProcessorIndex,
> IN UINT8 CacheLevel,
> @@ -84,8 +84,8 @@ OemGetCacheInformation (
>
> @return The maximum number of sockets.
> **/
> -EFIAPI
> UINT8
> +EFIAPI
> OemGetProcessorMaxSockets (
> VOID
> )
> @@ -117,8 +117,8 @@ OemGetChassisType (
>
> @return TRUE is the processor is present, FALSE otherwise.
> **/
> -EFIAPI
> BOOLEAN
> +EFIAPI
> OemIsSocketPresent (
> IN UINTN ProcessorIndex
> )
> @@ -133,8 +133,8 @@ OemIsSocketPresent (
> @param TokenToUpdate The string to update.
> @param Offset The field to get information about.
> **/
> -EFIAPI
> VOID
> +EFIAPI
> OemUpdateSmbiosInfo (
> IN EFI_HII_HANDLE mHiiHandle,
> IN EFI_STRING_ID TokenToUpdate,
> --
> 2.26.2
>
next prev parent reply other threads:[~2021-02-21 20:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-21 3:28 [PATCH v2 0/3] ArmPkg: Fix several issues in OemMiscLib Rebecca Cran
2021-02-21 3:28 ` [PATCH v2 1/3] ArmPkg: Fix ordering of return type and EFIAPI specifier " Rebecca Cran
2021-02-21 20:48 ` Leif Lindholm [this message]
2021-02-21 3:28 ` [PATCH v2 2/3] ArmPkg: Rename some functions and parameters " Rebecca Cran
2021-02-21 21:21 ` Leif Lindholm
2021-02-21 23:04 ` Rebecca Cran
2021-02-22 12:35 ` Leif Lindholm
2021-02-22 14:33 ` Rebecca Cran
2021-02-21 3:29 ` [PATCH v2 3/3] ArmPkg: Update OemGetChassisType function to return MISC_CHASSIS_TYPE Rebecca Cran
2021-02-21 21:36 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210221204824.GN1664@vanye \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox