From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.groups.io with SMTP id smtpd.web10.25597.1613940508065927099 for ; Sun, 21 Feb 2021 12:48:28 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=NffE7JAN; spf=pass (domain: nuviainc.com, ip: 209.85.221.45, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f45.google.com with SMTP id r3so5341535wro.9 for ; Sun, 21 Feb 2021 12:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lc+GUClyfeEgn9eeaGqHqzpKaRjdx5S3JFwZWRo6ozs=; b=NffE7JANb7cZprKDs6lvezsnAtGMutz6mpBY0VtfdMyRKJeXmQhsZfaWMDhALFz4Vd +B8pLbKFqm5l9j7V0CmMOuZhos7qZjNoNaJQtsuzOlCRXGFwPhieoj3vJk0kXwkhFanL vI8ljSj4i7BpnqF3RsR896/tJAmBwzxJghXersEgrYo0EsM3b+vAT97u+hm4OtIi2iI1 Qn5CQgN0H0QPVchsymYRLAKENYiKB0IA/G1QuPvBRyc/Jxpwgi8VrKdb9jolAgM6mX0x luEdSXgJojuw0s8tcRNSgTUEPuK+AhzChnXGM7zMuSHRqrMFmhckNQFyxybERwXLgytt s94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lc+GUClyfeEgn9eeaGqHqzpKaRjdx5S3JFwZWRo6ozs=; b=dVR/IDQa3UuxmVRgdWNrwe0t9t+7eIpQnNqAnMZjb+8g2vsTI6xdkov6QUeGJ62q4v zYSSDDUExTj5TWhoaJABt7EeIyD5d9qOz4eb73PxMU5UPH7yitCdxGx35wBIikyO1VI9 kEeJFUaNj0AW8clOFnUuL14BFIdmY04EYsaT0At1eCGOppc3c/5/B5G5gwoNpCkgJpyY KSEZa+y0Kpi/R7Coa+g3GHLSta4U3cqlbu/rkHPJXZZVEcpO6MT5/8nvdHRxjNEIooKw gdGCcr7ZPIv3iuwR9rZMwwYk7bzFWm2kEhxgAFBLpWZsmLP/8EGLxxEuTHe9ccL5I53i uwtA== X-Gm-Message-State: AOAM5314kqdwIIGiGkhezqgePrfma7U6SrS1UP6EUEL4PLhfNY0Fwly6 LxsNRQbcxJvpmABzAQmm5y70+A== X-Google-Smtp-Source: ABdhPJyD7SD89KTp8CFht/bRZRAhBeAhFON1NSo2kDCm7j6pFd/CMieFU8M5H/k/v/aRDXvS0/GXWg== X-Received: by 2002:a5d:4b84:: with SMTP id b4mr18915809wrt.50.1613940506558; Sun, 21 Feb 2021 12:48:26 -0800 (PST) Return-Path: Received: from vanye (cpc1-cmbg19-2-0-cust915.5-4.cable.virginm.net. [82.27.183.148]) by smtp.gmail.com with ESMTPSA id b83sm19045845wmd.4.2021.02.21.12.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 12:48:26 -0800 (PST) Date: Sun, 21 Feb 2021 20:48:24 +0000 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel Subject: Re: [PATCH v2 1/3] ArmPkg: Fix ordering of return type and EFIAPI specifier in OemMiscLib Message-ID: <20210221204824.GN1664@vanye> References: <20210221032900.6485-1-rebecca@nuviainc.com> <20210221032900.6485-2-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210221032900.6485-2-rebecca@nuviainc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Feb 20, 2021 at 20:28:58 -0700, Rebecca Cran wrote: > The return type should be on the line before any EFIAPI specifier. > > Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm > --- > ArmPkg/Include/Library/OemMiscLib.h | 14 +++++++------- > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 12 ++++++------ > 2 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/ArmPkg/Include/Library/OemMiscLib.h b/ArmPkg/Include/Library/OemMiscLib.h > index e70019d05f15..ad0e77685dbe 100644 > --- a/ArmPkg/Include/Library/OemMiscLib.h > +++ b/ArmPkg/Include/Library/OemMiscLib.h > @@ -71,8 +71,8 @@ typedef enum > > @return CPU frequency in Hz > **/ > -EFIAPI > UINTN > +EFIAPI > OemGetCpuFreq ( > IN UINT8 ProcessorIndex > ); > @@ -87,8 +87,8 @@ OemGetCpuFreq ( > > @return TRUE on success, FALSE on failure. > **/ > -EFIAPI > BOOLEAN > +EFIAPI > OemGetProcessorInformation ( > IN UINTN ProcessorIndex, > IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus, > @@ -106,8 +106,8 @@ OemGetProcessorInformation ( > > @return TRUE on success, FALSE on failure. > **/ > -EFIAPI > BOOLEAN > +EFIAPI > OemGetCacheInformation ( > IN UINT8 ProcessorIndex, > IN UINT8 CacheLevel, > @@ -120,8 +120,8 @@ OemGetCacheInformation ( > > @return The maximum number of sockets. > **/ > -EFIAPI > UINT8 > +EFIAPI > OemGetProcessorMaxSockets ( > VOID > ); > @@ -132,8 +132,8 @@ OemGetProcessorMaxSockets ( > > @retval EFI_SUCCESS The chassis type was fetched successfully. > **/ > -EFIAPI > EFI_STATUS > +EFIAPI > OemGetChassisType ( > OUT UINT8 *ChassisType > ); > @@ -144,8 +144,8 @@ OemGetChassisType ( > > @return TRUE is the processor is present, FALSE otherwise. > **/ > -EFIAPI > BOOLEAN > +EFIAPI > OemIsSocketPresent ( > IN UINTN ProcessorIndex > ); > @@ -156,8 +156,8 @@ OemIsSocketPresent ( > @param TokenToUpdate The string to update. > @param Offset The field to get information about. > **/ > -EFIAPI > VOID > +EFIAPI > OemUpdateSmbiosInfo ( > IN EFI_HII_HANDLE HiiHandle, > IN EFI_STRING_ID TokenToUpdate, > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > index 73cebef2d1b9..6b179941e414 100644 > --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > @@ -23,8 +23,8 @@ > > @return CPU frequency in Hz > **/ > -EFIAPI > UINTN > +EFIAPI > OemGetCpuFreq ( > IN UINT8 ProcessorIndex > ) > @@ -43,8 +43,8 @@ OemGetCpuFreq ( > > @return TRUE on success, FALSE on failure. > **/ > -EFIAPI > BOOLEAN > +EFIAPI > OemGetProcessorInformation ( > IN UINTN ProcessorIndex, > IN OUT PROCESSOR_STATUS_DATA *ProcessorStatus, > @@ -66,8 +66,8 @@ OemGetProcessorInformation ( > > @return TRUE on success, FALSE on failure. > **/ > -EFIAPI > BOOLEAN > +EFIAPI > OemGetCacheInformation ( > IN UINT8 ProcessorIndex, > IN UINT8 CacheLevel, > @@ -84,8 +84,8 @@ OemGetCacheInformation ( > > @return The maximum number of sockets. > **/ > -EFIAPI > UINT8 > +EFIAPI > OemGetProcessorMaxSockets ( > VOID > ) > @@ -117,8 +117,8 @@ OemGetChassisType ( > > @return TRUE is the processor is present, FALSE otherwise. > **/ > -EFIAPI > BOOLEAN > +EFIAPI > OemIsSocketPresent ( > IN UINTN ProcessorIndex > ) > @@ -133,8 +133,8 @@ OemIsSocketPresent ( > @param TokenToUpdate The string to update. > @param Offset The field to get information about. > **/ > -EFIAPI > VOID > +EFIAPI > OemUpdateSmbiosInfo ( > IN EFI_HII_HANDLE mHiiHandle, > IN EFI_STRING_ID TokenToUpdate, > -- > 2.26.2 >